Does DirectCompositions CreateSurfaceFromHwnd preserve HDR content?

vb 276

Hi!

I am using IDCompositionDevice::CreateSurfaceFromHwnd to project HDR content at another window...

Will it preserve source HDR content ... will replica also be HDR?

Thanks in forward!
Vladimir

Jeanine Zhang-MSFT 8,951 Reputation points Microsoft Vendor

2022-11-15T06:00:56.67+00:00

@vb

Sorry for the late response.

It seems that whether or not HDR content is supported is related to whether the display device supports HDR. Microsoft DirectComposition is a Windows component that enables high-performance bitmap composition with transforms, effects, and animations. It doesn't seem to have much impact on whether HDR content is preserved or not.

And I will discuss this with another engineer to get a more accurate conclusion.

If there is any progress, I'll let you know.
Jeanine Zhang-MSFT 8,951 Reputation points Microsoft Vendor

2022-11-22T06:35:55.083+00:00

@vb

I have discuss this with another engineer. And we think the answer is yes. You could refer to the Docs:
Composition engine
Automatic system color management

However we need a more in-depth discussion. If there is any progress, I'll let you know.
vb 276 Reputation points

2022-11-22T17:23:20.45+00:00

Thanks!

Yes, I already have read docs, but, there was only about Visual Layer & DirectX. I assumed old DComp is compliant for HDR, as Visual Layer is extension of it.

I have had trouble using Windows.Graphics.Capture for capturing window. I have been capturing SDR (BGRA) window using FP16 (DXGI_FORMAT.R16G16B16A16_FLOAT) buffer, and, pushing captured FP16 frame at Visual Layer Visual. Resulting copy had bleached colors. It seams, there is color conversion...where, logically, result should be about identical. That is why I had suspicion about former.

Best regards!
V.
Jeanine Zhang-MSFT 8,951 Reputation points Microsoft Vendor

2022-11-30T06:50:06.437+00:00

Sorry for the late response.

I still think the answer is yes. DirectCompositions preserve HDR content. There may be other causes for this phenomenon. Could you please provide the sample to help us reproduce the phenomenon?
vb 276 Reputation points

2022-11-30T19:35:04.023+00:00
No problem, no hurry. Thanks!

Current code is too complex for to send it. I will investigate and try tweak code to give correct results... if I fail, then will cook some small reproducible sample and send it.

Still, I can give you some highlights:

a) Create & initialize D311 instance, BGRA_SUPPORT flagged

b) Get D2D1 device instance from former D311 device instance, ...these two (a, b) will use when initializing capture & Visual Layer

c) Capture SDR window using Windows.Graphics.Capture => Direct3D11CaptureFramePool::Create => pixel format R16G16B16A16Float

d) When Direct3D11CaptureFramePool.FrameArrived ...

CompositionGraphicsDevice.CreateDrawingSurface ( D2D1 device context as input) Convert captured frame using CompositionGraphicsDevice ... its Context as ID2D1DeviceContext => CreateBitmapFromDxgiSurface ( arrivedframe as IDXGISurface, bitmapProperties1, out ID2D1Bitmap1 frameBitmap ); ... where D2D1_BITMAP_PROPERTIES1 { OPTIONS.NONE, ALPHA_MODE_PREMULTIPLIED, R16G16B16A16_FLOAT } Draw converted frameBitmap using (CompositionGraphics Context as ID2D1DeviceContext).DrawImage

e) Drawn CompositionDrawingSurface put as brush at some Visual, and Visual at some ICompositionTarget (window)

-------------------------

Result output is bleached!

Best regards!
V.
Jeanine Zhang-MSFT 8,951 Reputation points Microsoft Vendor

2022-12-07T03:14:19.083+00:00

@vb

The issue is more complicated, in my opinion, until we get a repro sample, I don't think we can do much. Have you created a small reproducible sample? Could you please provide a small reproducible sample?