Potential Memory Leak

Simon Scott 306

Good morning all,

I have an Windows form based app which runs on various PC's 24/7.

However, the application over time consumes RAM and the PC will crash if not restarted manually.

My initial thoughts are to set a timer on the APP to restart after a certain period of time. However, i feel this isn't the best way to do this.

Can anyone help?

Thanks
Simon

Answer accepted by question author

Olaf Helper 47,586 Reputation points

2022-09-14T08:44:23.42+00:00

However, i am a basic programmer and have no idea what to do!

Run the VS Code Analysis, it show common design failures, like missing .Dispose() calls on managed objects, which causes high memory consumption.

https://github.com/MicrosoftDocs/visualstudio-docs/blob/main/docs/code-quality/how-to-run-code-analysis-manually-for-managed-code.md
Please sign in to rate this answer.
Simon Scott 306 Reputation points

2022-09-14T12:49:24.367+00:00

Thanks for your reply @Olaf Helper

I have run the VS Code Analysis and it says it has completed but doesn't indicate any changes or recommendations!

I believe that this section of the code is where i need to add in the "dispose" method but unsure exactly how to. I did try adding proc.dispose but the memory usage still increases when the app is running.

Dim sSubString = sString.Substring(sString.LastIndexOf("|") + 1).Trim()
Dim procStartInfo As System.Diagnostics.ProcessStartInfo = New System.Diagnostics.ProcessStartInfo("cmd", "/c" & ("tzutil.exe /s " + """" + sSubString + """"))
'Dim procStartInfo As System.Diagnostics.ProcessStartInfo = New System.Diagnostics.ProcessStartInfo("cmd", "/k" & ("tzutil.exe /s '" + sSubString + "'"))
Dim proc As System.Diagnostics.Process = New System.Diagnostics.Process()
proc.StartInfo = procStartInfo
procStartInfo.WindowStyle = ProcessWindowStyle.Hidden
proc.Start()

Thanks
Simon
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

1 additional answer

Bruce (SqlWork.com) 81,981 Reputation points Volunteer Moderator

2022-09-12T17:39:11.92+00:00

the best solution is to fix the memory leak.
Please sign in to rate this answer.
Simon Scott 306 Reputation points

2022-09-14T08:39:08.973+00:00

Hi Bruce.

Yes i do agree!

However, i am a basic programmer and have no idea what to do!

Could you give me any pointers?

Thanks
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

Your answer