System version with script powershell

Question

Hi,

I need know what build version have the all computers in my company. I try with this script but I get the same error. Where is the problem?

Get-ADComputer -Filter * -Properties OperatingSystem | Get-CimInstance -ClassName Win32_OperatingSystem

Error:

+ ... erties OperatingSystem | Get-CimInstance -Class Win32_OperatingSystem  
+                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  
    + CategoryInfo          : InvalidArgument: (:) [Get-CimInstance], CimException  
    + FullyQualifiedErrorId : HRESULT 0x80041017,Microsoft.Management.Infrastructure.CimCmdlets.GetCimInstanceCommand  
   
Get-CimInstance : Invalid query  

I never programmed in powershell, is my first time.

Regards,

Answer 1

If you have a lot of computers to check then you'll want to introduce some way to do concurrent queries, especially if you have computers that may be offline or inaccessible.

Here's a version that used jobs to run up to 32 queries at the same time:

$cn = Get-ADComputer -Filter * | Select-Object -ExpandProperty Name  
foreach ($name in $cn){  
    Start-Job -ScriptBlock {  
        $dd = Get-WmiObject -ClassName Win32_OperatingSystem -ComputerName $Using:name 2>&1 # redirect STDERR to STDOUT  
        # you should probably check the object type of $dd here to see if it's an ErrorRecord instead of  
        # blindly accepting it as the output that contains the data you expected!  
        # if it's an ErrorRecord you should build another PSCustomObject and place  
        # the result in either Version of Build  
        [PSCustomObject]@{  
            Name = $Using:name  
            Version = $dd.Version  
            Build = $dd.BuildNumber  
        }  
    } | Out-Null  
}  
  
Do{  
    Foreach ($j in (Get-Job -State Completed)) {  
        Receive-Job $j.Id |  
            Select-Object Name,Version,Build  
        Remove-Job $j.id | Out-Null  
    }  
} While (Get-Job)  

Answer 2

This might be a less resource intensive way of gathering the same information:

$cn = Get-ADComputer -Filter * | Select-Object -ExpandProperty Name  
Invoke-Command -ComputerName $cn -ScriptBlock{  
    $dd = Get-WmiObject -ClassName Win32_OperatingSystem -ComputerName $Using:name 2>&1 # redirect STDERR to STDOUT  
    # you should probably check the object type of $dd here to see if it's an ErrorRecord instead of  
    # blindly accepting it as the output that contains the data you expected!  
    # if it's an ErrorRecord you should build another PSCustomObject and place  
    # the result in either Version of Build  
    [PSCustomObject]@{  
        Name = $Using:name  
        Version = $dd.Version  
        Build = $dd.BuildNumber  
    }    
}  

My previous answer is more suitable for long-running tasks.