Can someone guess how to solve my problem of code?

Question

Can someone guess how to solve my problem of code?

Elias Daoud 0

I have the following code, I cannot guess why VBA enter the code written under while.

first condition is Empty=Empty, where it should be <> and not =.

the second part is related by "And", so the first condition is not satisficed, so why the debugger enter the code?

User's image

Barry Schwarz 4,626 Reputation points

2023-06-12T18:17:16.3366667+00:00
And has higher precedence that Or. Your code is parsed as

(Value <> Empty And Not inOrder) Or ....

So even though the And evaluates false, the right half of the Or is then evaluated.

Your blue highlights are not at the same nesting level. The matching bracket for the first highlight is the right parenthesis following inOrder. You probably want to check the And-Or pairings also.
Elias Daoud 0 Reputation points

2023-06-13T05:18:40.4233333+00:00

No, they are matching. no error from the debugger, so the first (...<>Empty) And, is completely separated from (( Not inOrder ...))) otherwise the IDE will gives error. And I count the parenthesis, they are match. The left one is separated from the right by "And" . and the left one is not satisfied, so the debugger shall stop there.

Note: the "Or" is as it is, it is inside the bigger group of ( ) only it join the (not inOrder) with all the remain code.
Barry Schwarz 4,626 Reputation points

2023-06-13T08:25:50.47+00:00

The debugger can only diagnose syntax errors, not logic errors. Your expression is syntactically correct; it just doesn't do what you want.

Your Code reads as follows

while (exp1) and (exp2) or ...

Since and has higher precedence than or, this is parsed as

while ((exp1) and (exp2)) or ...

Since exp1 is false, the entire and expression is false. As with any or expression, when the left half is false, the right half is evaluated. In your case, that half evaluates to true.

If you want an empty value to drive the entire expression false, you need

while (exp1) and ((exp2) or ...)

Your excessive parentheses around each logical expression serve to block your view.

Your answer

Barry Schwarz 4,626 Reputation points

2023-06-12T18:17:16.3366667+00:00

And has higher precedence that Or. Your code is parsed as

(Value <> Empty And Not inOrder) Or ....

So even though the And evaluates false, the right half of the Or is then evaluated.

Your blue highlights are not at the same nesting level. The matching bracket for the first highlight is the right parenthesis following inOrder. You probably want to check the And-Or pairings also.
Elias Daoud 0 Reputation points

2023-06-13T05:18:40.4233333+00:00

No, they are matching. no error from the debugger, so the first (...<>Empty) And, is completely separated from (( Not inOrder ...))) otherwise the IDE will gives error. And I count the parenthesis, they are match. The left one is separated from the right by "And" . and the left one is not satisfied, so the debugger shall stop there.

Note: the "Or" is as it is, it is inside the bigger group of ( ) only it join the (not inOrder) with all the remain code.
Barry Schwarz 4,626 Reputation points

2023-06-13T08:25:50.47+00:00

The debugger can only diagnose syntax errors, not logic errors. Your expression is syntactically correct; it just doesn't do what you want.

Your Code reads as follows

while (exp1) and (exp2) or ...

Since and has higher precedence than or, this is parsed as

while ((exp1) and (exp2)) or ...

Since exp1 is false, the entire and expression is false. As with any or expression, when the left half is false, the right half is evaluated. In your case, that half evaluates to true.

If you want an empty value to drive the entire expression false, you need

while (exp1) and ((exp2) or ...)

Your excessive parentheses around each logical expression serve to block your view.

Share via

Can someone guess how to solve my problem of code?

Your answer