Unable to hide an edit control programmatically

Ramesh Deekonda 216

Hi,

I am unable to hide an edit control on a property page using ShowWIndow(SW_HIDE). For the edit controlI have defined a control variable
noOldZipBackups of type CEdit .Then I have tried noOldZIpBackups.ShowWIndow(SW_HIDE), and also tried using the Item ID GetDlgItem(IDC_NOOLDZIPBACKUPS)->ShowWindow(SW_HIDE).I also tried hiding using the window handle of control.

I have traced execution of the program in the debugger but could not point out the problem. Problem appears with any edit control on the page.
I am calling the hide logic in the handler of a list box and also in the WM_PAINT handler of other controls on the property page.
The ShowWindow call is in the main user interface thread and not in a worker thread.
I have also tried ShowWindowAsync but still could not hide the control.

RLWA32 45,141 Reputation points

2021-06-13T16:42:48.383+00:00

I suggest you start by simplifying the code. Comment out all of the existing logic to hide/show the edit control. Add a check box control to the property page. Add a handler for the check box BN_CLICKED notification. In the handler, if the check box is checked, hide the edit control. If the check box is unchecked then show the edit control. Does this simple scenario work properly?
Ramesh Deekonda 216 Reputation points

2021-06-13T17:03:47.167+00:00

@RLWA32 Thanks I am trying your suggestions and will get back with results

Ramesh Deekonda 216

Still not able to hide the control.
I tried out as you suggested namely commenting all code corresponding to the edit control and added a check box to hide/show the edit control from the check box as below.

void CRunJobPage::OnBnClickedDbgcheck1()
{
    // TODO: Add your control notification handler code here

    if (m_DbgCheck1.GetCheck())
    {
        GetDlgItem(IDC_NOOLDZIPBACKUPS_P)->ShowWindow(SW_HIDE);
        m_NoOldBackups1.ShowWindow(SW_HIDE);
    }
    else
        GetDlgItem(IDC_NOOLDZIPBACKUPS_P)->ShowWindow(SW_SHOW);
    m_NoOldBackups1.UpdateWindow();
}

I am in India time. Get Back to you later. Please excuse.

Viorel 116.6K Reputation points

2021-06-13T18:20:20.65+00:00

Try executing ShowWindow(SW_HIDE) unconditionally and verify the result using IsWindowVisible.

Maybe there is a property page that is displayed, but your program deals with a different window or with wrong control.

Check some other operations, such as setting the text of edit control.
RLWA32 45,141 Reputation points

2021-06-13T19:02:22.333+00:00

Can you programmatically store text in the edit control? If the text that you store in the control is not displayed on the screen that would indicate that you are working with the wrong control.
Sam of Simple Samples 5,541 Reputation points

2021-06-13T20:31:52.58+00:00

Are you familiar with Spy++? Look in the Visual Studio Tools menu for it. You can use it to look at the controls. You can look at the item ids, handles and styles of controls.
Song Zhu - MSFT 906 Reputation points

2021-06-14T07:14:13.66+00:00

Have you tried to hide an edit control that is not on the property page, if it works, perhaps as GuidoFranzke said, you need to redraw the entire property page.

Accepted answer

Guido Franzke 2,196 Reputation points

2021-06-14T05:58:20.177+00:00

Hello,
I've had this problem before too. I got rid of it by redrawing the whole property page instead of only the single edit control (this is done by ShowWindow already too).
Instead of "m_NoOldBackups1.UpdateWindow();" try "RedrawWindow();".
Regards, Guido

Edit: which VS are you using?
Please sign in to rate this answer.
Ramesh Deekonda 216 Reputation points

2021-06-14T08:01:27.86+00:00

Using RedrawWindow instead of UpdateWindow() doesn't solve the problem.
I am using vs2017. The control gets disabled with ShowWIndow(SW_HIDE) and enabled with ShowWindow(SW_SHOW) but it is still visible.
How do I repaint the whole property page instead of a part? this is not clear to me.I have implemented WM_CTLCOLOR on the propertypage
tinkering around with it did not make any difference.

Guido Franzke 2,196 Reputation points

2021-06-14T08:14:18.263+00:00

To redraw the whole property page, use "RedrawWindow();" - as I said before.

void CRunJobPage::OnBnClickedDbgcheck1() { if (m_DbgCheck1.GetCheck() == BST_CHECKED) m_NoOldBackups1.ShowWindow(SW_HIDE); else m_NoOldBackups1.ShowWindow(SW_SHOW); RedrawWindow(); }

Ramesh Deekonda 216 Reputation points

2021-06-14T08:59:46.597+00:00

Ok I have done exactly as above. Still it always shows the edit control. I have also tried Invaildate() on property page.

Ramesh Deekonda 216 Reputation points

2021-06-14T09:16:25.91+00:00

It works if I call the PropertySheet-->RedrawWindow i.e on the parent of PropertyPage.
code as below. I don't know if that is the proper solution.
void CRunJobPage::OnBnClickedDbgcheck1()
{
if (m_DbgCheck1.GetCheck() == BST_CHECKED)
m_NoOldBackups1.ShowWindow(SW_HIDE);
else
m_NoOldBackups1.ShowWindow(SW_SHOW);
GetParent()->RedrawWindow();
}
Please point out if it is the correct solution.
Thanks to GuidoFranzke.

Guido Franzke 2,196 Reputation points

2021-06-14T09:57:43.54+00:00

So it works, then it's a correct solution.
If the window does not repaint correctly, then repaint the parent window and so on.
Regards, Guido

Viorel 116.6K Reputation points

2021-06-14T11:26:06.01+00:00

If you are interested, you can continue your research to find the cause of the issue, and fix it. For example, maybe the handler of WM_CTLCOLOR is imperfect or property pages are not managed correctly.

Ramesh Deekonda 216 Reputation points

2021-06-14T12:21:10.01+00:00

If the GetParent()->RedrawWindow() calls the OnSetActive() of all the property pages it may cause some side effects which need to be checked.
I am checking if the SetActive messages of PropertyPages are processed by the RedrawWindow().

Ramesh Deekonda 216 Reputation points

2021-06-14T12:46:18.08+00:00

SetActive messages are not fired by the RedrawWindow() so it looks Ok.
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

Share via

Unable to hide an edit control programmatically

0 additional answers

Your answer