About 7 years ago we had Dell (and their consultants) setup a new environment to virtualize our entire previously all-physical infrastructure. This consisted of 2 Server 2012 Hyper-v hosts connected to a iSCSI SAN in a failover cluster. All servers were P2Vd and ran as VMs on the cluster, including the file servers. The file servers were assigned large VHDs on the same CSV the VMs run on. This worked just fine for all these years.
Now we are setting up a 2019 S2D cluster with 3 nodes all local storage. My question is, is it best to keep the same setup for file servers? IE, create a large CSV and create a file server VM on it. Then create a large VHDX on the same CSV that is "local" to the VM for file storage. Users will access files, obviously, using \\fileserver\share.
Any thoughts or comments on this approach?