Shouldn't this code generate C4473

Question

Shouldn't this code generate C4473

This line of code isn't generating any errors:

sprintf(szErrFmtStr, "Failed to connect to %s");

shouldn't this generate C4473 - not enough arguments passed for format string

Or am I missing something? The code compiles without warnings, but gives an access violation when executed. It doesn't look like the warning is disabled.

I'm compiling with VS2019, warning level set to 4.

David Lowndes 4,541 MVP

It shows a warning for me with the latest VS2022 tools:

warning C4473: 'sprintf' : not enough arguments passed for format string  
message : placeholders and their parameters expect 1 variadic arguments, but 0 were provided  
message : the missing variadic argument 1 is required by format string '%s'  
error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

James Bloom-Scheff 1 Reputation point

2022-06-29T18:12:10.263+00:00

I'm pretty sure that I saw it with visual studio a few weeks ago in this same code. I disabled it then because I had higher priority stuff to deal with. Just reenabled it and it doesn't generate anymore.

MS just released an update. Let me see what that does

Nope. Still not getting a warning

David Lowndes 4,541 Reputation points MVP

2022-06-29T17:45:16.017+00:00

It shows a warning for me with the latest VS2022 tools:

warning C4473: 'sprintf' : not enough arguments passed for format string message : placeholders and their parameters expect 1 variadic arguments, but 0 were provided message : the missing variadic argument 1 is required by format string '%s' error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
James Bloom-Scheff 1 Reputation point

2022-06-29T18:12:10.263+00:00

I'm pretty sure that I saw it with visual studio a few weeks ago in this same code. I disabled it then because I had higher priority stuff to deal with. Just reenabled it and it doesn't generate anymore.

MS just released an update. Let me see what that does

Nope. Still not getting a warning

Answer 1

James Bloom-Scheff 1

Well, I found this

define sprintf libintl_sprintf

so its not sprintf being called but libintl_sprintf. I imagine that means the compile doesn't know to check the arguments.

That was it

Shouldn't this code generate C4473

1 answer

define sprintf libintl_sprintf

Activity