CA2143: Transparent methods should not use security demands

Article
11/04/2016

Item	Value
RuleId	CA2143
Category	Microsoft.Security
Breaking change	Breaking

Cause

A transparent type or method is declaratively marked with a System.Security.Permissions.SecurityAction.Demand demand or the method calls the System.Security.CodeAccessPermission.Demand method.

Note

This rule has been deprecated. For more information, see Deprecated rules.

Rule description

Security transparent code should not be responsible for verifying the security of an operation, and therefore should not demand permissions. Security transparent code should use full demands to make security decisions and safe-critical code should not rely on transparent code to have made the full demand. Any code that performs security checks, such as security demands, should be safe-critical instead.

How to fix violations

In general, to fix a violation of this rule, mark the method with the SecuritySafeCriticalAttribute attribute. You can also remove the demand.

When to suppress warnings

Do not suppress a warning from this rule.

Example

The rule files on the following code because a transparent method makes a declarative security demand.

using System;
using System.Security;
using System.Security.Permissions;

namespace TransparencyWarningsDemo
{

    public class TransparentMethodDemandClass
    {
        // CA2142 violation - transparent code using a Demand.  This can be fixed by making the method safe critical.
        [PermissionSet(SecurityAction.Demand, Unrestricted = true)]
        public void TransparentMethod()
        {
        }
    }
}

Share via