A family of Microsoft relational database management systems designed for ease of use.
InStr is a built-in function, so it is not suitable as the name for the argument of the function.
You overwrite xpandProvince each time, instead of accumulating the changes.
Function xpandProvince(InputString As String) As String
Dim regEx As Object
Dim Matches 'I don't really use this (yet)
Dim ReturnString As String
Set regEx = CreateObject("VBScript.RegExp")
regEx.IgnoreCase = False
regEx.Global = True
regEx.MultiLine = True
ReturnString = InputString
regEx.Pattern = "\bAB\b"
ReturnString = regEx.Replace(ReturnString, "Alberta")
regEx.Pattern = "\bBC\b"
ReturnString = regEx.Replace(ReturnString, "British Columbia")
regEx.Pattern = "\bMB\b"
ReturnString = regEx.Replace(ReturnString, "Manitoba")
regEx.Pattern = "\bNB\b"
ReturnString = regEx.Replace(ReturnString, "New Brunswick")
regEx.Pattern = "\bNL\b"
ReturnString = regEx.Replace(ReturnString, "Newfoundland")
regEx.Pattern = "\bNS\b"
ReturnString = regEx.Replace(ReturnString, "Nova Scotia")
regEx.Pattern = "\bNT\b"
ReturnString = regEx.Replace(ReturnString, "Northwest Territories")
regEx.Pattern = "\bNU\b"
ReturnString = regEx.Replace(ReturnString, "Nunavut")
regEx.Pattern = "\bON\b"
ReturnString = regEx.Replace(ReturnString, "Ontario")
regEx.Pattern = "\bPE\b"
ReturnString = regEx.Replace(ReturnString, "Prince Edward Island")
regEx.Pattern = "\bPEI\b"
ReturnString = regEx.Replace(ReturnString, "Prince Edward Island")
regEx.Pattern = "\bQC\b"
ReturnString = regEx.Replace(ReturnString, "Quebec")
regEx.Pattern = "\bSK\b"
ReturnString = regEx.Replace(ReturnString, "Saskatchewan")
regEx.Pattern = "\bYT\b"
ReturnString = regEx.Replace(ReturnString, "Yukon")
xpandProvince = ReturnString
End Function 'xpandProvince