How to add NS record (DNS resource record) to Domain Controller using DnsModifyRecordsInSet_A API ?

Question

How to add NS record (DNS resource record) to Domain Controller using DnsModifyRecordsInSet_A API ?

Khoa Tran 0

Hi Team,

We are implementing a feature that allows adding DNS resource records remotely to Domain Controller, and we found the following API DnsModifyRecordsInSet_A to perform this action, currently, this API can add most DNS records except NS one. And we have to perform dnscmd in order to add NS record, could we do this action using API? If yes, could you please share with me which API should I use to do it? Thanks in advance

https://learn.microsoft.com/en-us/windows/win32/api/windns/nf-windns-dnsmodifyrecordsinset_a

Thanks

Khoa Tran

Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-14T05:07:44.03+00:00

Have you set the DNS_RECORDA structure properly with DNS_TYPE_NS DNS Record Type? Could you please show a minimal, reproducible sample without private information? What's the error code when DnsModifyRecordsInSet with NS DNS Record Type?

Khoa Tran 0

Hi, @xiaopo yang

Below is a sample program that I have implemented, when we try to add NS record, then an error occurs with error code 9005. Could you please help to a look and let me know your ideas? Thanks

#include <stdlib.h>
#include <stdio.h>
#include <WinSock2.h>
#include <process.h>
#include <winapifamily.h>
#include <string>

#include <wtypes.h>
#include <WinDNS.h>
#include <winerror.h>
#include <exception>

DNS_RECORD * addRec = NULL;
DNS_RECORD * delRec = NULL;

long option = DNS_UPDATE_SECURITY_ON;
bool operation = true;
HANDLE contexHandle = NULL;
SEC_WINNT_AUTH_IDENTITY crendentials;

static struct {
	const char *rr_name;
	WORD rr_type;
	int qsi_type;
} rr_types_table[] = {
	{ "A", DNS_TYPE_A, 1 },
	{ "NS", DNS_TYPE_NS, 2 },
	{ "CNAME", DNS_TYPE_CNAME, 5}
};

static void GetSecurityContext(HANDLE & contextHandle, SEC_WINNT_AUTH_IDENTITY &credentials, const std::string &Domain, const std::string &User, const std::string &Password){
	const char * U = reinterpret_cast<const char *>(User.c_str());
	const char * DM = reinterpret_cast<const char *>(Domain.c_str());
	const char * P = reinterpret_cast<const char *>(Password.c_str());

	credentials.User = (unsigned char *)(U);
	credentials.Domain = (unsigned char *)(DM);
	credentials.Password = (unsigned char *)(P);

	credentials.Flags = SEC_WINNT_AUTH_IDENTITY_ANSI;
	credentials.UserLength = User.length();
	credentials.DomainLength = Domain.length();
	credentials.PasswordLength = Password.length();

	DNS_STATUS status = DnsAcquireContextHandle(FALSE, &credentials, &contexHandle);

	if (status == ERROR_SUCCESS) {
		return;
	}
	else {
		contexHandle = NULL;
	}
}

static WORD mapType(const std::string &type) {
	int max_type = (sizeof(rr_types_table) / sizeof(rr_types_table[0]));
	for (int i = 0; i < max_type; i++){
		if (type.compare(rr_types_table[i].rr_name) == 0){
			return rr_types_table[i].rr_type;
		}
	}

	return DNS_TYPE_ZERO;
}

static void PopulateDNSRecData(DNS_RECORD * &dnsRec, const std::string &type, const std::string &data) {
	try {
		WORD wType = mapType(type);

		if (wType == DNS_TYPE_ZERO){
			dnsRec = NULL;
		}

		if ((wType != DNS_TYPE_ISDN) && (wType != DNS_TYPE_HINFO) && (wType != DNS_TYPE_X25) && (wType != DNS_TYPE_TEXT)) {
			dnsRec = (DNS_RECORD *)calloc(1, sizeof(DNS_RECORD));
			if (dnsRec) {
				int a = 0;
			}

			switch (wType)
			{
			case DNS_TYPE_A:
			{
				const char * dataARR = reinterpret_cast<const char *>(data.c_str());
				dnsRec->Data.A.IpAddress = inet_addr(dataARR);
				dnsRec->wDataLength = sizeof(dnsRec->Data.A);
				break;
			}
			case DNS_TYPE_NS:
			case DNS_TYPE_CNAME:
			{
				const char * dataARR = reinterpret_cast<const char *>(data.c_str());
				dnsRec->Data.NS.pNameHost = strdup(dataARR);
				dnsRec->wDataLength = sizeof(dnsRec->Data.NS);
				break;
			}

			default:
				free(dnsRec);
				dnsRec = NULL;
			}

			dnsRec->wType = wType;
		}
	}
	catch (...) {
		throw;
	}
}

static void CreateDNSAPIRec(int ttl, const std::string &owner, const std::string &type, const std::string &data, bool operation, DNS_RECORD * &addRec, DNS_RECORD * &delRec) {
	DNS_RECORD *dnsRec = NULL;
	PopulateDNSRecData(dnsRec, type, data);
	dnsRec->pNext = NULL;
	dnsRec->dwTtl = ttl;
	dnsRec->Flags.S.CharSet = DnsCharSetAnsi;

	const char * O = reinterpret_cast<const char *>(owner.c_str());
	dnsRec->pName = (PSTR)strdup(O);

	if (operation == true) {
		addRec = dnsRec;
		delRec = NULL;
	}
	else {
		addRec = NULL;
		delRec = dnsRec;
	}
}

void main(int argc, char *argv[]) {
	DNS_STATUS status = ERROR_SUCCESS;

	DNS_STATUS query_status = ERROR_SUCCESS;

	IP4_ARRAY ServerArray;

	ServerArray.AddrCount = 1;
	ServerArray.AddrArray[0] = inet_addr("192.168.89.113");
	GetSecurityContext(contexHandle, crendentials, "example.com", "NU", "123456x@X");

	CreateDNSAPIRec(300, "rr9.example.com", "NS", "rr8.example.com", operation, addRec, delRec);

	status = DnsModifyRecordsInSet_A(addRec, NULL, option, contexHandle, &ServerArray, NULL);
	if (status != 0){
		printf("Update record failed, status code: %d\n", status);
	}
}

Thanks

Khoa Tran

Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-16T01:46:41.37+00:00

As DNS_PTR_DATAA said, NS resource records specified in section 3.3.11. NS RDATA format of RFC 1035 is a defined format.

Did you add the NS record rr8.example.com successfully via dnscmd and then did it work properly? What's the value of status? Can you utilize Add-DnsServerResourceRecord powershell cmdlet?
Khoa Tran 0 Reputation points

2023-02-16T07:48:06.63+00:00
Agree, NS and CNAME resource records are a part of DNS_PTR_DATAA (see photo below), but in the block of code below, only CNAME record can be processed successfully, it is failed to add NS record. Not sure what are missing, but we also use the struct DNS_PTR_DATAA

case DNS_TYPE_NS: case DNS_TYPE_CNAME: { const char * dataARR = reinterpret_cast<const char *>(data.c_str()); dnsRec->Data.NS.pNameHost = strdup(dataARR); dnsRec->wDataLength = sizeof(dnsRec->Data.NS); break; }
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-22T05:15:31.74+00:00

Did you add the NS record rr8.example.com successfully via dnscmd and then did it work properly? What's the value of status? Can you utilize Add-DnsServerResourceRecord powershell cmdlet?

2 answers

Your answer

Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-14T05:07:44.03+00:00

Have you set the DNS_RECORDA structure properly with DNS_TYPE_NS DNS Record Type? Could you please show a minimal, reproducible sample without private information? What's the error code when DnsModifyRecordsInSet with NS DNS Record Type?
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-16T01:46:41.37+00:00

As DNS_PTR_DATAA said, NS resource records specified in section 3.3.11. NS RDATA format of RFC 1035 is a defined format.

Did you add the NS record rr8.example.com successfully via dnscmd and then did it work properly? What's the value of status? Can you utilize Add-DnsServerResourceRecord powershell cmdlet?
Khoa Tran 0 Reputation points

2023-02-16T07:48:06.63+00:00

Agree, NS and CNAME resource records are a part of DNS_PTR_DATAA (see photo below), but in the block of code below, only CNAME record can be processed successfully, it is failed to add NS record. Not sure what are missing, but we also use the struct DNS_PTR_DATAA

case DNS_TYPE_NS: case DNS_TYPE_CNAME: { const char * dataARR = reinterpret_cast<const char *>(data.c_str()); dnsRec->Data.NS.pNameHost = strdup(dataARR); dnsRec->wDataLength = sizeof(dnsRec->Data.NS); break; }
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-02-22T05:15:31.74+00:00

Did you add the NS record rr8.example.com successfully via dnscmd and then did it work properly? What's the value of status? Can you utilize Add-DnsServerResourceRecord powershell cmdlet?

Answer 1

Limitless Technology 44,776

Hello there,

Updating a single existing NS Record using the API requires specific syntax depending on whether you are using REST or SOAP.

/REST/NSRecord/ POST — Create a new NS Record on the zone/node indicated.

Hope this resolves your Query !!

--If the reply is helpful, please Upvote and Accept it as an answer–

Answer 2

Khoa Tran 0

Hi,

We don't use REST or SOAP to add DNS records, there is SDK as the link below that provides functions to add these records except NS. Can you clarify more about your suggestion? Thanks in advance.

https://learn.microsoft.com/en-us/windows/win32/api/windns/nf-windns-dnsmodifyrecordsinset_a

Thanks

Khoa Tran

Share via

How to add NS record (DNS resource record) to Domain Controller using DnsModifyRecordsInSet_A API ?

2 answers

Your answer