turbines loading affect animation and add Mutiple times

Question

turbines loading affect animation and add Mutiple times

Eduardo Gomez Romero 1,355

So, the little bug that I have is that the turbines take a long time, hance the map take time to load

and the turbines get re-added, every time I come back to this page

 public ObservableCollection<TurbinePin> TurbinePins { get; set; } = [];

 public ObservableCollection<MapTypeButton> MapTypeButtons { get; set; } = [];

 public ChargingStationsMapPageViewModel(TurbinesService turbinesService, IServiceProvider serviceProvider)
 {
     MapDialogButtons();
     _turbineServices = turbinesService;

     _serviceProvider = serviceProvider;
 }

 private void MapDialogButtons()
 {
     MapTypeButtons.Add(new MapTypeButton
     {
         Caption = "Default",
         ImageName = FontAwesome.Road,
         Selected = true,
         MapNumber = 1
     });
     MapTypeButtons.Add(new MapTypeButton
     {
         Caption = "Satellite",
         MapNumber = 2,
         ImageName = FontAwesome.StreetView,
     });
 }

 private async Task LoadTurbinePins()
 {
     TurbinePins.Clear();

     await _turbineServices.InitializeAsync();
     var turbinePins =
         await _turbineServices.GetTurbinePinsForUI(PinMarkerClickedCommand);

     foreach (var pin in turbinePins)
     {
         TurbinePins.Add(pin);
     }
     Loaded = true;
 }
 [RelayCommand]
 private async Task AppearingAsync(Map map)
 {
     MapView ??= map;
     await LoadTurbinePins();
 }

Also, the app takes some time to show the pins, So I don't know if I should call then service in the shell or the app.cs

https://1drv.ms/u/s!AuPWj2VdUNuhv-pSHEimcy0DhVcKzQ?e=5RGO1C

Also, when I navigate thru tabs, I can see the last tab (on phones) for 2 seconds

Accepted answer

0 additional answers

Your answer

Answer 1

Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Microsoft External Staff

Hello,

So, the little bug that I have is that the turbines take a long time, hance the map take time to load

This is not a bug, but expected behavior.

Since you load the data in the OnAppearing method of the page, it will be reloaded from the network request on every page load.

LoadTurbinePins is a very expensive method, which contains service initialization and two collection traversals.

You should try to reduce the number of executions of this method. For example, you can write data to a local file, and if the local file already exists, read the data from the local file. If the user does not update the data, there is no need to initiate a network request again.

You can refer to the documentation provided by .net on how to serialize objects to json files and deserialize from json files to objects.

Best Regards,

Alec Liu.

If the answer is the right solution, please click "Accept Answer" and kindly upvote it. If you have extra questions about this answer, please click "Comment".

Note: Please follow the steps in our documentation to enable e-mail notifications if you want to receive the related email notification for this thread.

Eduardo Gomez Romero 1,355 Reputation points

2024-11-28T08:17:13.27+00:00

Ok so don't call it in the appear, so where should I call it

by the way that is a great idea thanks
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2024-12-03T06:42:01.1766667+00:00
You can put the serialization in the LoadTurbinePins method. When the TurbinePins are loaded, write the data to the local file. Then, in the AppearingAsync method body, if the local file already exists, serialize it from the local file.

private async Task AppearingAsync(Map map) { MapView ??= map; if(localJsonFile Exists && other conditions){ // You also need some other conditions, such as whether the data is not updated, the time since the last load, etc. // serialize }else{ await LoadTurbinePins(); } }

Share via

turbines loading affect animation and add Mutiple times

0 additional answers

Your answer