This browser is no longer supported.
Upgrade to Microsoft Edge to take advantage of the latest features, security updates, and technical support.
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(297.6, 64%, 38%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EF%3C/text%3E%3C/svg%3E)
Task: I need to get deleted item having SHITEMID data.
SHITEMID is defined as:
typedef struct _ITEMIDLIST
{
SHITEMID mkid;
}ITEMIDLIST;
defined in C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\shtypes.h
I have the following code to get mkid:
First, get display name from LPITEMIDLIST:
std::wstring CMyClass::GetDisplayName(IShellFolder *pShellFolder, const LPITEMIDLIST pidl)
{
if (!pShellFolder)
return {};
STRRET str{};
if (SUCCEEDED(pShellFolder->GetDisplayNameOf(reinterpret_cast<PCUITEMID_CHILD>(pidl), SHGDN_NORMAL, &str)))
{
wchar_t szDisplayName[MAX_PATH];
switch (str.uType)
{
case STRRET_WSTR:
wcscpy_s(szDisplayName, MAX_PATH, str.pOleStr);
CoTaskMemFree(str.pOleStr);
break;
case STRRET_OFFSET:
wcscpy_s(szDisplayName, MAX_PATH, reinterpret_cast<wchar_t *>(reinterpret_cast<BYTE*>(pidl) + str.uOffset));
break;
case STRRET_CSTR:
MultiByteToWideChar(CP_ACP, 0, str.cStr, -1, szDisplayName, MAX_PATH);
break;
default:
break;
}
return std::wstring(szDisplayName);
}
return {};
}
and the code that search in RecycleBin the item:
bool CMyClass::FindFileInRecycleBin(const LPITEMIDLIST& pidl)
{
IShellFolder *pDesktopFolder = nullptr;
HRESULT hr = SHGetDesktopFolder(&pDesktopFolder);
if (FAILED(hr))
{
return false;
}
PIDLIST_ABSOLUTE pidlRecycleBin = nullptr;
hr = SHGetSpecialFolderLocation(nullptr, CSIDL_BITBUCKET, &pidlRecycleBin);
if (FAILED(hr))
{
pDesktopFolder->Release();
return false;
}
IShellFolder *pRecycleBinFolder = nullptr;
hr = pDesktopFolder->BindToObject(pidlRecycleBin, nullptr, IID_IShellFolder,
reinterpret_cast<void **>(&pRecycleBinFolder));
if (FAILED(hr))
{
CoTaskMemFree(pidlRecycleBin);
pDesktopFolder->Release();
return false;
}
IEnumIDList *pEnumIDList = nullptr;
hr = pRecycleBinFolder->EnumObjects(nullptr, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIDList);
if (FAILED(hr))
{
pRecycleBinFolder->Release();
CoTaskMemFree(pidlRecycleBin);
pDesktopFolder->Release();
return false;
}
std::wstring displayNameFile{};
PITEMID_CHILD pidlItem{ nullptr };
while (S_OK == pEnumIDList->Next(1, &pidlItem, nullptr))
{
const std::wstring displayName = GetDisplayName(pRecycleBinFolder, pidlItem);
if (displayNameFile.empty())
displayNameFile = GetDisplayName(pRecycleBinFolder, pidl);
if (displayName == displayNameFile)
{
CoTaskMemFree(pidlItem);
pEnumIDList->Release();
pRecycleBinFolder->Release();
CoTaskMemFree(pidlRecycleBin);
pDesktopFolder->Release();
return true;
}
CoTaskMemFree(pidlItem);
}
pEnumIDList->Release();
pRecycleBinFolder->Release();
CoTaskMemFree(pidlRecycleBin);
pDesktopFolder->Release();
return false;
}
And I am trying to get mkid, like this:
deletedItem->mkid; // see definiton at the beginning
CMyClass mc;
ITEMIDLIST item{ deletedItem->mkid };
mc.FindFileInRecycleBin(item);
The issue is I got an exception, at line:
if (SUCCEEDED(pShellFolder->GetDisplayNameOf(reinterpret_cast<PCUITEMID_CHILD>(pidl), SHGDN_NORMAL, &str)))
inside CMyClass::GetDisplayName method. Where? At second call here:
const std::wstring displayName = GetDisplayName(pRecycleBinFolder, pidlItem); // <--- works fine
if (displayNameFile.empty())
displayNameFile = GetDisplayName(pRecycleBinFolder, pidl); // <---- here raise exception
2 questions:
Regards,
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(246.4, 86%, 33%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EDL%3C/text%3E%3C/svg%3E)
What is the "exception" that you get when calling GetDisplayNameOf in your second use of it?
and
0xC0000005: Access violation reading location 0x00000007EB507BBC.
You have a cast on that line of code: reinterpret_cast<PCUITEMID_CHILD>
Try removing it and change your code to compile cleanly - maybe what you're passing isn't what the method expects and so that's why you're getting the read access exception.
ITEMIDLIST item{ deletedItem->mkid };
In my test this statement constructed a garbage pidl.
And attempting to find an item in the recycle bin by comparing display names has the inherent flaw that the bin can contain more than one item that has the same display name.
For example -
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(201.6, 57.00000000000001%, 29%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EMY%3C/text%3E%3C/svg%3E)
Is there any update? Does the answer solve your problem?
As I demonstrated above the recycle bin can contain more than one item with the same display name.
A better method is to use IShellFolder::CompareIds. I saved the absolute pidls of the recycle bin items enumerated in my previous posts to files. Then I enumerated the items in the recycle bin and did the comparison using the IShellFolder interface retrieved for the Recycle bin as well as for the Desktop.
Example code -
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
CComPtr<IShellFolder> pDesktop, psf;
CHeapPtr<BYTE> pBuffer;
// Read the binary file that contains the pidl for item in recycle bin.
HANDLE hFile = CreateFileW(L"PIDL-$RERVIFA.bin", GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL);
if (hFile != INVALID_HANDLE_VALUE)
{
DWORD dwRead{};
auto cBytes = GetFileSize(hFile, nullptr);
pBuffer.Allocate(cBytes);
ReadFile(hFile, pBuffer, cBytes, &dwRead, NULL);
ATLASSERT(cBytes == dwRead);
CloseHandle(hFile);
}
auto hr = SHGetDesktopFolder(&pDesktop);
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (SUCCEEDED(hr))
{
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (SUCCEEDED(hr))
{
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (SUCCEEDED(hr))
{
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; pEnumIdlist->Next(1, &pidlChild, &cFetched) == S_OK; pidlChild.Free())
{
STRRET strnormal{}, strparsing{};
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_NORMAL, &strnormal);
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing);
if (SUCCEEDED(hr))
{
CComHeapPtr<WCHAR> pwszName, pwszParsing;
hr = StrRetToStrW(&strnormal, nullptr, &pwszName);
hr = StrRetToStrW(&strparsing, nullptr, &pwszParsing);
if (SUCCEEDED(hr))
{
wprintf_s(L"IShellFolder Enumeration name was %s\n", (LPWSTR)pwszName);
wprintf_s(L"Parsing name: %s\n", (LPWSTR)pwszParsing);
// Find last pidl the represents child item in the recycle bin
auto pidlSaved = ILFindLastID(reinterpret_cast<PCUIDLIST_RELATIVE>(static_cast<BYTE*>(pBuffer)));
// Compare using IShellFolder for recycle bin
hr = psf->CompareIDs(SHCIDS_CANONICALONLY, static_cast<PCUITEMID_CHILD>((ITEMID_CHILD*)pidlChild), pidlSaved);
bool IsMatch = static_cast<short>(HRESULT_CODE(hr)) == 0;
if(IsMatch)
wprintf(L"******************** Recycle bin IShellFolder Matched Item!!! *******************\n");
// Construct absolute pidl for enumerated item from recycle bin
auto pidlAbsolute = ILCombine(pidlBin, pidlChild);
// Compare using IShellFolder for desktop
hr = pDesktop->CompareIDs(SHCIDS_CANONICALONLY, pidlAbsolute, reinterpret_cast<PCUIDLIST_RELATIVE>(static_cast<BYTE*>(pBuffer)));
IsMatch = static_cast<short>(HRESULT_CODE(hr)) == 0;
if (IsMatch)
wprintf(L"******************** Desktop IShellFolder Matched Item!!! *******************\n");
CoTaskMemFree(pidlAbsolute);
}
}
}
}
}
}
Results of pidl matching -
Excellent code, I'll try it and I'll let you know! Thank you a lot!
RLWA32, thank you a lot. I still need some explanation in order to use your code.
PIDL-$RERVIFA.bin name?HANDLE hFile = CreateFileW ... is needed to get CHeapPtr<BYTE> pBuffer;, right?PCIDLIST_ABSOLUTE item? My assumption is that I need to convert PCIDLIST_ABSOLUTE to file name (.bin file name), to use it for CreateFileW call, right?Actually, the original code give me a vector of PCIDLIST_ABSOLUTE items, something like this:
typedef std::vector<PCIDLIST_ABSOLUTE> DeletedItems_t;
My intend is to contribute to an open source project (from github).
Task: I need to get deleted item having
SHITEMIDdata.
Initially, that was what you asked about. If you remember, I wrote in an earlier post that I didn't understand how you could be starting with a pidl for an item in the recycle bin. So to simulate searching for a recycle bin item based on its pidl I wrote out a recycle bin item's pidl to a file.
Trying to adapt your code to my needs, I tried:
int main()
{
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
auto hr = SHGetDesktopFolder(&pDesktop);
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (SUCCEEDED(hr))
{
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (SUCCEEDED(hr))
{
if (SUCCEEDED(hr))
{
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (SUCCEEDED(hr))
{
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
STRRET strnormal{}, strparsing{};
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_NORMAL, &strnormal);
std::clog << "GetDisplayNameOf SHGDN_NORMAL: " << hr << std::endl;
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing);
std::clog << "GetDisplayNameOf SHGDN_FORPARSING: " << hr << std::endl;
// if (SUCCEEDED(hr))
{
CComHeapPtr<WCHAR> pwszName, pwszParsing;
hr = StrRetToStrW(&strnormal, nullptr, &pwszName);
hr = StrRetToStrW(&strparsing, nullptr, &pwszParsing);
// if (SUCCEEDED(hr))
{
wprintf_s(L"IShellFolder Enumeration name was %s\n", static_cast<LPWSTR>(pwszName));
wprintf_s(L"Parsing name: %s\n", static_cast<LPWSTR>(pwszParsing));
}
}
}
}
}
}
}
return 0;
and the outcome was:
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\Folder1
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\20231212.zip
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\20211212.zip
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\20221008.zip
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Transfer\chart.html
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\KM-Goanna
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\make-3.81-bin
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\Temp20230428.zip
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Transfer\chart.html
Parsing name: (null)
GetDisplayNameOf SHGDN_NORMAL: 0
GetDisplayNameOf SHGDN_FORPARSING: -2147221008
IShellFolder Enumeration name was C:\Home\Flaviu\20230428.zip
Parsing name: (null)
Why hr = psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing); doesn't work correct? Can you check it on your side, please?
The com error code of -2147221008 is 0x800401F0 and means "CoInitialize has not been called." And looking at the above posted code that is accurate. Initialize COM in the STA before calling any shell functions or using shell interfaces.
Let me know how it goes after you do this.
Sorry my late response, I've changed my laptop and took time to setup my environments.
So, I tested this code:
if (SUCCEEDED(CoInitialize(nullptr)))
{
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
auto hr = SHGetDesktopFolder(&pDesktop);
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (SUCCEEDED(hr))
{
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (SUCCEEDED(hr))
{
if (SUCCEEDED(hr))
{
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (SUCCEEDED(hr))
{
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
STRRET strnormal{}, strparsing{};
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_NORMAL, &strnormal);
std::clog << "GetDisplayNameOf SHGDN_NORMAL: " << hr << std::endl;
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing);
std::clog << "GetDisplayNameOf SHGDN_FORPARSING: " << hr << std::endl;
// if (SUCCEEDED(hr))
{
CComHeapPtr<WCHAR> pwszName, pwszParsing;
hr = StrRetToStrW(&strnormal, nullptr, &pwszName);
hr = StrRetToStrW(&strparsing, nullptr, &pwszParsing);
// if (SUCCEEDED(hr))
{
wprintf_s(L"IShellFolder Enumeration name was %s\n", static_cast<LPWSTR>(pwszName));
wprintf_s(L"Parsing name: %s\n", static_cast<LPWSTR>(pwszParsing));
}
}
}
}
}
}
}
CoUninitialize();
}
And lisetd me out something like:
IShellFolder Enumeration name was C:\Users\Public\Desktop\Google Chrome
Parsing name: C:\$Recycle.Bin\S-1-12-1-2844582889-1121447445-1445683180-565617264\$RZ0QBRM.lnk
So, works fine. I'll go to next step. Come to you with feedback.
Its not clear to me how you start with a pidl for an item in the recycle bin.
Anyway, this code will enumerate the contents of the recycle bin -
#include <stdio.h>
#include <tchar.h>
#define _ATL_CSTRING_EXPLICIT_CONSTRUCTORS // some CString constructors will be explicit
#include <atlbase.h>
#include <atlstr.h>
// TODO: reference additional headers your program requires here
#include <ShlObj.h>
#include <ShlGuid.h>
#include <propkey.h>
#include <propsys.h>
#pragma comment(lib,"propsys.lib")
int main()
{
auto hr = CoInitialize(nullptr);
if (SUCCEEDED(hr))
{
CComPtr<IShellItem> pbin;
CComPtr<IEnumShellItems> psiEnum;
PROPERTYKEY PKey_DisplacedFrom = { FMTID_Displaced, PID_DISPLACED_FROM };
PROPERTYKEY PKey_DisplacedDate = { FMTID_Displaced, PID_DISPLACED_DATE };
hr = SHGetKnownFolderItem(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, IID_PPV_ARGS(&pbin));
if (SUCCEEDED(hr))
{
hr = pbin->BindToHandler(NULL, BHID_EnumItems, IID_PPV_ARGS(&psiEnum));
if (SUCCEEDED(hr))
{
for (CComPtr<IShellItem> psi; psiEnum->Next(1, &psi, NULL) == S_OK; psi.Release())
{
CComHeapPtr<WCHAR> pszName;
CComQIPtr<IShellItem2> psi2 = psi;
CComHeapPtr<WCHAR> pszItemName, pszItemNameDisplay, pszDateDeleted, pszDeletedFrom;
CComPtr<IContextMenu> pcm;
hr = psi2->GetDisplayName(SIGDN_NORMALDISPLAY, &pszName);
hr = psi2->GetString(PKEY_ItemName, &pszItemName);
hr = psi2->GetString(PKEY_ItemNameDisplay, &pszItemNameDisplay);
hr = psi2->GetString(PKey_DisplacedDate, &pszDateDeleted);
hr = psi2->GetString(PKey_DisplacedFrom, &pszDeletedFrom);
wprintf_s(L"Display Name is %s\n", (LPWSTR)pszName);
wprintf_s(L"\tItemName is %s\n\tItemNameDisplay is %s\n\tDate Deleted is %s\n\tOriginal Location is %s\n\n", (LPWSTR)pszItemName, (LPWSTR)pszItemNameDisplay, (LPWSTR)pszDateDeleted, (LPWSTR)pszDeletedFrom);
}
}
}
}
CoUninitialize();
return 0;
}
And once you have an IShellItem (or IShellItem2) interface pointer you can obtain a pidl with SHGetIDListFromObject function
Your example does work, thank you, but I still don't know how to use your code starting from my data: SHITEMID mkid;
Try the following to get a pidl from SHITEMID
auto pidlClone = ILCloneFull(reinterpret_cast<PCUIDLIST_ABSOLUTE>(&deleteditem->mkid));
Don't forget to call CoTaskMemFree on the clone when you're done using it. You could also work directly with deleteditem->mkid with the proper casting as demonstratd in the above example.
Hi. I am pretty close of a successful code, but not quite.
So, in the original code (open source code), I have the following data that point out items from RecycleBin:
std::vector<PCIDLIST_ABSOLUTE> DeletedItems;
From the vector items I need to find the recycled item. And I have tried/adapted this code:
bool CSomeClass::FindDeletedItem(const PCIDLIST_ABSOLUTE& pidl)
{
if (!SUCCEEDED(CoInitialize(nullptr)))
return false;
bool found{ false };
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
do
{
auto hr = SHGetDesktopFolder(&pDesktop);
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (!SUCCEEDED(hr))
break;
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (!SUCCEEDED(hr))
break;
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (!SUCCEEDED(hr))
break;
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
const auto pidlAbsolute = ILCombine(pidlBin, pidlChild);
// Compare using IShellFolder for desktop
hr = pDesktop->CompareIDs(SHCIDS_CANONICALONLY, pidlAbsolute, pidl);
if (0 == static_cast<short>(HRESULT_CODE(hr)))
found = true;
CoTaskMemFree(pidlAbsolute);
if (found)
break;
}
} while (false);
CoUninitialize();
return found;
}
And I have tried the code like this:
for (const auto& item : deletedItemList)
{
const auto s = std::format("+++++++++++++++++{}\n", FileOperations::FindDeletedItem(item));
OutputDebugStringA(s.c_str());
}
Even if I know the deleted item is inside RecycleBin, seems my code doesn't find the deleted item, output is:
+++++++++++++++++false
What I did wrong in my FindDeletedItem code? The problem is that I cannot try my FindDeletedItem code in a simple test application to realize what I did wrong, can you help here?
The problem is that I cannot try my
FindDeletedItemcode in a simple test application
Why not?
I can't tell what your code is actually working with. Are you sure that the items in the vector are actually in the recycle bin? Did you print the parsing names for them? Did you step through the code to make sure that it actually reaches the call to IShellFolder::CompareIDs?
Did you try doing the comparison using the IShellFolder interface for the recycle bin? See my earlier example that used ILFindLastID().
Finally, the destructors for the CComPtr objects that release the IShellFolder interface pointers for the desktop and the recycle bin will be called AFTER COM has been uninitialized. Not good.
Sorry for this very late response. I didn't have access to this forum for a while, and then I went into vacation, fortunately, after I came back, my access to this forum was fixed.
So, I wrote two methods, one to list all recyclebin items, and another one to find the deleted item:
void CMyClass::ListRecycleItems()
{
if (!SUCCEEDED(CoInitialize(nullptr)))
return;
{
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
do
{
auto hr = SHGetDesktopFolder(&pDesktop);
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (!SUCCEEDED(hr))
break;
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (!SUCCEEDED(hr))
break;
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (!SUCCEEDED(hr))
break;
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
STRRET strnormal{}, strparsing{};
if (SUCCEEDED(psf->GetDisplayNameOf(pidlChild, SHGDN_NORMAL, &strnormal)) &&
SUCCEEDED(psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing)))
{
CComHeapPtr<WCHAR> pwszName, pwszParsing;
if (SUCCEEDED(StrRetToStrW(&strnormal, nullptr, &pwszName)) &&
SUCCEEDED(StrRetToStrW(&strparsing, nullptr, &pwszParsing)))
{
std::wstring named{ pwszName };
OutputDebugString(named.c_str());
OutputDebugString(L"\n");
std::wstring parsed{ pwszParsing };
OutputDebugString(parsed.c_str());
OutputDebugString(L"\n");
}
}
}
} while (false);
}
CoUninitialize();
}
and
bool CMyClass::FindDeletedItem(const PCIDLIST_ABSOLUTE& pidl)
{
if (!SUCCEEDED(CoInitialize(nullptr)))
return false;
bool found{ false };
{
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
do
{
auto hr = SHGetDesktopFolder(&pDesktop);
if (!SUCCEEDED(hr))
break;
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (!SUCCEEDED(hr))
break;
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (!SUCCEEDED(hr))
break;
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (!SUCCEEDED(hr))
break;
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
const auto pidlAbsolute = ILCombine(pidlBin, pidlChild);
// Compare using IShellFolder for desktop
hr = pDesktop->CompareIDs(SHCIDS_CANONICALONLY, pidlAbsolute, pidl);
if (0 == static_cast<short>(HRESULT_CODE(hr)))
found = true;
CoTaskMemFree(pidlAbsolute);
if (found)
break;
}
} while (false);
}
CoUninitialize();
return found;
}
The outcome of listing items:
C:\Transfer\new 1.txt
C:\$Recycle.Bin\S-1-12-1-2806582889-1121637445-1445600180-565617264\$RADSFVC.txt
C:\Transfer\new 14.txt
C:\$Recycle.Bin\S-1-12-1-2806582889-1121637445-1445600180-565617264\$RHAYONV.txt
However, even if I am sure the deleted item is new 1.txt, the outcome of FindDeletedItem is false.
for (const auto& item : deletedItemList)
{
const auto s = std::format("+++++++++++++++++{}\n", FileOperations::FindDeletedItem(item));
OutputDebugStringA(s.c_str());
}
How can I list pidlAbsolute value as text? Is it possible?
I asked these earlier:
I can't tell what your code is actually working with. Are you sure that the items in the vector are actually in the recycle bin? Did you print the parsing names for them? Did you step through the code to make sure that it actually reaches the call to IShellFolder::CompareIDs?
Did you try doing the comparison using the IShellFolder interface for the recycle bin? See my earlier example that used ILFindLastID().
You can print the ITEMIDLIST pointed to by a pidl by treating the data as an array of BYTES and printing the hex value of each byte. ILGetSize() will let you know how many bytes to print.
"Are you sure that the items in the vector are actually in the recycle bin?"
I assume that, how I can be sure?
"Did you print the parsing names for them?"
Yes, see below:
bool FileOperations::FindDeletedItem(const PCIDLIST_ABSOLUTE& pidl)
{
if (!SUCCEEDED(CoInitialize(nullptr)))
return false;
bool found{ false };
{
CComPtr<IShellFolder> pDesktop, psf;
CComHeapPtr<ITEMIDLIST_ABSOLUTE> pidlBin;
do
{
auto hr = SHGetDesktopFolder(&pDesktop);
if (!SUCCEEDED(hr))
break;
hr = SHGetKnownFolderIDList(FOLDERID_RecycleBinFolder, KF_FLAG_DEFAULT, NULL, &pidlBin);
if (!SUCCEEDED(hr))
break;
hr = pDesktop->BindToObject(pidlBin, nullptr, IID_PPV_ARGS(&psf));
if (!SUCCEEDED(hr))
break;
CComPtr<IEnumIDList> pEnumIdlist;
hr = psf->EnumObjects(NULL, SHCONTF_FOLDERS | SHCONTF_NONFOLDERS, &pEnumIdlist);
if (!SUCCEEDED(hr))
break;
ULONG cFetched{};
for (CComHeapPtr<ITEMID_CHILD> pidlChild; S_OK == pEnumIdlist->Next(1, &pidlChild, &cFetched); pidlChild.Free())
{
STRRET strnormal{}, strparsing{};
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_NORMAL, &strnormal);
hr = psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strparsing);
CComHeapPtr<WCHAR> pwszName, pwszParsing;
hr = StrRetToStrW(&strnormal, nullptr, &pwszName);
hr = StrRetToStrW(&strparsing, nullptr, &pwszParsing);
std::wstring named{ pwszName };
OutputDebugString(named.c_str());
OutputDebugString(L"\n");
std::wstring parsed{ pwszParsing };
OutputDebugString(parsed.c_str());
OutputDebugString(L"\n");
const auto pidlAbsolute = ILCombine(pidlBin, pidlChild);
// Compare using IShellFolder for desktop
hr = pDesktop->CompareIDs(SHCIDS_CANONICALONLY, pidlAbsolute, pidl);
if (0 == static_cast<short>(HRESULT_CODE(hr)))
found = true;
CoTaskMemFree(pidlAbsolute);
if (found)
break;
}
} while (false);
}
CoUninitialize();
return found;
}
The output:
C:\Transfer\new 30.txt
C:\$Recycle.Bin\S-1-12-1-2446582889-1121637445-1445600180-565617264\$R80ZBJL.txt
C:\Transfer\new 1.txt
C:\$Recycle.Bin\S-1-12-1-2806682889-1121637445-1445600180-565617264\$RADSFVC.txt
The absolute item is new 30txt
"Did you step through the code to make sure that it actually reaches the call to IShellFolder::CompareIDs?"
Yes, I checked that, it went through there.
"Did you try doing the comparison using the IShellFolder interface for the recycle bin? See my earlier example that used ILFindLastID()."
Not yet, I'll try to do that.
The posted code does not appear to obtain the parsing name of the PCIDLIST_ABSOLUTE& pidl that was passed into the function. That's what I'd like to see.