People have different opinions about how to backup. You should carefully research this topic on the internet, because it is very important, and make the choices that are best for you.
Regarding backing up to OneDrive: There are definite advantages and disadvantages to backing up this way. Here's an example of an advantage: The OneDrive app can do it for you. And here's an example of a disadvantage: If you lose access to your OneDrive (e.g., hacked Microsoft account, forgotten password) then you've also lost access to your backup.
Everyone should backup at least their personal files. By that I mean Downloads, Documents, Music, Pictures and Videos. How you do this is up to you. Any kind of backup is better than no backup. But here's the most important thing to know: Backups must be stored somewhere physically outside the computer.
After their personal files, the next thing that everyone should backup is their software, and here I am referring to Windows and application software. This kind of backup is called an image. In an image backup, the backup application makes an exact copy of your C drive and compresses that into a single, very large file. This too needs to be stored somewhere physically outside the computer. When you restore an image backup, your computer goes back in time to exactly how it was at the moment the image was made.
The details of how to backup can get pretty intricate; they are beyond the scope of a user community. Nevertheless, there are some elements on which just about everyone agrees:
1- Backups should be stored outside the physical computer.
2- The more often you backup, the better.
3- Backups should be tested every now and then by restoring a backup, to ensure that your backups will be available when you need them.