PowerShell function return parameter tmp_nqd1ogsr.jbe

Question

PowerShell function return parameter tmp_nqd1ogsr.jbe

Mali Stane 91

Hi,
I have simple function that return two parameters.
Sometimes it return third parameter tmp_******.jbe
Basically I call a function :
function Updateuser {
Param
(
[Parameter(Mandatory = $true)] $SamAccountName
[Parameter(Mandatory = $true)] $Name,
**
[Parameter(Mandatory = $false)] $pathlog
)

Function logic ….

return $data1, $data2, $data3
}
$Myupdate = Updateuser $Par1 $par2 $Par4
$Myupdate[0]
$Myupdate[1]
$Myupdate[2]

Sometimes return from $Myupdate[0] is tmp_******.jbe and somtims is correct value for $data1
I don’t know what I’m doing wrong ?

Rich Matheisen 48,116 Reputation points

2022-09-23T15:27:26.92+00:00

There's insufficient information in your question to provide an answer.

If the variable "$data1" contains an incorrect value then the problem lies in the "Function logic..." part of the code that you've omitted.

I see that you invoke the function "Updateuser" with three parameters. Is the last one ("Par4") named correctly? There are only three parameters declared in the function. Is the "4" a typo or are there really four parameters in the function? I see there's an empty line between the 2nd and 3rd parameters, and that's why I'm asking about it.

Answer accepted by question author

Michael Taylor 61,226

Powershell tries to figure out typing based upon the values which is, IMHO, very fragile. For example if you have a function that builds up an array of values and your array has multiple values then it works fine. But if you have a single value then it is treated as an object and array syntax fails. Similar problems occur if you have arrays within arrays.

Just guessing what your function is doing and why it would return unexpected results. I would recommend you be explicit about returning an array to avoid problems like this and see if your problem goes away.

   return @($data1, $data2, $data3)

Rich Matheisen 48,116

That's a difference without a distinction. All that does is add some syntactical sugar to the code.

Both of the functions below return the thing:

function Updateuser1 {  
    @(1,2,3)  
}  
(Updateuser1).gettype()  
  
  
function Updateuser2 {  
    1,2,3  
}  
(Updateuser2).gettype()

They both return an array:

IsPublic IsSerial Name                                     BaseType  
-------- -------- ----                                     --------  
True     True     Object[]                                 System.Array  
True     True     Object[]                                 System.Array

Michael Taylor 61,226 Reputation points

2022-09-23T15:14:02.003+00:00

It depends on what the $data1, $data2 values actually are. For simple literals the syntax is identical but if $data1 is itself an array or some other types perhaps then how they are combined can change in my experience. We've run into this problem a lot when working with REST APIs. Using an explicit syntax (or using +=) solves the problem in most cases. But without seeing more of the OP's code we're just guessing at this point.
Rich Matheisen 48,116 Reputation points

2022-09-23T15:18:37.307+00:00
Strongly casting a variable is a way to avoid any ambiguity.

The problem at you describe could be avoided by explicitly stating the returned value is always intended to be treated as an array, even if the only value returned is a scalar:

[array]$Myupdate = Updateuser $Par1 $par2 $Par4

But I don't think that's the problem here.

1 additional answer

Your answer

Rich Matheisen 48,116 Reputation points

2022-09-23T15:27:26.92+00:00

There's insufficient information in your question to provide an answer.

If the variable "$data1" contains an incorrect value then the problem lies in the "Function logic..." part of the code that you've omitted.

I see that you invoke the function "Updateuser" with three parameters. Is the last one ("Par4") named correctly? There are only three parameters declared in the function. Is the "4" a typo or are there really four parameters in the function? I see there's an empty line between the 2nd and 3rd parameters, and that's why I'm asking about it.
Rich Matheisen 48,116 Reputation points

2022-09-23T15:08:06.74+00:00

That's a difference without a distinction. All that does is add some syntactical sugar to the code.

Both of the functions below return the thing:

function Updateuser1 { @(1,2,3) } (Updateuser1).gettype() function Updateuser2 { 1,2,3 } (Updateuser2).gettype()

They both return an array:

IsPublic IsSerial Name BaseType -------- -------- ---- -------- True True Object[] System.Array True True Object[] System.Array
Michael Taylor 61,226 Reputation points

2022-09-23T15:14:02.003+00:00

It depends on what the $data1, $data2 values actually are. For simple literals the syntax is identical but if $data1 is itself an array or some other types perhaps then how they are combined can change in my experience. We've run into this problem a lot when working with REST APIs. Using an explicit syntax (or using +=) solves the problem in most cases. But without seeing more of the OP's code we're just guessing at this point.
Rich Matheisen 48,116 Reputation points

2022-09-23T15:18:37.307+00:00

Strongly casting a variable is a way to avoid any ambiguity.

The problem at you describe could be avoided by explicitly stating the returned value is always intended to be treated as an array, even if the only value returned is a scalar:

[array]$Myupdate = Updateuser $Par1 $par2 $Par4

But I don't think that's the problem here.

Answer 1

Thank you for your suggestions !
I will set “return” as array.
Issue, when I observe this undesired behaviour, usually happens when I run script more than once.
Script is much bigger and involve creating a new user from template or group, enable o365 mailbox etc…. and contains a lot of GUI elements. This specific problematic function is called when user support edit existing user (user got marid etc…) so type of rename operation, and then return new Distinguish name of effected user and proceed with next step (function) mail attribute modification… Issue is ,an I believe it will be solved with array, to return new distinguish name to proceed with next step of the process calling function that manipulate proxy address…
That is just sample of code its not…

function UpdateUserGroupMin {

Param  
(  
    [Parameter(Mandatory = $true)] $SamAccountName_MIN,  
    [Parameter(Mandatory = $true)] $Name_MIN,  
    [Parameter(Mandatory = $true)] $GivenName_MIN,  
    [Parameter(Mandatory = $true)] $Surname_MIN,  
    [Parameter(Mandatory = $true)] $OtherName_MIN,  
    [Parameter(Mandatory = $true)] $DisplayName_MIN,  
    [Parameter(Mandatory = $true)] $Description_MIN,  
    [Parameter(Mandatory = $true)] $Company_MIN,  
    [Parameter(Mandatory = $true)] $UPN_MIN,  
    [Parameter(Mandatory = $true)] $Mail_MIN,  
    [Parameter(Mandatory = $true)] $DN_MIN,  
    [Parameter(Mandatory = $true)] $object_MIN,  
    [Parameter(Mandatory = $false)] $Errorlogpath  
)

*
*

if ($object_MIN -eq "User")  
    {  
        If (!(([string]::IsNullOrEmpty($GivenName_MIN))))  
        {  
            Set-ADUser -Identity $DN_MIN -GivenName $GivenName_MIN  
        }  
*  
*  
*

}
elseif ($object_MIN -eq "Group")
{
If (!(([string]::IsNullOrEmpty($DisplayName_MIN))))
{
Set-ADGroup -Identity $DN_MIN -DisplayName $DisplayName_MIN
}
*
*
*
}
Return ….

Michael Taylor 61,226 Reputation points

2022-09-26T16:14:22.187+00:00

Unfortunately none of the code you posted lines up with what your original problem statement was. You said you had a return $data1, $data2, $data3 in the function and sometimes $data1 is wrong. None of the code you posted shows us how $data1 is being set (nor the other values). If the problem is one of the elements in the array then the value in function is also wrong so you should be tracing through the code to figure out why. Look at every place it is used and ensure that all code paths set a value for it.

Share via

PowerShell function return parameter tmp_nqd1ogsr.jbe

1 additional answer

Your answer