why my code can't read the file

Question

why my code can't read the file

Linh nguyen 41

help me plsss

![255349-image.png ]4

Barry Schwarz 3,746 Reputation points

2022-10-30T17:42:30.78+00:00

What results do you get that lead you to believe you are not reading the file?

On my system, Notepad shows the full file name, including the suffix ".txt". Are you sure the file name matches the string literal in your call to docMaTran? Your screen shot seems to imply it does not.

Have you tried stepping through the code with the debugger to verify that each statement produces the result you expect?

It would be easier for people to test your code if you pasted it into the message instead of providing screen shots.
Linh nguyen 41 Reputation points

2022-10-31T07:08:30.897+00:00
my all code :

Healer.h :

define _CRT_SECURE_NO_WARNINGS

include <iostream>

include <vector>

using namespace std;
const int MAX = 50;
struct MaTran {
int list[MAX][MAX];
int m;
int n;
};

int docMaTran(MaTran &a,const char *filename);
void inMaTran(MaTran a);
int tinhTongle(MaTran a);

Main.cpp:

include <iostream>

include "Header.h"

include <vector>

using namespace std;

int main()
{
MaTran a;
if (docMaTran(a, "mang3_4.txt") == 1)
{
inMaTran(a); cout << "\nTong Le:" << tinhTongle(a);

} else { cout << "khong doc duoc file "; system("pause"); return 0; }

}

Source.cpp:

include "Header.h"

int docMaTran(MaTran &a, const char filename) {
FILE fp;
fp = fopen(filename, "r");
if (fp != NULL)
{
fscanf(fp, "%d", &a.n);
fscanf(fp, "%d", &a.m);
for (int i = 0; i < a.n; i++)
for (int j = 0; i < a.m; j++)
fscanf(fp, "%d", &a.list[i][j]);
fclose(fp);
return 1;
}
return 0;

}
void inMaTran(MaTran a) {
for (int i = 0; i < a.n; i++)
{
cout << "\n";
for (int j = 0; j < a.m; j++)
{
cout << a.list[i][j] << "\t";
}
}
}
int tinhTongle(MaTran a) {
int tong = 0;
for (int i = 0; i < a.n; i++)
{
for (int j = 0; j < a.m; j++)
{
if (a.list[i][j] % 2 != 0)
{
tong += a.list[i][j];
}
}
}return tong;
}

Accepted answer

1 additional answer

Your answer

Barry Schwarz 3,746 Reputation points

2022-10-30T17:42:30.78+00:00

What results do you get that lead you to believe you are not reading the file?

On my system, Notepad shows the full file name, including the suffix ".txt". Are you sure the file name matches the string literal in your call to docMaTran? Your screen shot seems to imply it does not.

Have you tried stepping through the code with the debugger to verify that each statement produces the result you expect?

It would be easier for people to test your code if you pasted it into the message instead of providing screen shots.
Linh nguyen 41 Reputation points

2022-10-31T07:08:30.897+00:00

my all code :

Healer.h :

define _CRT_SECURE_NO_WARNINGS

include <iostream>

include <vector>

using namespace std;
const int MAX = 50;
struct MaTran {
int list[MAX][MAX];
int m;
int n;
};

int docMaTran(MaTran &a,const char *filename);
void inMaTran(MaTran a);
int tinhTongle(MaTran a);

Main.cpp:

include <iostream>

include "Header.h"

include <vector>

using namespace std;

int main()
{
MaTran a;
if (docMaTran(a, "mang3_4.txt") == 1)
{
inMaTran(a); cout << "\nTong Le:" << tinhTongle(a);

} else { cout << "khong doc duoc file "; system("pause"); return 0; }

}

Source.cpp:

include "Header.h"

int docMaTran(MaTran &a, const char filename) {
FILE fp;
fp = fopen(filename, "r");
if (fp != NULL)
{
fscanf(fp, "%d", &a.n);
fscanf(fp, "%d", &a.m);
for (int i = 0; i < a.n; i++)
for (int j = 0; i < a.m; j++)
fscanf(fp, "%d", &a.list[i][j]);
fclose(fp);
return 1;
}
return 0;

}
void inMaTran(MaTran a) {
for (int i = 0; i < a.n; i++)
{
cout << "\n";
for (int j = 0; j < a.m; j++)
{
cout << a.list[i][j] << "\t";
}
}
}
int tinhTongle(MaTran a) {
int tong = 0;
for (int i = 0; i < a.n; i++)
{
for (int j = 0; j < a.m; j++)
{
if (a.list[i][j] % 2 != 0)
{
tong += a.list[i][j];
}
}
}return tong;
}

Answer 1

WayneAKing 4,931

I second Barry's suggestions.

(1) Tell us exactly what is happening with your program.
Error messages? Wrong output? No output?

Is the file opening OK but failing during the reading?

Or does the open fail? Note that since you have not
specified a full absolute path for the file, then it
must be in the correct folder (usually the current path)
for it to be found by the IDE during debugging.

For VS this is usually the same folder as where the .cpp
and .vcproj files are located.

Also note this from the docs for fscanf_s:

"fscanf_s doesn't currently support input from a UNICODE stream."

(2) Post the actual code from your program, using
Windows copy & paste, and put it in a "Code Block"
in the forum message editor.

One small observation - your code has:

cout << a.list[i][j] << "/t";

I suspect you wanted a tab character which is "\t"
or '\t'.

Wayne

Linh nguyen 41 Reputation points

2022-10-31T07:11:06.627+00:00

my all code :

Healer.h :

define _CRT_SECURE_NO_WARNINGS
include <iostream>
include <vector>
using namespace std;
const int MAX = 50;
struct MaTran {
int list[MAX][MAX];
int m;
int n;
};

int docMaTran(MaTran &a,const char *filename);
void inMaTran(MaTran a);
int tinhTongle(MaTran a);

Main.cpp:

include <iostream>
include "Header.h"
include <vector>
using namespace std;

int main()
{
MaTran a;
if (docMaTran(a, "mang3_4.txt") == 1)
{
inMaTran(a); cout << "\nTong Le:" << tinhTongle(a);

}
else
{
cout << "khong doc duoc file "; system("pause");
return 0;
}
}

Source.cpp:

include "Header.h"
int docMaTran(MaTran &a, const char filename) {
FILE fp;
fp = fopen(filename, "r");
if (fp != NULL)
{
fscanf(fp, "%d", &a.n);
fscanf(fp, "%d", &a.m);
for (int i = 0; i < a.n; i++)
for (int j = 0; i < a.m; j++)
fscanf(fp, "%d", &a.list[i][j]);
fclose(fp);
return 1;
}
return 0;

}
void inMaTran(MaTran a) {
for (int i = 0; i < a.n; i++)
{
cout << "\n";
for (int j = 0; j < a.m; j++)
{
cout << a.list[i][j] << "\t";
}
}
}
int tinhTongle(MaTran a) {
int tong = 0;
for (int i = 0; i < a.n; i++)
{
for (int j = 0; j < a.m; j++)
{
if (a.list[i][j] % 2 != 0)
{
tong += a.list[i][j];
}
}
}return tong;
}
Linh nguyen 41 Reputation points

2022-10-31T07:15:19.323+00:00

i try fscanf fist but it not work so i use fscanf_s but it not work too and it not have any error
Barry Schwarz 3,746 Reputation points

2022-10-31T07:33:34.58+00:00

If you really want help you need to provide some detail.

Your most recent screen shot shows absolutely nothing and is therefore completely useless. When did you take it?

What do you mean by "not work"? How do you know fscanf_s did not report an error?

Have you tried to use the debugger? Can you step through the code? Can you put breakpoints after the call to fopen? Can you modify the code to print an error message if fopen fails? Can you modify the code to print the values of a.n and a.m after you read them?

Answer 2

WayneAKing 4,931

This line is wrong:

for (int j = 0; i < a.m; j++)

It should be:

for (int j = 0; j < a.m; j++)

Wayne

Linh nguyen 41 Reputation points

2022-10-31T12:10:20.537+00:00

thanks bro

Share via

why my code can't read the file

define _CRT_SECURE_NO_WARNINGS

include <iostream>

include <vector>

include <iostream>

include "Header.h"

include <vector>

include "Header.h"

1 additional answer

Your answer