Redirection outside controller from another method

Question

I have several ActionResults where I implemented below condition. I want to move this complete if condition to a separate method and call it where needed. Please advice

> public async Task<ActionResult> Status(int Id)  
> {  
>       if (Id <= 0)  
>       {  
>           TempData["Errors"] = "Invalid data";  
>   
>           return RedirectToAction("Error", "Dashboard");  
>       } ....  
>  }  

Answer 1

Hi @Zeeshan Dar ,

I want to move this complete if condition to a separate method and call it where needed.

As we all know, the RedirectToAction() method will return a RedirectToRouteResult, so, if you want to create a separate method, the return data could be a RedirectToRouteResult. Like this:

    public IActionResult Status (int Id)  
    {   
        return RedirectToActionHandle(Id);  
    }  

    public RedirectToActionResult RedirectToActionHandle(int id)  
    {  
        if (id <= 0)  
        {  
            TempData["Errors"] = "Invalid data";  
            return RedirectToAction("Index");  
        }  
        else    
        {  
            TempData["Errors"] = "Invalid data";  
            return RedirectToAction("Index2");  
        }   
    }  

Besides, in the if statement or custom method, you might return different action result, such as ViewResult, JsonResult and so on. So, in the custom method, the return data type, you can use IActionResult. like this:

    public IActionResult Status (int Id)  
    {   
        return CustomHandle(Id);  
    }  

    public IActionResult CustomHandle(int id)  
    {  
        if (id <= 0)  
        {  
            TempData["Errors"] = "Invalid data";  
            return RedirectToAction("Index");  
        }  
        else if(id== 2)  
        {  
            TempData["Errors"] = "Invalid data";  
            return RedirectToAction("Index2");  
        }  
        else  
        {  
            return View("Status");  
        }  
    }   

And there also has another method, you can create ActionModel which contains the ActionName, ControllerName and RouteData property, in the custom method and the if statement, you can create an ActionModel instance and set the ActionName, ControllerName and the RouteData. Then return this model to the Status method, and then based on the ActionModel to redirect to related action method.

---

If the answer is the right solution, please click "Accept Answer" and kindly upvote it. If you have extra questions about this answer, please click "Comment".
Note: Please follow the steps in our documentation to enable e-mail notifications if you want to receive the related email notification for this thread.

Best regards,
Dillion

Answer 2

this would make the most sense as an action filter. see:

https://learn.microsoft.com/en-us/aspnet/core/mvc/controllers/filters?view=aspnetcore-7.0