SetMargins Method does Nothing

Question

SetMargins Method does Nothing

Nathan Sokalski 4,111

I am attempting to programmatically set the margins of several View(s) using the SetMargins method using code similar to the following:

(this.btnNewPicture.LayoutParameters as LinearLayout.LayoutParams).SetMargins((int)(137.5 + 72), 0, 0, 0);

This does not seem to do anything. If I set the margins in xml it works fine. What is the problem?

Wenyan Zhang (Shanghai Wicresoft Co,.Ltd.) 36,436 Reputation points Microsoft External Staff

2022-12-05T09:55:07.177+00:00

This is a Xamarin.Android project, right? Would you mind sharing more about your Layout?
Nathan Sokalski 4,111 Reputation points

2022-12-06T03:16:15.197+00:00
The line of code containing the SetMargins statement is the following:

(sldVegetable.LayoutParameters as GridLayout.LayoutParams).SetMargins(0, 0, 0, 0);

sldVegetable is a Google.Android.Material.Slider.Slider. I noticed that after clicking 2 or 3 other View(s) (the Slider whose margins are being set or other View(s)), the newly set margins are applied. This leads me to believe that the app is not redrawing the Slider when I set the margins. I tried calling the Invalidate() method of the Slider, but it did not help. Something I will mention about this XML layout is that it is used by an include tag in activity_main.xml, and includes a large number of View(s). I understand that having a large number of View(s) can decrease performance, but I am not sure how else to get the desired layout (most of the large number of View(s) come from 6 GridLayout(s) each of which contains 18 identical ImageView(s), which do not change other than setting their initial values & sometimes changing their Visibility). What do I need to do to refresh the layout with the new margins? Is it possible that the large number of View(s) is causing this problem?
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-07T02:06:30.13+00:00
Calling SetMargin() directly in Android will not change the layout, you can try the following code to reset the LayoutParameters:

var slider = FindViewById(Resource.Id.mySlider); var ll = new LinearLayout.LayoutParams(slider.Width, slider.Height); var gl = new GridLayout.LayoutParams(ll); gl.SetMargins(30, 30, 30, 30); slider.LayoutParameters = gl;

Would it be helpful for you? Your prompt reply will be highly appreciated.
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-09T06:27:07.527+00:00

May I know whether your issue has been solved or not? If not, please share it in here. We can work together to figure it out.
Nathan Sokalski 4,111 Reputation points

2022-12-09T17:54:45.19+00:00

I'm not sure if it's the reason, or maybe it was reducing the number of View(s), but I tried adding a few extra SetMargins calls to make sure that the margins ALWAYS got changed (even if I immediately change them back on the very next line of code). Whether this was the reason or not, it seems to be working now. Thank you for your help.
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-12T01:52:09.19+00:00

Thanks for your feedback, could you please share your solution here?

It would be helpful for others who meet the same issue.

Your answer

Wenyan Zhang (Shanghai Wicresoft Co,.Ltd.) 36,436 Reputation points Microsoft External Staff

2022-12-05T09:55:07.177+00:00

This is a Xamarin.Android project, right? Would you mind sharing more about your Layout?
Nathan Sokalski 4,111 Reputation points

2022-12-06T03:16:15.197+00:00

The line of code containing the SetMargins statement is the following:

(sldVegetable.LayoutParameters as GridLayout.LayoutParams).SetMargins(0, 0, 0, 0);

sldVegetable is a Google.Android.Material.Slider.Slider. I noticed that after clicking 2 or 3 other View(s) (the Slider whose margins are being set or other View(s)), the newly set margins are applied. This leads me to believe that the app is not redrawing the Slider when I set the margins. I tried calling the Invalidate() method of the Slider, but it did not help. Something I will mention about this XML layout is that it is used by an include tag in activity_main.xml, and includes a large number of View(s). I understand that having a large number of View(s) can decrease performance, but I am not sure how else to get the desired layout (most of the large number of View(s) come from 6 GridLayout(s) each of which contains 18 identical ImageView(s), which do not change other than setting their initial values & sometimes changing their Visibility). What do I need to do to refresh the layout with the new margins? Is it possible that the large number of View(s) is causing this problem?
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-07T02:06:30.13+00:00

Calling SetMargin() directly in Android will not change the layout, you can try the following code to reset the LayoutParameters:

var slider = FindViewById(Resource.Id.mySlider); var ll = new LinearLayout.LayoutParams(slider.Width, slider.Height); var gl = new GridLayout.LayoutParams(ll); gl.SetMargins(30, 30, 30, 30); slider.LayoutParameters = gl;

Would it be helpful for you? Your prompt reply will be highly appreciated.
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-09T06:27:07.527+00:00

May I know whether your issue has been solved or not? If not, please share it in here. We can work together to figure it out.
Nathan Sokalski 4,111 Reputation points

2022-12-09T17:54:45.19+00:00

I'm not sure if it's the reason, or maybe it was reducing the number of View(s), but I tried adding a few extra SetMargins calls to make sure that the margins ALWAYS got changed (even if I immediately change them back on the very next line of code). Whether this was the reason or not, it seems to be working now. Thank you for your help.
Yonglun Liu (Shanghai Wicresoft Co,.Ltd.) 50,126 Reputation points Microsoft External Staff

2022-12-12T01:52:09.19+00:00

Thanks for your feedback, could you please share your solution here?

It would be helpful for others who meet the same issue.

Share via

SetMargins Method does Nothing

Your answer