Run .vbs file

Question

Run .vbs file

Quintas 20

Hi!

I don't know about scripting in vbs. Here in the environment we have a 2008 Standard R2 server with scheduling that executes a .bat file with: cscript file.vbs

Everything works normally. But I need to migrate this server to a 2016 and when testing this same process it gives error "Microsoft VBScript runtime error: Array fixed or temporarily blocked" code 800A000A

I noticed that when I run it in 2008 it shows "Microsoft (R) Windows Script Host Version 5.8" and when I run it in 2016 the version is "Microsoft (R) Windows Script Host Version 5.812"

What do I need to do for this same .vbs script that is functional to also run in 2016?

Answer 1

Michael Taylor 41,276

I don't think it is specifically related to Server 2016 but more likely something the script itself is doing. If the script is erroring then you should be able to determine which line it is failing on. Provide the code that is failing so we can see what is going on.

Quintas 20 Reputation points

2023-01-27T11:46:32.84+00:00

If it was a problem in the script it wouldn't work on server 2008, don't you think?

It seems to me that it needs some specific configuration to run, but I really don't know about vbs scripts. I even tried to do the same process all in bat but the script is quite complex, it does several date and file name checks.
Quintas 20 Reputation points

2023-01-27T12:08:24.1366667+00:00

If it was a problem in the script it wouldn't work on server 2008, don't you think?

It seems to me that it needs some specific configuration to run, but I really don't know about vbs scripts. I even tried to do the same process all in bat but the script is quite complex, it does several date and file name checks.
Michael Taylor 41,276 Reputation points

2023-01-27T15:00:20.6766667+00:00

Not necessarily true, but we are working with a single error message and no context so we are only guessing. The more information you provide the quicker you can get a solution. The error itself, if it occurs before the script runs, indicates a configuration issue perhaps. But if it occurs after the script starts running then it indicates a problem with either whatever the script is working with or the script itself. The error leads me to believe that previously it was working with multiple items (an array??) and now it is working with one. This could be a change in an API call. Again, we have absolutely no way of diagnosing this without more information.

You can quickly confirm VBS works on the new server by creating a simple vbs script that simply displays a message box. If it works then VBS is fine. At that point you need to debug the script itself.

Quintas 20

OK.

This is the vbs that is running on 2008:

Option Explicit 

		DIM fso, ObjFolder, ColFiles, ObjFile
	
		DIM Filename, DateOcorStr, DateoCorDate, NameSplited, DateNow, DateBefore
	
		DIM NumPC (21)
		NumPC(0)="221"
		NumPC(1)="222"
		NumPC(2)="223"
		NumPC(3)="224"
		NumPC(4)="225"
		NumPC(5)="226"
		NumPC(6)="227"
		NumPC(7)="228"
		NumPC(8)="229"
		NumPC(9)="230"
		NumPC(10)="231"
		NumPC(11)="232"
		NumPC(12)="233"
		NumPC(13)="234"
		NumPC(14)="235"
		NumPC(15)="236"
		NumPC(16)="237"
		NumPC(17)="238"
		NumPC(18)="239"
		NumPC(19)="240"
		NumPC(20)="241"
		NumPC(21)="242"
	
		const cnstCommand = 1
	
		DateNow=Now
		DateBefore= cDate(DatePart("m",Datenow) & "/01" & "/" & DatePart("yyyy",Datenow))

	For each NumPC in NumPC 

				Set fso = CreateObject("Scripting.FileSystemObject") 

				wscript.Echo "\\pc" & NumPC & "south\bkp$\"
				Set ObjFolder=fso.GetFolder("\\pc" & NumPC & "south\bkp$\")

				Set ColFiles=ObjFolder.files

				For each ObjFile in ColFiles

					FileName=ObjFile.Name

					If InStr(FileName, "-")>0 then
						NameSplited= Split(Filename, "-")

						DateOcorStr=NameSplited(1)
						DateOcorDate=  Mid(DateOcorStr,7,2) & "/" &  Mid(DateOcorStr,5,2) & "/" & Left(DateOcorStr,4)& " 00:00:00" 

						If  (NameSplited(0)="nfc") Then

							If ((cDate(DateOcorDate) >= DateBefore) AND (cDate(DateOcorDate) < cdate(DateNow)-1)) then

								If fso.FileExists ("\\172.16.2.28\pc" & NumPC & "\LOG\" & ObjFile.name)then
									    Wscript.Echo "Existing!" 

								else		
										If  fso.folderExists ("\\172.16.2.28\pc" & NumPC & "\LOG\") Then
											fso.CopyFile "\\pc"& NumPC & "south\bkp$\" & ObjFile.name , "\\172.16.2.28\pc" & NumPC & "\LOG\", true
										else
											fso.CreateFolder ("\\172.16.2.28\pc" & NumPC & "\LOG\")
											fso.CopyFile "\\pc"& NumPC & "south\bkp$\" & ObjFile.name , "\\172.16.2.28\pc" & NumPC & "\LOG\", true
										End If
								End If

							else
									If (cDate(DateOcorDate) < DateAdd("m", -3, DateBefore) )then	
										fso.DeleteFile "\\pc"& NumPC & "south\bkp$\" & ObjFile.name  & "*"										
									End If	
							End If
						End If
					End If
		next
	Next

This is the error when trying to run the same in 2016:

User's image

Michael Taylor 41,276 Reputation points

2023-01-29T04:19:14.4633333+00:00
This script isn't correct for VBS. Honestly I'm not sure how it would have worked before. The first thing I notice is that NumPC(0) = "221" is invalid. VB arrays are 1 based so the first element is NumPc(1). But maybe this is a quirk with VBS.

The actual error you're seeing though is the foreach. You are attempting to store into NumPC the current element of NumPC (the array). This is trying to use the array variable as a temp variable for elements in the array and that won't work.

Change each reference to NumPC inside the for loop to item. Then try it again.

Dim Item For Each Item in NumPC Set fso = CreateObject("Scripting.FileSystemObject") wscript.Echo "\\pc" & Item & "south\bkp$\" Set ObjFolder=fso.GetFolder("\\pc" & Item & "south\bkp$\") ... Next
Quintas 20 Reputation points

2023-01-29T12:48:07.2+00:00

I made the adjustment with the item variable and the error changed. Then I changed the array starting with 1 and it showed the same error:
Viorel 89,061 Reputation points

2023-01-29T16:49:02.49+00:00

It seems that the previous errors were solved. Show the line 37 that gives the new error, or better show your current full script. Maybe the error is caused by incorrect assumption regarding the lower bound of arrays.

Michael Taylor 41,276

At this point the code appears correct and you're now running into a runtime error related to the file management. Since we don't have your server setup it would be difficult for us to debug this for you so you might need to debug yourself. However I ran the equivalent code and it correctly copies/creates/deletes files. Here's the updated script that I cleaned up a little while checking to see if there are any issues.

Option Explicit 

DIM fso, ObjFolder, ColFiles, ObjFile

DIM Filename, DateOcorStr, DateoCorDate, NameSplited, DateNow, DateBefore

DIM NumPC (21)
NumPC(0)="221"
NumPC(1)="222"
NumPC(2)="223"
NumPC(3)="224"
NumPC(4)="225"
NumPC(5)="226"
NumPC(6)="227"
NumPC(7)="228"
NumPC(8)="229"
NumPC(9)="230"
NumPC(10)="231"
NumPC(11)="232"
NumPC(12)="233"
NumPC(13)="234"
NumPC(14)="235"
NumPC(15)="236"
NumPC(16)="237"
NumPC(17)="238"
NumPC(18)="239"
NumPC(19)="240"
NumPC(20)="241"
NumPC(21)="242"

const cnstCommand = 1

DateNow=Now
DateBefore= cDate(DatePart("m",Datenow) & "/01" & "/" & DatePart("yyyy",Datenow))

Dim Item
Dim targetPath
For each Item in NumPC 
	
	Set fso = CreateObject("Scripting.FileSystemObject") 

	'wscript.Echo "\\pc" & Item & "south\bkp$\"
	Set ObjFolder=fso.GetFolder("\\pc" & Item & "south\bkp$\")
	targetPath = "\\172.16.2.28\pc" & Item & "\LOG\"
	
	Set ColFiles=ObjFolder.files

	For each ObjFile in ColFiles

		FileName=ObjFile.Name

		If InStr(FileName, "-")>0 then
			NameSplited= Split(Filename, "-")

			DateOcorStr=NameSplited(1)
			DateOcorDate=  Mid(DateOcorStr,7,2) & "/" &  Mid(DateOcorStr,5,2) & "/" & Left(DateOcorStr,4)& " 00:00:00" 

			If  (NameSplited(0)="nfc") Then

				If ((cDate(DateOcorDate) >= DateBefore) AND (cDate(DateOcorDate) < cdate(DateNow)-1)) then

					If fso.FileExists(targetPath & ObjFile.name)then
						Wscript.Echo "Existing!" 
					else
						If Not fso.folderExists (targetPath) Then
							fso.CreateFolder (targetPath)				
						End If
							
						fso.CopyFile ObjFile.Path, targetPath, true
					End If
				elseIf (cDate(DateOcorDate) < DateAdd("m", -3, DateBefore) )then	
					fso.DeleteFile ObjFile.path  & "*"																
				End If
				
			End If
		End If
	next
Next

I suspect that the issue might be that one of the machines in your array that you're enumerating through is returning Nothing for one of the FSO calls. Therefore the script fails. You should consider wrapping the contents of the actual work inside the for each in an error handler so you can skip over machines that have issues.

Quintas 20 Reputation points

2023-01-30T18:01:44.32+00:00

Perfect! It worked correctly.

Following your code I realized that I had missed changing the variable between &&. It was still NumPC instead of Item.

Run .vbs file

0 additional answers

Activity