PARAM issue

Question

I am trying to fix a script that was working below is the piece of code that is causing the problem:

param ([Switch]$detailed)  
Clear-Host  
###########################################################################################################################################################  
Function VALIDATEDCONLINE   
{  
	param ($server)  
	$Global:DCOnline = $Null  
	""  
	"------------------------------------------------------------------------------------"  
	"VALIDATING $SERVER IS ONLINE"  
	"------------------------------------------------------------------------------------"  
	""  
	$result = test-connection -computername $Server -quiet  
	if (!$result)  
	{  
		Write-host -ForegroundColor Red "Error, $server appears to be offline. Please check it manually"  
		write-host -ForegroundColor Red "Moving to next server..."  
		$Global:DCOnline = $false  
	}  
	else  
	{  
		Write-Host -ForegroundColor Green "$server is online. Beginning DCHealthCheck"  
	}  
}  

The Error I am getting is:

How can I fix this PARM issue?

Answer 1

The piece of script that should be passing the server name is below, the Item listed ($Servers = $input) seemed to be the culprit, I removed the S and it fixed the script:

Prompt user for dc or txt file with list of DCs
$cwd = Get-Location
$TextFileInput = "*.txt"
$ServerInput = "*0*"
$matchFound = $null
###Validate input
while($validParamPassed -ne $true)
{
$input = (Read-Host "Please enter the name of the DC, a txt file, or a domain. Ex. DC_Name, servers.txt, ED.  Note: The txt file must be in the same directory as the script."`n)
    switch($input)
    {
        {$_ -like $TextFileInput}
            {   
                $servers = Get-Content "$cwd\$input"
                $validParamPassed = $true
                break
            }
        {$_ -like $ServerInput}
            {
                $Servers = $input
                $validParamPassed = $true
                break
            }
        #Validate that the DC is a DC in the forest that the healthcheck script is being executed in.
        {$_ -like "*"}
            {
                $domains = ([system.directoryservices.activedirectory.forest]::getcurrentforest().Domains).name
                foreach($domain in $domains)
                {
                    if($domain -match $input)
                    {
                        $matchFound = $true
                    }
                }
                if($matchFound)
                {
                    $DCs = [system.directoryservices.activedirectory.forest]::getcurrentforest().Domains | ForEach-Object {$_.DomainControllers} | Select Name -ExpandProperty Name
                    $Servers = $DCs -match $input
                    $validParamPassed = $true
                    break
                }
            }
        default {Write-Host -ForegroundColor Red "Please enter valid input!";$validParamPassed = $false}
    }
}
Clear-Host  

$now = Get-Date
$string_now = $now.tostring("MM-dd-yyyy_HHmmss")
$admin = whoami
$logpath = "$CWD\DCHealthCheckLogs\"
$pathtest = Test-Path $logpath 
if ($pathtest -eq $false)
{
    Write-Host "Creating $logpath Directory" 
    New-Item -Path $logpath -type directory | Out-Null
}
$logfile = "$logpath" + "DCHealthCheck" + "$string_now" + ".html"
"`nStarting the Domain Controller Heath Check Script"
"Initiated by: $admin"
"Current Date/Time: $now"

Answer 2

You fix it by passing the name of a computer when you call the function.

VALIDATEDCONLINE computer-name

Answer 3

I did give you an example!

How about this:

VALIDATEDCONLINE  REPLACE-THIS-STRING-WITH-THE-NAME-OF-A-COMPUTER

Answer 4

Your function is really isn't necessary. But if you want to use it you might consider using in like this, after making sure the parameter's been suppled and eliminating the unnecessary use of a global variable.

Function VALIDATEDCONLINE 
{
    param (
        [Parameter(Mandatory=$true)]
        [String]$server
    )
    if (test-connection -computername $Server -quiet){
        Write-Host -ForegroundColor Green "$server is online. Beginning DCHealthCheck"
        $true
    }
    else{
        Write-host -ForegroundColor Red "Error, $server appears to be offline. Please check it manually"
        write-host -ForegroundColor Red "Moving to next server..."
        $false
    }
}

Get-Content c:\junk\serverlist.txt |
    Foreach-Object{
        If (VALIDATEDCONLINE $_){
            # server's online
        }
        else{
            # server's offline
        }
    }

Or just don't use a function to perform the test-connection and use something like this:

Get-Content c:\junk\serverlist.txt |
    Foreach-Object{
        If (test-connection -computername $_ -quiet){
            Write-Host -ForegroundColor Green "$server is online. Beginning DCHealthCheck"
            # server's online, place your code here
        }
        else{
            # server's offline
            Write-host -ForegroundColor Red "Error, $server appears to be offline. Please check it manually"
            write-host -ForegroundColor Red "Moving to next server..."
        }
    }