How to properly get System Model in PowerShell and set it as a parameter?

Question

How to properly get System Model in PowerShell and set it as a parameter?

Arthur Durand 171

I need to use PowerShell to properly get the System Model of a PC and use the model number as a parameter so that I can run tasks specific to the model number. My code is a little more complex due to the fact that some of the methods returns values like 'Not Available', 'To be filled by O.E.M.'or  'System Product Manufacturer' - in these instances I do not want the $Model parameter to be 'Not Available', 'To be filled by O.E.M.'or  'System Product Manufacturer'.

I have the following, but it doesn't work as desired

$BaseBoardManufacturer = Get-WmiObject Win32_BaseBoard | Select Manufacturer

if ((-not ([string]::IsNullOrWhiteSpace($BaseBoardManufacturer))) -and ($BaseBoardManufacturer.Manufacturer -ne 'Not Available') -or ($BaseBoardManufacturer.Manufacturer -ne 'System manufacturer')) { [String]$Manufacturer = ($BaseBoardManufacturer.Manufacturer).ToString() }

$ProductManufacturer = Get-WmiObject -Class:Win32_ComputerSystemProduct | select Vendor
if ((-not ([string]::IsNullOrWhiteSpace($ProductManufacturer))) -and ($ProductManufacturer.Vendor -ne 'Not Available') -or ($ProductManufacturer.Vendor -ne 'System manufacturer') -or ($ProductManufacturer.Vendor -ne 'To be filled by O.E.M.'))
{
    [String]$Manufacturer = ($ProductManufacturer.Vendor).ToString()
}

$SystemManufacturer = Get-WmiObject -Class:Win32_ComputerSystem | select Manufacturer
if ((-not ([string]::IsNullOrWhiteSpace($SystemManufacturer))) -and ($SystemManufacturer.Manufacturer -ne 'Not Available') -or ($SystemManufacturer.Manufacturer -ne 'System manufacturer') -or ($SystemManufacturer.Manufacturer -ne 'To be filled by O.E.M.'))
{
    [String]$Manufacturer = ($SystemManufacturer.Manufacturer).ToString()
}

$BaseBoardProduct = Get-WmiObject Win32_BaseBoard | Select Product
if ((-not ([string]::IsNullOrWhiteSpace($BaseBoardProduct))) -and ($BaseBoardProduct.Product -ne 'Not Available'))
{
    [String]$Model = ($BaseBoardProduct.Product).ToString()
}

$ProductVersion = Get-WmiObject -Class:Win32_ComputerSystemProduct | select Version
if ((!($ProductVersion.Version -ne 'System Version')) -xor (!($ProductVersion.Version -ne 'To be filled by O.E.M.')) -and (-not ([string]::IsNullOrWhiteSpace($ProductVersion))))
{
    [String]$Model = ($ProductVersion.Version).ToString()
}

$SystemModel = Get-WmiObject -Class:Win32_ComputerSystem | select Model
if ((-not ([string]::IsNullOrWhiteSpace($SystemModel))) -and ($SystemModel.Model -ne 'System Product Name') -or ($SystemModel.Model -ne 'To be filled by O.E.M.'))
{
    [String]$Model = ($SystemModel.Model).ToString()
}

$SystemManufacturer = Get-WmiObject -Class:Win32_ComputerSystem | select Manufacturer
if ((-not ([string]::IsNullOrWhiteSpace($SystemManufacturer))) -and ($SystemManufacturer.Manufacturer -ne 'Not Available') -or ($SystemManufacturer.Manufacturer -ne 'System manufacturer') -or ($SystemManufacturer.Manufacturer -ne 'To be filled by O.E.M.'))
{
    [String]$Manufacturer = ($SystemManufacturer.Manufacturer).ToString()
}

if ($Manufacturer -like '*Lenovo*')
{
    $ProductVersion = Get-WmiObject -Class:Win32_ComputerSystemProduct | select Version
[String]$Model = ($ProductVersion.Version).ToString()
}


I want e.g.

((!($ProductVersion.Version -ne 'System Version')) -or (!($ProductVersion.Version -ne 'To be filled by O.E.M.')) -and (-not ([string]::IsNullOrWhiteSpace($ProductVersion))))

to return false when the ProductVersion returns 'To be filled by O.E.M.' or 'System Version', but it returns true!

I've tried

((!($ProductVersion.Version -ne 'System Version')) -xor (!($ProductVersion.Version -ne 'To be filled by O.E.M.')) -and (-not ([string]::IsNullOrWhiteSpace($ProductVersion))))

and

if ((-not ($SystemModel.Model -eq 'System Product Name')) -or (-not ($SystemModel.Model -eq 'To be filled by O.E.M.')) -and (-not ([string]::IsNullOrWhiteSpace($SystemModel))))

but I get 'System Version' set as the parameter instead of the Model Number, in other words the argument returns true when it is suppoesed to return false

2 answers

Your answer

Answer 1

Rich Matheisen 47,901

Is this the set of conditions you want?

( ($ProductVersion.Version -ne 'System Version') -AND 
( ($ProductVersion.Version -ne 'To be filled by O.E.M.')) -AND
( -NOT ([string]::IsNullOrWhiteSpace($ProductVersion))))

The original used "NOT (X not equal Y)" which is actually "X equal Y" once you remove the double negative.

Also, mixing negative tests with the OR condition will almost aways never work because if the first condition is true the second condition can't be true when referring to the same object.

Arthur Durand 171 Reputation points

2023-02-20T20:34:02.06+00:00
( ($ProductVersion.Version -ne 'System Version') -AND ( ($ProductVersion.Version -ne 'To be filled by O.E.M.'))

At least one of these conditions might be true, both will never be true, but both might be false! If both of these are false and ( -NOT ([string]::IsNullOrWhiteSpace($ProductVersion)))) is true, the result should be true, otherwise the result should be false!
Rich Matheisen 47,901 Reputation points

2023-02-20T20:46:34.7466667+00:00

For arguments sake, let's assume that $Product.Version has a value of "X".

That's not equal to "System Version", AND it's not equal to "To be filled by O.E.M.". Since both are True, the entire condition is True. So, how did you arrive at the conclusion that the result would be other than "True"?

You can even toss in the fact that the $Product.Version is not an empty string and all three conditions (connected by AND) would yield a "True" result.

Answer 2

Arthur Durand 171


$BaseBoardProduct = Get-WmiObject Win32_BaseBoard | Where-Object {$_.Product -ne 'Not Available'} | Select-Object -ExpandProperty Product
if (-not ([string]::IsNullOrWhiteSpace($BaseBoardProduct)))
{
    $Model = $BaseBoardProduct
}

$ProductVersion = Get-WmiObject -Class:Win32_ComputerSystemProduct | Where-Object {$_.Version -ne 'System Version' -and $_.Version -ne 'To be filled by O.E.M.'} | Select-Object -ExpandProperty Version
if (-not ([string]::IsNullOrWhiteSpace($ProductVersion)))
{
    $Model = $ProductVersion
}

$SystemModel = Get-WmiObject -Class:Win32_ComputerSystem | Where-Object {$_.Model -ne 'System Product Name' -and $_.Model -ne 'To be filled by O.E.M.'} | Select-Object -ExpandProperty Model
if (-not ([string]::IsNullOrWhiteSpace($SystemModel)))
{
    $Model = $SystemModel
}

$SystemManufacturer = Get-WmiObject -Class:Win32_ComputerSystem | Where-Object {$_.Manufacturer -ne 'Not Available' -and $_.Manufacturer -ne 'System manufacturer' -and $_.Manufacturer -ne 'To be filled by O.E.M.'} | Select-Object -ExpandProperty Manufacturer
if (-not ([string]::IsNullOrWhiteSpace($SystemManufacturer)))
{
    $Manufacturer = $SystemManufacturer
}

if ($Manufacturer -like '*Lenovo*')
{
    $ProductVersion = Get-WmiObject -Class:Win32_ComputerSystemProduct | Select-Object -ExpandProperty Version
    $Model = $ProductVersion
}

solves my issue!

Arthur Durand 171

ChatGPT came up with

$ExcludedManufacturers = 'Not Available', 'System Manufacturer', 'To be filled by O.E.M.'
$Filter = "Manufacturer!='Not Available' AND Manufacturer!='System Manufacturer' AND Manufacturer!='To be filled by O.E.M.'"

$SystemInfo = Get-CimInstance -ClassName Win32_ComputerSystem -Property Model, Manufacturer -Filter $Filter | Sort-Object Manufacturer
$BaseBoardProduct = Get-CimInstance -ClassName Win32_BaseBoard -Property Product -Filter "Product!='Not Available'" | Sort-Object Product | Select-Object -First 1
$ProductVersion = $SystemInfo | Where-Object { $_.Version -notin 'System Version', 'To be filled by O.E.M.' } | Sort-Object Manufacturer | Select-Object -First 1 -ExpandProperty Version
$Model = ($BaseBoardProduct.Product, $SystemInfo.Model) | Where-Object { $_ -notin 'System Product Name', 'To be filled by O.E.M.' } | Select-Object -First 1
$Manufacturer = $SystemInfo[0].Manufacturer

if ($Manufacturer -like '*Lenovo*') {
    $Model = $ProductVersion
}

or

$BaseBoardProduct = Get-WmiObject -Class Win32_BaseBoard | Select-Object -ExpandProperty Product | Where-Object {$_ -ne 'Not Available'} | Select-Object -First 1
$ProductVersion = Get-WmiObject -Class Win32_ComputerSystemProduct | Select-Object -ExpandProperty Version | Where-Object {$_ -notin ('System Version', 'To be filled by O.E.M.')} | Select-Object -First 1
$SystemModel = Get-WmiObject -Class Win32_ComputerSystem | Select-Object -ExpandProperty Model | Where-Object {$_ -notin ('System Product Name', 'To be filled by O.E.M.')} | Select-Object -First 1
$SystemManufacturer = Get-WmiObject -Class Win32_ComputerSystem | Select-Object -ExpandProperty Manufacturer | Where-Object {$_ -notin ('Not Available', 'System Manufacturer', 'To be filled by O.E.M.')} | Select-Object -First 1

if ($SystemManufacturer -like '*Lenovo*') {
    $Model = $ProductVersion
} else {
    $Model = $BaseBoardProduct ?? $SystemModel ?? $ProductVersion
}

for older versions of PowerShell!

Share via

How to properly get System Model in PowerShell and set it as a parameter?

2 answers

Your answer