Renaming doesn't work properly sometimes

Question

Hi,

I'm trying to find an error. The error occurs when renaming.

The code below renames a file to Test.pdf and after editing renames it back to the original name but appending an extension (.edited).

Sometimes it happens that the file does not have the original name but is called Test.pdf.edited.

The code is not mine and works fine for thousands of files, but unfortunately not for a few files a day.

What could be the reason, has anyone seen such behavior before. Can it be due to a permission or that another process is still accessing it or a property that distinguishes the file from others?

$path = 'xxx\xxx'
$filter = '*.pdf'
...
$files = Get-ChildItem -Path $path  -Name $filter

foreach($file in $files)
{
  # File gets renamed to Test.pdf  
  Rename-Item $path\$file 'Test.pdf' -Force

  #...Content from file will be extracted here by Get-Content for the email.
  ...

  #...File will be send by email here...
  ...

  # File gets renamed to the original name + .edited (MyFileName.pdf.edited)
  Rename-Item  $path'\Test.pdf' "$path\$file.edited" -Force
}

Answer 1

I'm surprised that worked at all!

$path = "xxx\xxx"
$files = Get-ChildItem -Path $path -File -Filter *.pdf 

foreach($file in $files)
{
  # File gets renamed to Test.pdf  
  Rename-Item -Path $file.FullName 'Test.pdf' -Force

  #...Content from file will be extracted here by Get-Content for the email.
  #...

  #...File will be send by email here...
  #...

  # File gets renamed to the original name + .edited (MyFileName.pdf.edited)

  # If the $file variable has its FullName value equal to C:\junk\test.csv, then
  # the result of "$path\$file.edited" looks like "xxx\xxx\C:junk\test.csv.edited"!
  # Rename-Item  $path'\Test.pdf' "$path\$file.edited" -Force
  #
  #
  Rename-Item ($file.DirectoryName + '\Test.pdf') "$($File.Name).edited" -Force
}