c# EF 6 how to make this better ?

Question

Hello all,

I need to find a solution for to have better performance on a method.

As you can see in the picture i have a method who is call on a MVC Controller.

This method will be call too much in more or less one hour.

This method FindEvents, take a list of string as parameters and if you look the code i see 2 problems of it

1. 1. the select *
2. the where clause query are build with for each statement

Here is it what i can do for to have better performance:

1. -> select * can be replace by annymous type for to avoid to get the > 60 column of the table and just take the field we need
2. -> for the foreach loop, I wonder if it's better to build a foreach for to have this resutl in ('AAA,' 'BBB', 'CCC' )

    Or
   
   To send the long string like this 'AAA, BBB,CCC' make a splt in sql function and execute the query
   

Also do you think it will be better to used with EF store procedure ?

Any comment, way to have better performance will be apprecied ..

thanks for all

Answer 1

you may have few options to improve the performance

• Use a SQL stored procedure instead of Entity Framework
• Use a projection to select only the columns you need Instead of using select *
• Use a parameterized query instead of building the where clause with a loop:
• Cache the results of the query