Git configuration is deleted when publishing

Josh Roberson 31

When publishing in data factory, the git repo is sometimes deleted. We've seen this 3 times this week alone. Perhaps it coincides with adding a global parameter. Are there ways to audit/troubleshoot this issue?

Josh Roberson 31 Reputation points

2020-10-19T15:38:10.05+00:00

Our ADF Name: cxdevrco-adf Region: West US

We have the checkbox checked to include the global params in the ARM template(s). The global param we set up is just the environment name, basically the same as demonstrated on the website you linked to. We were looking to validate before rolling out any other changes.

We have an automated deploy trigger set up in Az Dev Ops pipeline when changes are pushed to the adf_publish branch.

I guess I'm not entirely following the explanation but it kind of sounds like using global parameters isn't compatible with storing ADF in git? Or is it just that including global params in ARM templates isn't compatible with git? If either is correct, it would seem logical to disable or at least warn users that their git config would be lost when using the feature.
HarithaMaddi-MSFT 10,136 Reputation points

2020-10-19T15:46:00.697+00:00

Hi @Josh Roberson ,

As mentioned in the snap above and in the document shared, it is stated that enabling global parameters to be included in ARM templates will overwrite GIT configurations in ARM template and hence you are observing that the GIT configuration is lost when auto-deployed. Please suggest if these details are unclear.
Josh Roberson 31 Reputation points

2020-10-19T16:27:38.603+00:00

I would say the documentation is terribly unclear. The documentation snippet you posted says "can override other factory-level settings..." not "will overwrite GIT configuration" so it's not at all clear that is a consequence of doing so. It would seem like it would be preferable to disable the ARM template checkbox if GIT is configured.

It's not at all clear why would adding a global param & including it in an ARM template have any effect whatsoever on GIT configuration. Why are those things related at all?
HarithaMaddi-MSFT 10,136 Reputation points

2020-10-19T17:05:36.147+00:00

Thanks @Josh Roberson for sharing the queries. I reached out to Product team to get more insights on this and will get back to you with further updates.

Thanks for your patience!
HarithaMaddi-MSFT 10,136 Reputation points

2020-10-21T08:06:03.833+00:00

Thanks @Josh Roberson for your valuable contribution. I have raised PR to update documentation to reflect the statement as "will overwrite GIT configuration" and changes will reflect today or tomorrow. I got update from Product team that Global parameters is a factory level setting and GIT configuration is recommended to be only setup for dev environment. For subsequent environments best practice is not to enable GIT configuration. Please suggest for further queries and we will be glad to assist.
Josh Roberson 31 Reputation points

2020-10-21T13:49:17.717+00:00

I think that's a useful improvement. I still don't understand why including the global parameters in the ARM template destroys the linkage to git but it sounds like it's just how it is. Thanks for your help.
HarithaMaddi-MSFT 10,136 Reputation points

2020-10-21T14:22:40.09+00:00

Thanks @Josh Roberson for understanding and glad that our answer is helpful.

Accepted answer

HarithaMaddi-MSFT 10,136 Reputation points

2020-10-19T14:45:30.143+00:00

Hi @Josh Roberson ,

Welcome to Microsoft Q&A Platform. Thanks for posting the query.

This seems strange and we have not heard this kind of issue in recent times from any customers. I tried reproducing by adding, modifying and deleting global parameters in data factory connected to GIT and I did not see this behavior. Since it seems specific to the data factory, can you please share details of data factory name and region. Also, can you please check if any deployment is happening on data factory at that time because with global parameters the GIT configuration is not present in the ARM templates and this can cause GIT to be removed as per the document.

Please let us know these details to proceed with further investigation.
Please sign in to rate this answer.

0 comments No comments
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

Share via

Git configuration is deleted when publishing

0 additional answers

Your answer