Problem with batch script

Question

Hi, I have a problem with the following script.

@echo off  REM Check the OS version wmic os get Caption | findstr /i "Windows 10 Enterprise" > nul if %errorlevel% equ 0 (     set "install_folder=\\server\share\EnterpriseAppFolder" ) else (     wmic os get Caption | findstr /i "Windows 10 Professional" > nul     if %errorlevel% equ 0 (         set "install_folder=\\server\share\ProfessionalAppFolder"     ) else (         echo Unsupported OS version.         exit /b 1     ) )  REM Install the application echo Installing application from %install_folder%... msiexec /i "%install_folder%\application.msi" /qn  REM Add additional installation steps if needed  exit /b 0 

In both cases, it always chooses the first option, and %errorlevel% is equal to zero. Even though it is Windows 10 Professional, it selects the "Windows 10 Enterprise" option. Although the script seems to be correct, please help me.

Answer 1

Hi, @TIMECOP79

Thank you for posting in Microsoft Q&A forum.

Based on the provided script, the issue seems to be with the findstr command. The search string is currently set to "Windows 10 Enterprise" and it will match any OS containing those words, including "Windows 10 Enterprise" and "Windows 10 Enterprise N". The same is true for the search string "Windows 10 Professional".

To fix the issue, you can modify the search strings to match the exact OS version by adding a space at the end of the search strings. Here's the updated script:

@echo off
REM Check the OS version
wmic os get Caption | findstr /i "Windows 10 Enterprise " > nul
if %errorlevel% equ 0 (
    set "install_folder=\\server\share\EnterpriseAppFolder"
) else (
    wmic os get Caption | findstr /i "Windows 10 Professional " > nul
    if %errorlevel% equ 0 (
        set "install_folder=\\server\share\ProfessionalAppFolder"
    ) else (
        echo Unsupported OS version.
        exit /b 1
    )
)
REM Install the application
echo Installing application from %install_folder%...
msiexec /i "%install_folder%\application.msi" /qn
REM Add additional installation steps if needed
exit /b 0

With this modification, findstr will only match OS versions that contain the exact search string, which should solve the issue you're facing.

---

If the answer is the right solution, please click "Accept Answer" and kindly upvote it. If you have extra questions about this answer, please click "Add comment".

Answer 2

Hello,

First of all, thank you very much for taking the time to respond to me. Unfortunately, I ran the test on "Windows 10 Professional," but the script still points to the "Windows 10 Enterprise" folder. To be precise, the "wmic" command displays "Microsoft Windows 10 Enterprise." I believe I have found the real issue, which lies in the "else" statement not being taken into account. Now I need to figure out how to solve the problem.