Powershell parameters

Question

Powershell parameters

Sara 441

I have the following function and I am trying to define some parameters, particularly $vipstatus and $netscalername to see outputs only based out of it when needed, but when I run

Get-NSVIPStatus $vipstatus

it displays the entire result instead of the output that is stored in that variable,what am I missing?

function Get-NSVIPStatus
{
param(
    [parameter(Mandatory=$false)]
    [string]$vipstatus
)


$Components = @("virtualserver")

$VIPstatus = New-Object System.Collections.ArrayList($null)

foreach ($component in $Components) 
{
    $Metrics = Invoke-RestMethod "https://graphvip100.com/metrics/find?query=metrics.winops.netscalers.components.nsexsre*.$component.*.2m.status" -ErrorAction Stop
    $Raw = foreach ($metric in $Metrics) 
    {
        Invoke-RestMethod "https://graphvip100.com/render?target=$($metric.id)&from=-10min&format=csv" -ErrorAction Stop
    }

    $Data = $Raw | ConvertFrom-Csv -Header "Metric","Time","Value" | Where-Object { -not [string]::IsNullOrEmpty($_.Value) } | Group-Object -Property Metric

    foreach ($group in $Data) 
    {
        $NetscalerName = $group.Name.Split(".")[4]
        $Componentname = $group.name.split(".")[5]
        $Name          = $group.Name.Split(".")[6]
        
        If (($group.Group[-1].Value -eq "0.0") 
        {
            $vipdown = [PSCustomObject]@{
                NetscalerName = $NetscalerName
                Componentname = $Componentname
                Name = $Name
        }
    
    foreach ($vip in $vipdown)
    {
        $null = $VIPstatus.Add($vipdown)
        write-warning "$vipdown is down"
    }      
            
     $failures = $true
        }
        ElseIf (($group.Group[-1].Value -eq "1.0") 
        {
            Write-Verbose "$NetscalerName $Componentname $Name is UP" -Verbose
        }
        ElseIf (($group.Group[-1].Value -eq "2.0")
        {
            Write-Verbose "$NetscalerName $Componentname $Name is OUT OF SERVICE" -Verbose
        }
    }
}

Rich Matheisen 48,116 Reputation points

2023-06-21T19:01:43.2666667+00:00

There are several problems with your code (missing parantheses, mismatched curly braces, an "ElseIf" without a matching "If"). Correct those errors first.

You also declare a string parameter "$vipstatus" and then replace it with an array ($VIPstatus = New-Object System.Collections.ArrayList($null)).

It also looks like you expect the variable $vipdown to be an array (you use it in a foreach loop), but only store one PSCustomObject in it and then add $vipdown to $VipStatus.

You also set $failures to $true, but then never reference $failures again.

1 answer

Your answer

Rich Matheisen 48,116 Reputation points

2023-06-21T19:01:43.2666667+00:00

There are several problems with your code (missing parantheses, mismatched curly braces, an "ElseIf" without a matching "If"). Correct those errors first.

You also declare a string parameter "$vipstatus" and then replace it with an array ($VIPstatus = New-Object System.Collections.ArrayList($null)).

It also looks like you expect the variable $vipdown to be an array (you use it in a foreach loop), but only store one PSCustomObject in it and then add $vipdown to $VipStatus.

You also set $failures to $true, but then never reference $failures again.

Answer 1

Limitless Technology 45,241

Hello Sara,

Thank you for your question and for reaching out with your question today.

In your code, it seems that you are passing the variable $vipstatus directly to the Get-NSVIPStatus function. However, you need to pass the value of the variable instead of the variable itself.

To achieve this, you can modify your code as follows:


Get-NSVIPStatus -vipstatus $vipstatus

By using the -vipstatus parameter and passing the value stored in the $vipstatus variable, you can ensure that only the specific output based on that parameter is displayed.

Also, please note that in your function, you are using the $vipstatus parameter in the script block. If you want to filter the results based on the value of the $vipstatus parameter, you need to modify your code accordingly within the foreach loop or wherever you intend to apply the filter.

I used AI provided by ChatGPT to formulate part of this response. I have verified that the information is accurate before sharing it with you.

If the reply was helpful, please don’t forget to upvote or accept as answer.

Rich Matheisen 48,116 Reputation points

2023-06-22T15:05:41.2666667+00:00
What utter claptrap! Did you actually verify the accuracy of your answer? I think not!

Verify this:

Function A{ param( [string]$p1 ) write-host "`$p1 = $p1" } $x = 1 A $x

In the example code from the OP, there's only one parameter in the function. It has no stated position in the parameter list. That give it, by default, position zero. Passing a parameter value by position is perfectly acceptable.

Share via

Powershell parameters

1 answer

Your answer