wpf relativesource binding in style datatemplate not working

essamce 621

hi, my .Net Framework wpf app, xaml binding doesn't work, here is the code:

<UserControl
    x:Class="SegSolution.UI.Views.DocumentNavigationView"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:data="clr-namespace:SegSolution.Data;assembly=SegSolution.Data"
    xmlns:models="clr-namespace:SegSolution.UI.Models"
    xmlns:vm="clr-namespace:SegSolution.UI.ViewModels" 
    xmlns:local="clr-namespace:SegSolution.UI.Views">

    <UserControl.DataContext>
        <Binding />
        <!-- temp -->
        <!--<vm:DocumentNavigationViewModel/>-->
    </UserControl.DataContext>
    
    <UserControl.Resources>
        <ResourceDictionary>
            <ResourceDictionary.MergedDictionaries>
                <ResourceDictionary Source="pack://application:,,,/SegSolution.UI;component/themes/generic.xaml" />
            </ResourceDictionary.MergedDictionaries>
            <Style TargetType="{x:Type TreeViewItem}" 
                   BasedOn="{StaticResource CurrentTheme.Control}">
                <!--<Setter Property="IsExpanded" Value="True" />-->
                <Setter Property="Background" Value="Transparent" />
                <Setter Property="VerticalAlignment" Value="Top" />
            </Style>

            <Style x:Key="this.treeViewItemTemplate" TargetType="TextBlock">
                <Setter Property="Background" Value="Transparent" />
                <Setter Property="FontSize" Value="14" />
                <Setter Property="Text" Value="{Binding Path=Name}" />
                <Setter Property="ContextMenu" >
                    <Setter.Value>
                        <ContextMenu  >
                            <MenuItem Header="Select" 
                                Command="{Binding DataContext.SelectAcadObjCmd, RelativeSource={RelativeSource AncestorType=UserControl}}"
                                CommandParameter="{Binding}" />
                            <MenuItem Header="Zoom To" IsEnabled="False" />
                        </ContextMenu>
                    </Setter.Value>
                </Setter>
           
            </Style>
            <!-- DataType="{x:Type models:SegPartData}"-->
            <!--DataType="{x:Type models:SegUCSData}"-->
            <HierarchicalDataTemplate x:Key="this.treeviewTemplate"
                                     
                ItemsSource="{Binding Path=UCSs}"  >
                <TextBlock Style="{StaticResource this.treeViewItemTemplate}"
                    Margin="0 8 0 0" >
                    <TextBlock.RenderTransform>
                        <TranslateTransform Y="-4" />
                    </TextBlock.RenderTransform>
                </TextBlock>
                <HierarchicalDataTemplate.ItemTemplate >
                    <DataTemplate >
                        <TextBlock Style="{StaticResource this.treeViewItemTemplate}" />
                    </DataTemplate>
                </HierarchicalDataTemplate.ItemTemplate>
            </HierarchicalDataTemplate>
            
        </ResourceDictionary>
    </UserControl.Resources>
    

    
    <Grid Margin="5">
        <Grid.RowDefinitions>
            <RowDefinition Height="25"/>
            <RowDefinition Height="*"/>
        </Grid.RowDefinitions>
        <Grid Grid.Row="0" >
            <Grid.ColumnDefinitions>
                <ColumnDefinition Width="*" />
                <ColumnDefinition Width="30" />
            </Grid.ColumnDefinitions>
            
            <TextBox Grid.Column="0" 
                Text="{Binding DocName}" 
                ToolTip="{Binding FullDocName}"
                FontSize="14" IsReadOnly="True"
                     BorderThickness="0"
                     Foreground="White"
                     Background="Transparent"/>
            <Button Grid.Column="1" 
                Command="{Binding RefreshCmd}"
                ToolTip="Refresh/reload data..."
                Content="R" />
        </Grid>

        <TreeView Grid.Row="1" 
                 
            Background="Transparent" Margin="0 10 0 0"
            BorderThickness="0" 
            VerticalAlignment="Stretch"
            ItemsSource="{Binding PartsData}" 
            ItemTemplate="{StaticResource this.treeviewTemplate}"/>
        
    </Grid>
</UserControl>

the problem in line :

<MenuItem Header="Select" 
                                Command="{Binding DataContext.SelectAcadObjCmd, RelativeSource={RelativeSource AncestorType=UserControl}}"
                                CommandParameter="{Binding}" />

essamce 621 Reputation points

2023-08-30T22:35:17.36+00:00

every binding works fine except for this binding
Hui Liu-MSFT 46,961 Reputation points Microsoft Vendor

2023-08-31T01:49:45.1866667+00:00

Hi,@essamce. Welcome Microsoft Q&A. Could you show me the complete code (including SelectAcadObjCmd and PartsData) that can reproduce your problem and analyze it? And what is the screenshot of the result of your problem?
essamce 621 Reputation points

2023-08-31T02:11:39.4+00:00

PartsData is an ObservableCollection of Class X, the problem is SelectAcadObjCmd defined in the main vm that contains PartsData property, and when I move SelectAcadObjCmd to X class works fine, but I don't want SelectAcadObjCmd to be in X class I wants all TreeItems to use one Cmd that exists in main vm that contains PartsData prop
Hui Liu-MSFT 46,961 Reputation points Microsoft Vendor

2023-08-31T05:21:02.1766667+00:00

Hi,@essamce. Is it possible to show me the minimal sample code that can reproduce the problem and analyze it?

essamce 621

@Hui Liu-MSFT

here is the rest of the code:

    public class ViewModelBase : INotifyPropertyChanged
    {
       

        #region INotifyPropertyChanged
        public event PropertyChangedEventHandler PropertyChanged;
        public void OnPropertyChanged(string propName)
           => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propName));
        public void OnPropertyChanged([System.Runtime.CompilerServices.CallerMemberName] string propName = "", char _ = '.')
          => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propName));
        // we use (char _ = '.') just to change mehtod signature
        #endregion INotifyPropertyChanged

    }


public class DocumentNavigationViewModel : ViewModelBase
{
    #region full props      
    private string _fullDocName;
    public string FullDocName
    {
        get => _fullDocName;
        set
        {
            _fullDocName = value;
            OnPropertyChanged();
        }
    }
    private string _docName;
    public string DocName
    {
        get => _docName;
        set
        {
            _docName = value;
            OnPropertyChanged();
        }
    }
    #endregion

    #region ctor

    public ObservableCollection<SegSolution.UI.Models.SegPartData> PartsData { get; set; }
    public RelayCommand<object> RefreshCmd { get; }
    public RelayCommand<object> SelectAcadObjCmd { get; }
    public RelayCommand<object> ZoomToAcadObjCmd { get; }

    public DocumentNavigationViewModel(SegSolution.Data.GUI.Abstractions.IGuiMessaging gui_Messaging, IGUIMainViewModel mainViewModel)
        : base(gui_Messaging, mainViewModel)
    {
        DocName = "no doc";
        PartsData = new ObservableCollection<SegSolution.UI.Models.SegPartData>();

        // commands
        RefreshCmd = new RelayCommand<object>(OnRefresh);
        SelectAcadObjCmd = new RelayCommand<object>(OnSelectAcadObj);
        ZoomToAcadObjCmd = new RelayCommand<object>(OnZoomToAcadObj);
    }

    #endregion

    #region right click handles

    private void OnSelectAcadObj(object param)
    {
    }
    private void OnZoomToAcadObj(object param)
    {
    }

    #endregion  

}

public class SegPartData 
{
    public string Name { get; set; }
    public ObservableCollection<SegUCSData> UCSs { get; private set; }

}

public class SegUCSData 
{
    public string Name { get; set; }
}

essamce 621 Reputation points

2023-08-31T14:03:03.8+00:00

@Hui Liu-MSFT

all bindings works fine except for SelectAcadObjCmd, that's my only propblem
Hui Liu-MSFT 46,961 Reputation points Microsoft Vendor

2023-09-01T03:17:30.9+00:00

Hi,@essamce. I completed some of the code, but there were some that I couldn't complete.

Could you show me the relevant code of the following code to reproduce the problem?

public DocumentNavigationViewModel(SegSolution.Data.GUI.Abstractions.IGuiMessaging gui_Messaging, IGUIMainViewModel mainViewModel) : base(gui_Messaging, mainViewModel)

essamce 621

@Hui Liu-MSFT

namespace SegSolution.UI.ViewModels {     public class ViewModelBase2 : Utils.ViewModelBase     {         protected SegSolution.Data.GUI.Abstractions.IGuiMessaging guiMessaging;         protected IGUIMainViewModel mainVM;         public ViewModelBase2(SegSolution.Data.GUI.Abstractions.IGuiMessaging gui_Messaging, IGUIMainViewModel mainViewModel)         {             mainVM = mainViewModel;             guiMessaging = gui_Messaging;         }     } }

namespace SegSolution.Data.GUI.Abstractions
{
    public interface IGuiMessaging
    {
        IAcadApi AcadApi { get; }
        void OnGuiAction(object cmdAsEnum);

        string GetCurrentDocName();
        void ReloadDoc();
        IEnumerable<SegSolution.Data.Abstraction.IPart> GetParts();
        IEnumerable<SegSolution.Data.Abstraction.IUCS> GetUCSs();
    }
}

namespace SegSolution.UI
{
    public interface IGUIMainViewModel
    {
        void AddMessage(string msg);
        void ClearMessages();
    }
}

namespace SegSolution.Data.GUI.Abstractions
{
    public interface IAcadApi
    {
        void SelectEntity(long handle);
        

    }
}

public interface IUCS : ISegObj
    {
        long PartHandleValue { get; }
    }
    public interface IPart : ISegObj
    {

    }

Hui Liu-MSFT 46,961 Microsoft Vendor

Hi,@essamce. Please check if my code is different from yours, I can't reproduce your problem. If there are differences, please point out and update.

<UserControl x:Class="ResourceBindingDemo.UI.Views.DocumentNavigationView"
            ...
             xmlns:local="clr-namespace:ResourceBindingDemo.UI.Views"
             mc:Ignorable="d"                        
             d:DesignHeight="450" d:DesignWidth="800">
    <UserControl.DataContext>
        <Binding/>
       
    </UserControl.DataContext>

    <UserControl.Resources>
        <ResourceDictionary>
          

            <Style x:Key="treeViewItemTemplate" TargetType="TextBlock">
                <Setter Property="Background" Value="Pink" />
                <Setter Property="FontSize" Value="14" />
                <Setter Property="Text" Value="{Binding Path=Name}" />
                <Setter Property="ContextMenu" >
                    <Setter.Value>
                        <ContextMenu  >
                            <MenuItem Header="Select" 
                                Command="{Binding DataContext.SelectAcadObjCmd, RelativeSource={RelativeSource AncestorType=UserControl}}"
                                CommandParameter="{Binding}" />
                            <MenuItem Header="Zoom To" IsEnabled="False" />
                        </ContextMenu>
                    </Setter.Value>
                </Setter>

            </Style>
           
            <HierarchicalDataTemplate x:Key="treeviewTemplate"  ItemsSource="{Binding Path=UCSs}"  >
                <TextBlock Style="{StaticResource treeViewItemTemplate}"   Margin="0 8 0 0" >
                    <TextBlock.RenderTransform>
                        <TranslateTransform Y="-4" />
                    </TextBlock.RenderTransform>
                </TextBlock>
                <HierarchicalDataTemplate.ItemTemplate >
                    <DataTemplate >
                        <TextBlock Style="{StaticResource treeViewItemTemplate}" />
                    </DataTemplate>
                </HierarchicalDataTemplate.ItemTemplate>
            </HierarchicalDataTemplate>

        </ResourceDictionary>
    </UserControl.Resources>

    <Grid Margin="5">

        <TreeView    Background="LightBlue" Margin="0 10 0 0"   VerticalAlignment="Stretch"   ItemsSource="{Binding PartsData}"    ItemTemplate="{StaticResource treeviewTemplate}"/>

    </Grid>
</UserControl>

Codebedhind:

   public partial class DocumentNavigationView : UserControl
    {
        public DocumentNavigationView()
        {
            InitializeComponent();
           
        }
    }
    public class ViewModelBase : INotifyPropertyChanged
    {


        #region INotifyPropertyChanged
        public event PropertyChangedEventHandler PropertyChanged;
        public void OnPropertyChanged(string propName)
           => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propName));
        public void OnPropertyChanged([System.Runtime.CompilerServices.CallerMemberName] string propName = "", char _ = '.')
          => PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propName));
        // we use (char _ = '.') just to change mehtod signature
        #endregion INotifyPropertyChanged

    }
    public interface IGuiMessaging
    {
        IAcadApi AcadApi { get; }
        void OnGuiAction(object cmdAsEnum);

        string GetCurrentDocName();
        void ReloadDoc();
        IEnumerable<IPart> GetParts();
        IEnumerable<IUCS> GetUCSs();
    }
    public interface IUCS : ISegObj
    {
        long PartHandleValue { get; }
    }

    public interface ISegObj
    {
    }

    public interface IPart : ISegObj
    {

    }
    public interface IGUIMainViewModel
    {
        void AddMessage(string msg);
        void ClearMessages();
    }
    public interface IAcadApi
    {
        void SelectEntity(long handle);


    }
    public class ViewModelBase2 : ViewModelBase 
    {   
        protected IGuiMessaging guiMessaging; 
        protected IGUIMainViewModel mainVM; 
        public ViewModelBase2(IGuiMessaging gui_Messaging, IGUIMainViewModel mainViewModel) 
        { 
            mainVM = mainViewModel; guiMessaging = gui_Messaging;
        } 
    } 
    public class DocumentNavigationViewModel : ViewModelBase2
    {
        #region full props      
        private string _fullDocName;
        public string FullDocName
        {
            get => _fullDocName;
            set
            {
                _fullDocName = value;
                OnPropertyChanged();
            }
        }
        private string _docName;
        public string DocName
        {
            get => _docName;
            set
            {
                _docName = value;
                OnPropertyChanged();
            }
        }
        #endregion

        #region ctor

        public ObservableCollection<SegPartData> PartsData { get; set; }
        public RelayCommand<object> RefreshCmd { get; }
        public RelayCommand<object> SelectAcadObjCmd { get; }
        public RelayCommand<object> ZoomToAcadObjCmd { get; }

        public DocumentNavigationViewModel(IGuiMessaging gui_Messaging, IGUIMainViewModel mainViewModel)  : base(gui_Messaging, mainViewModel)
        {
            DocName = "no doc";
            PartsData = new ObservableCollection<SegPartData>() { new SegPartData() { Name="name1"}, new SegPartData() { Name = "name12" }, };
         
      // commands
      RefreshCmd = new RelayCommand<object>(OnRefresh);
            SelectAcadObjCmd = new RelayCommand<object>(OnSelectAcadObj);
            ZoomToAcadObjCmd = new RelayCommand<object>(OnZoomToAcadObj);
        }

        private void OnRefresh(object obj)
        {
            throw new NotImplementedException();
        }

        #endregion

        #region right click handles

        private void OnSelectAcadObj(object param)
        {
            MessageBox.Show("test");
        }
        private void OnZoomToAcadObj(object param)
        {
        }

        #endregion

    }
    public class SegPartData
    {
        public string Name { get; set; }
        public ObservableCollection<SegUCSData> UCSs { get; private set; }

    }
    public class SegUCSData
    {
        public string Name { get; set; }
    }



    public class RelayCommand<T> : ICommand
    {
        private readonly Action<T> _execute;
        private readonly Predicate<T> _canExecute;

        public RelayCommand(Action<T> execute)
            : this(execute, null)
        {
        }

        public RelayCommand(Action<T> execute, Predicate<T> canExecute)
        {
            _execute = execute ?? throw new ArgumentNullException(nameof(execute));
            _canExecute = canExecute;
        }

        public event EventHandler CanExecuteChanged
        {
            add
            {
                if (_canExecute != null)
                {
                    CommandManager.RequerySuggested += value;
                }
            }
            remove
            {
                if (_canExecute != null)
                {
                    CommandManager.RequerySuggested -= value;
                }
            }
        }

        public bool CanExecute(object parameter)
        {
            return _canExecute == null || _canExecute((T)parameter);
        }

        public void Execute(object parameter)
        {
            _execute((T)parameter);
        }
    }

MainWindow.xaml:

<Window x:Class="ResourceBindingDemo.MainWindow"
      
       ...
        xmlns:local="clr-namespace:ResourceBindingDemo"
        xmlns:uc="clr-namespace:ResourceBindingDemo.UI.Views"
        mc:Ignorable="d"                     
        Title="MainWindow" Height="450" Width="800">
    <Grid>
        <uc:DocumentNavigationView Width="300" Height="300" />
    </Grid>
</Window>

essamce 621 Reputation points

2023-09-01T10:14:59.4133333+00:00

my project is a dll (wpf .Net Framework 4.8 class library ) not .exe, and it consumed by another wpf .Net Framework app
Hui Liu-MSFT 46,961 Reputation points Microsoft Vendor

2023-09-04T06:24:15.2533333+00:00

Hi,@essamce. I cannot determine your project structure. Could you share with me the link to your minimal sample project (uploaded to GitHub) that can reproduce the problem for analysis?
essamce 621 Reputation points

2023-09-06T12:20:00.2+00:00

@Hui Liu-MSFT

Hi,@essamce. I cannot determine your project structure. Could you share with me the link to your minimal sample project (uploaded to GitHub) that can reproduce the problem for analysis?

yes if you can send me your email cuz it's hard to share the project here.
Hui Liu-MSFT 46,961 Reputation points Microsoft Vendor

2023-09-07T07:37:05.75+00:00

Hi,@essamce. Mail cannot be used due to policy. You could upload your sample project to GitHub and then share its link with me.

Share via

wpf relativesource binding in style datatemplate not working