Build a Message

Question

Hi Friends. I have this method with a lot of if statements in it but I want to see if I can be more efficient in building my message. I'm just trying to get tips on how to make my code more terse and efficient. But I don't want a newline if the message is empty. Thanks !!!

public static bool Validation(AccountRequest request)
{

string message="";
string errmessage="";
 if (!Regex.IsMatch(request.Password, @"^(?=.*[A-Z])(?=.*[a-z])(?=.*\d).{10,128}$"))
{
  if(message=="")
      {
        errmessage="Bad Password";
        message=message + errmessage;
       }
    else
      {
       errmessage="Bad Password";
       message=message + Environment.NewLine + errmessage;
      }
}

Answer 1

Try this approach:

string message = "";

if( ... ) message += Environment.NewLine + "Bad Password";
if( ... ) message += Environment.NewLine + "Bad Username";
if( ... ) message += Environment.NewLine + "Bad E-mail";
. . .

if( message != "" ) message = message.Substring( Environment.NewLine.Length );

return message == "";

Or this:

string message = "";

if( ... ) message += "Bad Password" + Environment.NewLine;
if( ... ) message += "Bad Username" + Environment.NewLine;
if( ... ) message += "Bad e-mail" + Environment.NewLine;
. . .

return message == "";