Execution Timeout Expired In MVC5

Question

Execution Timeout Expired In MVC5

AHSAN ALI 101

i am getting this error when is use more then two operation in transaction scope. When i run this code without transaction its working fine .in transaction its gives error in _bookingViasServices.Save method _unitOfWork.SaveChanges();

public bool Edit(Booking booking, List<BookingVia> listOfBookingVias)
        {
            _unitOfWork.BeginTransaction();
            try
            {
                _bookingRepository.Update(booking);
               
                var lastInsertedRecordID = booking.ID;

                foreach (var itemVia in listOfBookingVias)
                {
                    itemVia.BookingID = lastInsertedRecordID;
                }
               var isAllRecordDeleted= _bookingViasSerivces.DeleteViasByBookingId(lastInsertedRecordID);
                _unitOfWork.SaveChanges();
                if (isAllRecordDeleted)
                {
                   
                    var isSaved= _bookingViasSerivces.Save(listOfBookingVias); 


                    if(isSaved)
                    {
                        _unitOfWork.Commit();
                        return true;
                    }
                    else
                    {
                        _unitOfWork.Rollback();
                        return false;
                    }
                   
                }
                else
                {
                   // _unitOfWork.Rollback();
                    return false;
                }
               

               
            }
            catch (Exception)
            {
                _unitOfWork.Rollback();
                return false;
            }
        }

this is bookingViasServices save methode

 public bool Save(List<BookingVia> listOfBookingVias)
        {
            try
            {
                _bookingViaRepository.AddRange(listOfBookingVias);
                _unitOfWork.SaveChanges();  
                return true;
            }
            catch (Exception)
            {

                return false;
            }
        }

AgaveJoe 31,361 Reputation points

2023-10-21T12:08:07.5133333+00:00

The symptom sounds like deadlock. That points to a buggy unit of work design/implementation.

Looking at the code there are two different saves in the same scope of work. That's not how a unit of work pattern is supposed function. A unit of work pattern commits all the inserts, updates, and deletes at one time.

The community cannot see the actual unit of work implementation but if you wrote a unit of work on top of Entity Framework which is also a unit of work pattern then I recommend rethinking what you're doing. A better approach is an API or a service pattern which simply means designing a block of business logic to solve a use case.
AHSAN ALI 101 Reputation points

2023-10-22T19:36:47.73+00:00

@AgaveJoe thanks for guiding me i solved this issue by remove first savechanges .

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .
AgaveJoe 1,510 Reputation points

2023-10-23T00:01:05.1433333+00:00

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .

It sounds like you still have bugs in the the unit of work design. You did not share the implementation so the community can only guess what's wrong with the design.
Lan Huang-MSFT 30,221 Reputation points Microsoft External Staff

2023-10-23T08:03:43.25+00:00

Hi @AHSAN ALI,

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .

Can you elaborate on your problem? Doesn't the content saved in your Save method have anything to do with the master detail record? Are they different tables?

Have you currently implemented inserting a master detail record but don't know how to use it within a transaction?

AHSAN ALI 101

@Lan Huang-MSFT @AgaveJoe

i want to use transaction in booking service for update booking record and adding booking vias

public interface IUnitOfWork
{
    void BeginTransaction();
    IRepository<TEntity> GetRepository<TEntity>() where TEntity : class;
    void SaveChanges();
    void Commit();
    void Rollback();
}

 public interface IRepository<TEntity> where TEntity : class
 {
     List<TEntity> GetAll(ISpecification<TEntity> specification = null);
     TEntity FirstOrDefault(ISpecification<TEntity> specification = null);
     TEntity GetById(int id);

     void Add(TEntity entity);
     void AddRange(IEnumerable<TEntity> entities);
     void Update(TEntity entity);
     void Update(TEntity entity, params Expression<Func<TEntity, object>>[] excludeColumns);
     void Delete(TEntity entity);
     void DeleteRange(IEnumerable<TEntity> entities);
     void UpdateRange(IEnumerable<TEntity> entities);
 }

    public class EfRepository<TEntity> : IRepository<TEntity> where TEntity : class
    {
        private readonly CabConnectEntities _context;
        private readonly DbSet<TEntity> _entities;

        public EfRepository(CabConnectEntities context)
        {
            _context = context;
            _entities = _context.Set<TEntity>();
        }

        public List<TEntity> GetAll(ISpecification<TEntity> specification = null)
        {
            if (specification != null)
            {
                return _entities.Where(specification.Criteria).ToList();
            }
            return _entities.ToList();
        }
        public TEntity FirstOrDefault(ISpecification<TEntity> specification = null)
        {
            if (specification != null)
            {
                return _entities.FirstOrDefault(specification.Criteria);
            }
            return null; // or throw an exception or handle the case where no specification is provided
        }
        public TEntity GetById(int id)
        {
            return _entities.Find(id);
        }

        public void Add(TEntity entity)
        {
            _entities.Add(entity);


        }

        public void Update(TEntity entity)
        {
            _entities.Attach(entity);
            _context.Entry(entity).State = EntityState.Modified;

        }

        public void Delete(TEntity entity)
        {
            _entities.Remove(entity);

        }

        public void AddRange(IEnumerable<TEntity> entities)
        {
           
            _context.Set<TEntity>().AddRange(entities);
        }

        public void DeleteRange(IEnumerable<TEntity> entities)
        {

            _context.Set<TEntity>().RemoveRange(entities);
        }
        public void UpdateRange(IEnumerable<TEntity> entities)
        {
            foreach (var entity in entities)
            {
                _entities.Attach(entity);
                _context.Entry(entity).State = EntityState.Modified;
            }
        }

        public void Update(TEntity entity, params Expression<Func<TEntity, object>>[] excludeColumns)
        {
            _entities.Attach(entity);
            _context.Entry(entity).State = EntityState.Modified;

            var entry = _context.Entry(entity);

            foreach (var excludeColumn in excludeColumns)
            {
                if (excludeColumn.Body is MemberExpression memberExpression)
                {
                    string propertyName = memberExpression.Member.Name;
                    entry.Property(propertyName).IsModified = false;
                }
                else if (excludeColumn.Body is UnaryExpression unaryExpression)
                {
                    if (unaryExpression.Operand is MemberExpression operand)
                    {
                        string propertyName = operand.Member.Name;
                        entry.Property(propertyName).IsModified = false;
                    }
                }
                else
                {
                    throw new ArgumentException("Excluded columns must be properties.");
                }
            }
        }
    }

    public class EFUnitOfWork : IUnitOfWork
    {
        private readonly CabEntities _dbContext;
        public DbContextTransaction _transaction { get; private set; }

        public EFUnitOfWork(CabEntities dbContext)
        {
            _dbContext = dbContext;
        }

        public void BeginTransaction()
        {
            _transaction = _dbContext.Database.BeginTransaction();
        }

        public void SaveChanges()
        {
            
            _dbContext.SaveChanges();
        }

        public IRepository<TEntity> GetRepository<TEntity>() where TEntity : class
        {
            return new EfRepository<TEntity>(_dbContext);
        }

        public void Rollback()
        {
            if (_transaction != null)
            {
                _transaction.Rollback();
                _transaction.Dispose();
            }
        }

        public void Commit()
        {
            if (_transaction != null)
            {
                _transaction.Commit();
                _transaction.Dispose();
            }
        }
    }


private readonly IRepository<BookingVia> _bookingViaRepository;
private readonly IUnitOfWork _unitOfWork;
public BookingViasSerivces(IRepository<BookingVia> bookingViaRepository, IUnitOfWork unitOfWork)
{
    _unitOfWork=unitOfWork;
    _bookingViaRepository= _unitOfWork.GetRepository<BookingVia>();
}

 private readonly IRepository<Booking> _bookingRepository;
 private readonly IBookingViasSerivces _bookingViasSerivces;
 private readonly IUnitOfWork _unitOfWork;
 public BookingService(IRepository<Booking> bookingRepository, IUnitOfWork unitOfWork, IBookingViasSerivces bookingViasSerivces)
 {
     _unitOfWork = unitOfWork;
     _bookingRepository = _unitOfWork.GetRepository<Booking>();
     _bookingViasSerivces= bookingViasSerivces;
    
 }

Lan Huang-MSFT 30,221 Microsoft External Staff

Hi @AHSAN ALI,

Do you want to implement transactions in the service layer? Is it similar to the one below?

public void updateProject(updateProjectRequest updateProjectRequest)
            {

            using (TransactionScope scope = new TransactionScope())
                    {

                       // these operations are atomic since they below to same transactionscope
                        projectRepository.Add([project]);
                        taskRepository.Add([tasks]);
                        // data will not be affected until complete operation is called. Any database exception would rollback the transaction.
                        scope.Complete();
                    }

              }

You can check if the link below helps.

Transaction with the Repository Design patterns

How to manage transactions in the service layer

AHSAN ALI 101 Reputation points

2023-10-25T13:27:16.4966667+00:00

@Lan Huang-MSFT yes, transaction scope is working fine, what is the difference between transaction scope and I unit of work which is in my code. Why the transaction of scope is working and the one I was trying to use is not working?

Answer accepted by question author

0 additional answers

Your answer

AgaveJoe 31,361 Reputation points

2023-10-21T12:08:07.5133333+00:00

The symptom sounds like deadlock. That points to a buggy unit of work design/implementation.

Looking at the code there are two different saves in the same scope of work. That's not how a unit of work pattern is supposed function. A unit of work pattern commits all the inserts, updates, and deletes at one time.

The community cannot see the actual unit of work implementation but if you wrote a unit of work on top of Entity Framework which is also a unit of work pattern then I recommend rethinking what you're doing. A better approach is an API or a service pattern which simply means designing a block of business logic to solve a use case.
AHSAN ALI 101 Reputation points

2023-10-22T19:36:47.73+00:00

@AgaveJoe thanks for guiding me i solved this issue by remove first savechanges .

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .
AgaveJoe 1,510 Reputation points

2023-10-23T00:01:05.1433333+00:00

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .

It sounds like you still have bugs in the the unit of work design. You did not share the implementation so the community can only guess what's wrong with the design.
Lan Huang-MSFT 30,221 Reputation points Microsoft External Staff

2023-10-23T08:03:43.25+00:00

Hi @AHSAN ALI,

but i am confused how can i insert master detail record using this transaction because i need to get inserted record id for its details items .

Can you elaborate on your problem? Doesn't the content saved in your Save method have anything to do with the master detail record? Are they different tables?

Have you currently implemented inserting a master detail record but don't know how to use it within a transaction?
Lan Huang-MSFT 30,221 Reputation points Microsoft External Staff

2023-10-24T07:56:45.4333333+00:00

Hi @AHSAN ALI,

Do you want to implement transactions in the service layer? Is it similar to the one below?

public void updateProject(updateProjectRequest updateProjectRequest) { using (TransactionScope scope = new TransactionScope()) { // these operations are atomic since they below to same transactionscope projectRepository.Add([project]); taskRepository.Add([tasks]); // data will not be affected until complete operation is called. Any database exception would rollback the transaction. scope.Complete(); } }

You can check if the link below helps.

Transaction with the Repository Design patterns

How to manage transactions in the service layer
AHSAN ALI 101 Reputation points

2023-10-25T13:27:16.4966667+00:00

@Lan Huang-MSFT yes, transaction scope is working fine, what is the difference between transaction scope and I unit of work which is in my code. Why the transaction of scope is working and the one I was trying to use is not working?

Answer 1

Hi @AHSAN ALI,

You were using Database.BeginTransaction() before. While Database. BeginTransaction() is used only for database related operations transaction, System.Transactions.TransactionScope for mixing db operations and C# code together in a transaction.

From MSDN:

The System.Transactions infrastructure provides both an explicit programming model based on the Transaction class, as well as an implicit programming model using the TransactionScope class, in which transactions are automatically managed by the infrastructure.

The TransactionScope class provides a simple way to mark a block of code as participating in a transaction, without requiring you to interact with the transaction itself.

Useful links:

Database.BeginTransaction vs Transactions.TransactionScope

Implementing an Implicit Transaction using Transaction Scope

Best regards,
Lan Huang

If the answer is the right solution, please click "Accept Answer" and kindly upvote it. If you have extra questions about this answer, please click "Comment".
Note: Please follow the steps in our documentation to enable e-mail notifications if you want to receive the related email notification for this thread.

Share via

Execution Timeout Expired In MVC5

0 additional answers

Your answer