Brah, sub-classed WM_PAINT call to ::DrawFrameControl() with ListView's default call to ::CallWindowProcW() No-Diggity!

Question

Brah, sub-classed WM_PAINT call to ::DrawFrameControl() with ListView's default call to ::CallWindowProcW() No-Diggity!

Anne Wilcoxen 46

Golly-plops & turtle tops!
I’ve sub-classed a ListView with the intent of making it into my own TreeView! Jeepers!
I want it to draw this, but with the TreeView + and - marks on the left side:
User's image

To that end I’ve crafted up the following code inside the sub-class routine:

			case WM_PAINT : {
 				RECT clientRect;
 				GetClientRect(_hWnd, &clientRect);
   				PAINTSTRUCT ps;
 				HDC hdc = BeginPaint(_hWnd, &ps);
  				// Create a compatible memory DC and bitmap
 				HDC memDC = CreateCompatibleDC(hdc);
 				HBITMAP memBitmap = CreateCompatibleBitmap(hdc, clientRect.right, clientRect.bottom);
 				HBITMAP oldBitmap = (HBITMAP)SelectObject(memDC, memBitmap);
  				  				// Now do your custom drawing on memory DC
 				RECT rcButton = {10, 50, 30, 70};
 				DrawFrameControl(memDC, &rcButton, DFC_BUTTON, DFCS_BUTTONCHECK);
  				// Call the original window procedure to draw into memory DC
   				LRESULT lrRes = CallWindowProcW(wpOrig, _hWnd, _uMsg, _wParam, (LPARAM)memDC); 
  				// Blit the memory DC to screen
 				BitBlt(hdc, ps.rcPaint.left, ps.rcPaint.top, ps.rcPaint.right - ps.rcPaint.left,
 					   ps.rcPaint.bottom - ps.rcPaint.top, memDC, ps.rcPaint.left, ps.rcPaint.top, SRCCOPY);

 				// Clean up
  				SelectObject(memDC, oldBitmap);
  				DeleteObject(memBitmap);
 				DeleteDC(memDC);
  				EndPaint(_hWnd, &ps);
 				return lrRes;
  			}

But instead of my dreams, I get this:
User's image

Jumpin’ Jehoshaphat!

The first issue is: What on Earth could be wrong, Daddy-O?
And the 2nd issue is: I want to draw the TreeView + and - but they are not defined. Is DFCS_BUTTONPLUS a thing? I’m only using DFCS_BUTTONCHECK for testing.

1 answer

Your answer

Answer 1

Castorix31 90,681

In your code, you replace the default drawing with your Button

To draw above the default drawing, you can use Custom Draw

+/- is drawn with DrawThemeBackground when themed (TVP_GLYPH, ...) or manually with PatBlt when not themed

Or you can use the TreeList control from rasdlg.dll :

TreeList

Anne Wilcoxen 46 Reputation points

2023-12-17T11:14:39.4666667+00:00

It seems you answered with rasdlg.dll last time I asked this question long long ago. I couldn’t find my old post because I couldn’t remember any of the search terms but it just showed up.

But I can’t find anything about TreeList in “rasdlg”. I see phone books and dial services. I don’t want any of that junk in my project. Where is this TreeList? What header?

L. Spiro
Castorix31 90,681 Reputation points

2023-12-17T12:35:26.29+00:00

I could find and post a test code, but it is an old control (it uses an Owner-Drawn ListView)

I think it should be better with Custom Draw (CDDS_ITEMPOSTPAINT to draw after the original drawing)
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-12-18T05:42:21.3+00:00

Maybe the sample Win32 Editable TreeView and ListView Merged as One is useful to you.
Anne Wilcoxen 46 Reputation points

2023-12-18T09:33:43.13+00:00

That example sure does a lot of manual drawing of the ListView part. I’m going to be able to just add the +/- section and then let the items draw normally, right? I expect I will have to validate some section or something?

L. Spiro
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-12-19T08:35:03.9+00:00

As @Castorix31 said, It's TVP_GLYPH part, GLPS_CLOSED, GLPS_OPENED state for TreeView.
Anne Wilcoxen 46 Reputation points

2023-12-19T09:26:01.1933333+00:00

I know. The example manually draws a lot of the ListView. If I am manually drawing the +/- of the TreeView using DrawThemeBackground() inside CDDS_ITEMPOSTPAINT, I would still like the ListView part to draw itself. Unlike in that example.
Can this be done or do I have to manually draw the ListView part as in the example?
Xiaopo Yang - MSFT 12,731 Reputation points Microsoft External Staff

2023-12-20T02:48:14.07+00:00

Let TreeView draw itself before drawing +/-. And could you please provide a minimal sample?

Anne Wilcoxen 46

For now, just because working in this area of code is easier than where I will need to put everything later, I am temporarily just trying to demonstrate the concept by working on the header of my TreeList (I have only a ListView and a Header, no TreeView).

			case WM_NOTIFY : {
				LPNMHDR lpnmhdr = (LPNMHDR)_lParam;
				if (lpnmhdr->code == NM_CUSTOMDRAW) {
					LPNMLVCUSTOMDRAW lpLVCD = (LPNMLVCUSTOMDRAW)_lParam;

					switch (lpLVCD->nmcd.dwDrawStage) {
						case CDDS_PREPAINT:
							return CDRF_NOTIFYITEMDRAW;

						case CDDS_ITEMPREPAINT: {
							static bool _bInPrePaint = false;

							if ( !_bInPrePaint ) {
								_bInPrePaint = true;
								::InvalidateRect( _hWnd, &lpLVCD->nmcd.rc, FALSE );
								::SendMessageW( lpLVCD->nmcd.hdr.hwndFrom, WM_PAINT, 0, 0 );
								::ValidateRect( _hWnd, &lpLVCD->nmcd.rc );
								_bInPrePaint = false;
							}
							else {
								return CDRF_DODEFAULT;
							}
							HTHEME hTheme = ::OpenThemeData(_hWnd, L"TREEVIEW");
							if (hTheme) {
								
								RECT rc = lpLVCD->nmcd.rc;
								rc.right = rc.left + 20;
								int partId = TVP_GLYPH;
								int stateId = GLPS_OPENED; // or GLPS_CLOSED for "+"

								::InvalidateRect( _hWnd, &rc, FALSE );
								::DrawThemeBackground(hTheme, lpLVCD->nmcd.hdc, partId, stateId, &rc, NULL);
								::ValidateRect( _hWnd, &rc );



								::CloseThemeData(hTheme);
							}
							//return CDRF_DODEFAULT;
							return CDRF_SKIPDEFAULT;
						}
					}
				}
				break;
			}

The reason for _bInPrePaint is that when I call WM_PAINT on the header it goes back into CDDS_ITEMPREPAINT and stack-overflows. I created a bunch of variations of this code but I am never able to get the +/- to appear with the default Header render.

User's image

I either get the - or the header text. There doesn’t seem to be a way to let the Header draw itself and then inject my +/- over it.

L. Spiro

Share via

Brah, sub-classed WM_PAINT call to ::DrawFrameControl() with ListView's default call to ::CallWindowProcW() No-Diggity!

1 answer

Your answer