Developer technologies | ASP.NET | ASP.NET Core
A set of technologies in the .NET Framework for building web applications and XML web services.
Code Refactor
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(73.60000000000001, 25%, 17%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EAY%3C/text%3E%3C/svg%3E)
Ali Yılmaz
81
Reputation points
Hi,
Hello, if we want to rewrite this code again, how can we write it? I would be happy if you help.
public string GetCountOfFilesForCharts(FileCountForChartRequest req) { if (req.Type == FileCountType.Opened) { if (req.Grouping == FileCountGroup.Daily) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1) .Select(offset => req.StartDate.AddDays(offset)) .ToList(); var dailyLogCounts = dates.Select(cartcurt => new { Date = cartcurt, Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in dailyLogCounts) { sonuc += $"{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Weekly) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1) .Select(offset => req.StartDate.AddDays(offset * 7)) .ToList(); var weeklyLogCounts = dates.Select(weekStart => new { WeekStart = weekStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in weeklyLogCounts) { sonuc += $"Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Monthly) { var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1) .Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset)) .ToList(); var monthlyLogCounts = dates.Select(monthStart => new { MonthStart = monthStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= monthStart && fl.CreateDate < monthStart.AddMonths(1) && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in monthlyLogCounts) { sonuc += $"Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Yearly) { var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1) .Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset)) .ToList(); var yearlyLogCounts = dates.Select(yearStart => new { YearStart = yearStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= yearStart && fl.CreateDate < yearStart.AddYears(1) && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in yearlyLogCounts) { sonuc += $"Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } return ""; } if (req.Type == FileCountType.Closed) { if (req.Grouping == FileCountGroup.Daily) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1) .Select(offset => req.StartDate.AddDays(offset)) .ToList(); var dailyLogCounts = dates.Select(cartcurt => new { Date = cartcurt, Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in dailyLogCounts) { sonuc += $"{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Weekly) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1) .Select(offset => req.StartDate.AddDays(offset * 7)) .ToList(); var weeklyLogCounts = dates.Select(weekStart => new { WeekStart = weekStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in weeklyLogCounts) { sonuc += $"Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Monthly) { var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1) .Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset)) .ToList(); var monthlyLogCounts = dates.Select(monthStart => new { MonthStart = monthStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= monthStart && fl.CreateDate < monthStart.AddMonths(1) && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in monthlyLogCounts) { sonuc += $"Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Yearly) { var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1) .Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset)) .ToList(); var yearlyLogCounts = dates.Select(yearStart => new { YearStart = yearStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= yearStart && fl.CreateDate < yearStart.AddYears(1) && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach (var logCount in yearlyLogCounts) { sonuc += $"Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } } return ""; } }
Developer technologies | ASP.NET | ASP.NET Core
{count} votes
-
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(44.800000000000004, 13%, 14%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EJP%3C/text%3E%3C/svg%3E)
José Pablo Ramirez (a. k. a. webJose) 430 Reputation points Moderator2024-01-06T17:45:39.6666667+00:00 Edit your question to show the code in multiple lines. Impossible to review it as-is.
-
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(188.79999999999998, 98%, 28%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EDD%3C/text%3E%3C/svg%3E)
Dhruval Dave 0 Reputation points2024-01-10T10:25:06.6466667+00:00 Here is the formatted code, Looks like now it will be easy for the community to help.
public string GetCountOfFilesForCharts(FileCountForChartRequest req) { if (req.Type == FileCountType.Opened) { if (req.Grouping == FileCountGroup.Daily) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1).Select(offset => req.StartDate.AddDays(offset)).ToList(); var dailyLogCounts = dates.Select(cartcurt => new { Date = cartcurt, Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in dailyLogCounts) { sonuc += $ "{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Weekly) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1).Select(offset => req.StartDate.AddDays(offset * 7)).ToList(); var weeklyLogCounts = dates.Select(weekStart => new { WeekStart = weekStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in weeklyLogCounts) { sonuc += $ "Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Monthly) { var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1).Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset)).ToList(); var monthlyLogCounts = dates.Select(monthStart => new { MonthStart = monthStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= monthStart && fl.CreateDate < monthStart.AddMonths(1) && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in monthlyLogCounts) { sonuc += $ "Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Yearly) { var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1).Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset)).ToList(); var yearlyLogCounts = dates.Select(yearStart => new { YearStart = yearStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= yearStart && fl.CreateDate < yearStart.AddYears(1) && fl.StatusId == 1 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in yearlyLogCounts) { sonuc += $ "Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } return ""; } if (req.Type == FileCountType.Closed) { if (req.Grouping == FileCountGroup.Daily) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days + 1).Select(offset => req.StartDate.AddDays(offset)).ToList(); var dailyLogCounts = dates.Select(cartcurt => new { Date = cartcurt, Count = _fileLogService.Entities.Count(fl => fl.CreateDate <= cartcurt.Date.AddDays(1) && fl.CreateDate >= cartcurt.Date && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in dailyLogCounts) { sonuc += $ "{logCount.Date.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Weekly) { var dates = Enumerable.Range(0, (DateTime.Now - req.StartDate).Days / 7 + 1).Select(offset => req.StartDate.AddDays(offset * 7)).ToList(); var weeklyLogCounts = dates.Select(weekStart => new { WeekStart = weekStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate < weekStart.Date.AddDays(7) && fl.CreateDate >= weekStart.Date && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in weeklyLogCounts) { sonuc += $ "Hafta başı {logCount.WeekStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Monthly) { var dates = Enumerable.Range(0, (DateTime.Now.Year - req.StartDate.Year) * 12 + DateTime.Now.Month - req.StartDate.Month + 1).Select(offset => new DateTime(req.StartDate.Year, req.StartDate.Month, 1).AddMonths(offset)).ToList(); var monthlyLogCounts = dates.Select(monthStart => new { MonthStart = monthStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= monthStart && fl.CreateDate < monthStart.AddMonths(1) && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in monthlyLogCounts) { sonuc += $ "Ay başı {logCount.MonthStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } else if (req.Grouping == FileCountGroup.Yearly) { var dates = Enumerable.Range(0, DateTime.Now.Year - req.StartDate.Year + 1).Select(offset => new DateTime(req.StartDate.Year, 1, 1).AddYears(offset)).ToList(); var yearlyLogCounts = dates.Select(yearStart => new { YearStart = yearStart, Count = _fileLogService.Entities.Count(fl => fl.CreateDate >= yearStart && fl.CreateDate < yearStart.AddYears(1) && fl.StatusId == 10 && fl.FileId != 0) }); string sonuc = ""; foreach(var logCount in yearlyLogCounts) { sonuc += $ "Yıl başı {logCount.YearStart.ToShortDateString()}: {logCount.Count} adet dosya açıldı.\n"; } return sonuc; } } return ""; }
Sign in to comment
Sign in to answer