webservice service System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)

Xu Li 5

I am currently encountering an issue with a web service. The server-side field MinimumOrderAmount is of type double, and in my receiving program, I have defined it as decimal. When the server sends a value of 9999999999 for MinimumOrderAmount, my program throws an error with the following message:


Exception thrown passed to this Web service: System.InvalidOperationException: There is an error in XML document (1, 3998). ---> System.FormatException: Input string was not in a correct format.
at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
at System.Number.ParseDecimal(String value, NumberStyles options, NumberFormatInfo numfmt)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read13_VoucherDiscount(Boolean isNullable, Boolean checkType)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read90_RoomRate(Boolean isNullable, Boolean checkType)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read141_RoomStay(Boolean isNullable, Boolean checkType)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read142_AvailResponseSegment(Boolean isNullable, Boolean checkType)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read143_AvailabilityResponse(Boolean isNullable, Boolean checkType)
at Microsoft.Xml.Serialization.GeneratedAssembly.XmlSerializationReaderAvailabilityService.Read191_AvailabilityResponse()
at System.Xml.Serialization.XmlSerializer.Deserialize(XmlReader xmlReader, String encodingStyle, XmlDeserializationEvents events)

Theoretically, a double type should be able to be directly converted to a decimal type. Why does this conversion fail when the value is 9999999999, but succeeds when the value is 999999999 (9 digits)?

Lan Huang-MSFT 29,746 Microsoft Vendor

Hi @Xu Li,

Can you provide your code? I tried it briefly but couldn't reproduce the problem.

Did you accidentally specify "9999999999" as an int type?The int type is a signed 32-bit integer, while "9999999999" is a 64-bit integer. It is recommended to use the long type.

static void Main(string[] args)
 {
     CreateDecimal(9999999999, "9999999999");          
 }
 public static void CreateDecimal(double value, string valToStr)
 {
     decimal decimalNum = new decimal(value);
     // Format the constructor for display.
     string ctor = String.Format("decimal( {0} )", valToStr);
     // Display the constructor and its value.
     Debug.WriteLine("{0,-30}{1,16}", ctor, decimalNum);
 }

Xu Li 5

Hi @Lan Huang-MSFT ,

In the web service server, a method was published to query prices. This method includes a field named MinimumOrderAmount, which was defined as a double type on the server side. On my side, instead of using a tool to generate the code, I manually added the field and defined it as a decimal type.

When the server returns the following XML message:

xml

<VoucherDiscount voucherNo="24007-23178c98426a491b30fd7db155e16662" minimumOrderAmount="9999999999.0" currency="USD"> 
	<DiscountAmount currencyCode="USD" decimals="2">1000</DiscountAmount> 
	<TotalAfterDiscount currencyCode="USD" decimals="2">2721.66</TotalAfterDiscount> 		  <TotalTaxAfterDiscount currencyCode="USD" decimals="2">278.34</TotalTaxAfterDiscount> </VoucherDiscount>

I encountered an error while receiving this data.

Here is the code I used to receive the data:

[System.CodeDom.Compiler.GeneratedCodeAttribute("System.Xml", "4.0.30319.233")] [System.SerializableAttribute()] [System.Diagnostics.DebuggerStepThroughAttribute()] [System.ComponentModel.DesignerCategoryAttribute("code")] [System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://webservices.micros.com/og/4.3/HotelCommon/")] public partial class VoucherDiscount : VoucherDiscountBasic { [XmlAttribute("minimumOrderAmount")] public decimal MinimumOrderAmount { get; set; } public Amount DiscountAmount { get; set; } public Amount TotalAfterDiscount { get; set; } public Amount TotalTaxAfterDiscount { get; set; } }

Xu Li 5

Hi @Lan Huang-MSFT ,

When the server returns the following XML message:

<VoucherDiscount voucherNo="24007-23178c98426a491b30fd7db155e16662" minimumOrderAmount="9999999999.0" currency="USD"> 
	<DiscountAmount currencyCode="USD" decimals="2">1000</DiscountAmount> 
	<TotalAfterDiscount currencyCode="USD" decimals="2">2721.66</TotalAfterDiscount> 
	<TotalTaxAfterDiscount currencyCode="USD" decimals="2">278.34</TotalTaxAfterDiscount> 
</VoucherDiscount>

I encountered an error while receiving this data.

Here is the code I used to receive the data:


[System.CodeDom.Compiler.GeneratedCodeAttribute("System.Xml", "4.0.30319.233")]
[System.SerializableAttribute()]
[System.Diagnostics.DebuggerStepThroughAttribute()]
[System.ComponentModel.DesignerCategoryAttribute("code")]
[System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://webservices.micros.com/og/4.3/HotelCommon/")]
public partial class VoucherDiscount : VoucherDiscountBasic
{
    [XmlAttribute("minimumOrderAmount")]
    public decimal MinimumOrderAmount { get; set; }
    public Amount DiscountAmount { get; set; }
    public Amount TotalAfterDiscount { get; set; }
    public Amount TotalTaxAfterDiscount { get; set; }
}

Lan Huang-MSFT 29,746 Microsoft Vendor

Hi @Xu Li,Unfortunately, I still can't reproduce your problem. Could you provide the code for VoucherDiscountBasic ? Can you make it work with 99999999999 (9 digits)?

Maybe you could try changing public decimal MinimumOrderAmount { get; set; } to public double MinimumOrderAmount { get; set; } and test it.

The following is a simple test based on your code.

 static void Main(string[] args)
 {
     string path = "XMLFile1.xml";
     var serializer = new XmlSerializer(typeof(VoucherDiscount));
     using (StreamReader reader = new StreamReader(path))
     {
         var library = (VoucherDiscount)serializer.Deserialize(reader);
         Console.WriteLine(library.MinimumOrderAmount);
     }
 }
 [System.CodeDom.Compiler.GeneratedCodeAttribute("System.Xml", "4.0.30319.233")]
 [System.SerializableAttribute()]
 [System.Diagnostics.DebuggerStepThroughAttribute()]
 [System.ComponentModel.DesignerCategoryAttribute("code")]
 [System.Xml.Serialization.XmlTypeAttribute(Namespace = "http://webservices.micros.com/og/4.3/HotelCommon/")]
 public class VoucherDiscount
 {
     [XmlAttribute("minimumOrderAmount")]
     public decimal MinimumOrderAmount { get; set; }
 }

User's image

Xu Li 5 Reputation points

2024-07-05T09:49:12.5233333+00:00

Hi @Lan Huang-MSFT ,

I believe this issue might be related to how the .NET Framework parses the XML data returned by the web service. Since the framework automatically parses the XML data, when I changed the MinimumOrderAmount field to a double type, the issue did not occur. The VoucherDiscountBasic class only contains some property fields and should not be related to this issue. I am using .NET Framework 4.6.1.
Lan Huang-MSFT 29,746 Reputation points Microsoft Vendor

2024-07-08T02:05:04.57+00:00

Hi @Xu Li,

.NET Framework 4.6.1 has reached end of life, meaning it is no longer supported.

We recommend moving to a supported release, such as .NET Framework 4.8. See our support policy for more details.

when I changed the MinimumOrderAmount field to a double type, the issue did not occur.

Maybe you can try to set the MinimumOrderAmount field to double type first, then convert the resulting data to decimal type and see if the error occurs.
Xu Li 5 Reputation points

2024-07-08T03:23:24.13+00:00

Hi @Lan Huang-MSFT ,

I have a new discovery: when the server returns a numeric string like 9999999999, it gets converted to scientific notation (e.g., 9.99999999E7) when received on my side. This conversion happens because my client-side field is defined as decimal, while the server-side field is defined as double.

When I receive this data, it throws an error because the MinimumOrderAmount is converted to scientific notation. Specifically, the value 99999999 gets converted to 9.99999999E7, which leads to a Format_InvalidString exception.

Why does the numeric string get converted to scientific notation when the client-side field type is decimal and the server-side field type is double? Is this conversion caused by the type mismatch between the client and server, leading to a Format_InvalidString exception?
Lan Huang-MSFT 29,746 Reputation points Microsoft Vendor

2024-07-08T06:29:08.8133333+00:00

Hi @Xu Li,

I guess this is due to Standard numeric format strings.

https://learn.microsoft.com/en-us/dotnet/standard/base-types/standard-numeric-format-strings?redirectedfrom=MSDN

You can try to convert scientific notation to decimal.

decimal h2 = Decimal.Parse("9.9999999E7", NumberStyles.Float);

Or redefine the FormatStrings:

https://stackoverflow.com/questions/1546113/double-to-string-conversion-without-scientific-notation
Xu Li 5 Reputation points

2024-07-08T10:58:50.65+00:00

Hi @Lan Huang-MSFT ，

I understand your point, but I don't understand why the data returned by the web service is being converted to scientific notation. Is this conversion happening because the server-side field is defined as double and the client-side field is defined as decimal? I tested this using the .NET Framework 4.8 and encountered the same issue. Could this be a problem with how the framework handles web service data?
Lan Huang-MSFT 29,746 Reputation points Microsoft Vendor

2024-07-09T02:29:22.95+00:00

Hi @Xu Li,

I don't know if you have seen the document I posted above.

From the documentation it follows that the most compact form to represent the number will be chosen.

I.e., when you do not specify a format string, the default is the "G" format string. From the specification of the G format string follows:

Result: The most compact of either fixed-point or scientific notation.

Fixed-point notation is used if the exponent that would result from expressing the number in scientific notation is greater than -5 and less than the precision specifier; otherwise, scientific notation is used.