Foreach Loop only running last object

Question

Foreach Loop only running last object

CmoneyG 21

Hi! I am trying to work on an assignment for school creating new-adusers from a csv. but when i run my foreach loop it only runs the last object. Any help would be appreciated.

PS C:\windows\system32> ForEach ($ADUser in $NewUsers)
{

$First = $ADUsers.First_Name
$Last = $ADUsers.Last_Name
$Name = $First + " " + $Last
$post = $ADUser.PostalCode
$ophone = $ADUser.OfficePhone
$mphone = $ADUser.MobilePhone

New-ADUser -GivenName $Frist -Surname $Last -Name $Name -DisplayName $Name -OfficePhone $ophone -MobilePhone $mphone -PostalCode $post -Path $OU -Verbose
}
VERBOSE: Performing the operation "New" on target "CN=Kimbery Madarang,OU=Finance,DC=ucertify,DC=com".
VERBOSE: Performing the operation "New" on target "CN=Kimbery Madarang,OU=Finance,DC=ucertify,DC=com".
New-ADUser : The specified account already exists
At line:11 char:1

New-ADUser -GivenName $Frist -Surname $Last -Name $Name -DisplayName ...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo : ResourceExists: (CN=Kimbery Mada...ucertify,DC=com:String) [New-ADUser], ADIdentityAlreadyExistsException
FullyQualifiedErrorId : ActiveDirectoryServer:1316,Microsoft.ActiveDirectory.Management.Commands.NewADUser

VERBOSE: Performing the operation "New" on target "CN=Kimbery Madarang,OU=Finance,DC=ucertify,DC=com".
New-ADUser : The specified account already exists
At line:11 char:1

New-ADUser -GivenName $Frist -Surname $Last -Name $Name -DisplayName ...
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo : ResourceExists: (CN=Kimbery Mada...ucertify,DC=com:String) [New-ADUser], ADIdentityAlreadyExistsException
FullyQualifiedErrorId : ActiveDirectoryServer:1316,Microsoft.ActiveDirectory.Management.Commands.NewADUser

Accepted answer

1 additional answer

Your answer

Answer 1

Rich Matheisen 47,901

The Foreach is working the way it should. Your problem is that you've used $ADSUsers (which is, presumably, an array) inside the code block instead of $ADUser (which is one item of the array). You've also misspelled "fRist" in the cmdlet's -GivenName parameter.

Here's a clearer way to accomplish this:

$NewUsers |
    ForEach-Object{
        $Params = @{
            GivenName =     $_.First_Name
            SurName =       $_.Last_Name
            Name =               "{0} {1}" -f $_.First_Name, $_.Last_Name
            DisplayName =   "{0} {1}" -f $_.First_Name, $_.Last_Name
            PostalCode =    $_.PostalCode
            OfficePhone =   $_.OfficePhone
            MobilePhone =   $_.MobilePhone
            Path        =   $OU
            Verbose =       $True
        }
        New-ADUser @Params
    }

CmoneyG 21 Reputation points

2021-01-10T22:44:07.75+00:00
When I ran it I got the following results. Also would line 6 create the display name so that it was first space last. and if so how does it work. sorry I am new to this.

New-ADUser : Cannot evaluate parameter 'Name' because its argument is specified as a script block and there is no input. A script block cannot be evaluated without input.
At line:14 char:20

New-ADUser @Params

~~~~~~~

CategoryInfo : MetadataError: (:) [New-ADUser], ParameterBindingException

FullyQualifiedErrorId : ScriptBlockArgumentNoInput,Microsoft.ActiveDirectory.Management.Commands.NewADUser
Rich Matheisen 47,901 Reputation points

2021-01-11T00:11:43.397+00:00
That diagnostic makes it sound as if you're missing the "@" on line #3. Without that a script block would be placed in the $Params variable. If the "@" were present the $Params variable would hold a hash table.

I missed the "Name" parameter in the hash. My bad! Just add another key to the has by adding this line after line #5:

Name = "{0} {1}" -f $_.First+Name, $_.Last_Name

And, I made a type on line #6: Instead of $_.First+Name it should be $First_Name.

I'll make those two corrections to the code I posted.

Yes, the Name and DisplayName will both have a space between the GivenName and Surname.
CmoneyG 21 Reputation points

2021-01-11T00:37:05.763+00:00

@Rich Matheisen

That worked great! I am really excited about learning this. I do have two more questions that I want to ask. and then I promise I will leave you alone for the night!

Name = "{0} {1}" -f $.First+Name, $.Last_Name

When writing the line above how would I know in the future when to use the "{0} {1}" I am sure this is ignorance but I don't actually know what they mean. Also what does the -f stand for. I tried to google it and It just kind of left me scratching my head.

Once again Thank you for your help! This is a much cleaner way of doing things.
Rich Matheisen 47,901 Reputation points

2021-01-11T00:51:09.49+00:00

In its simplest form, the values in the brackets represent the positions of the value in the list following the "-f" operator that will replace the "{n}".

You can add additional formatting instructions within the "{}", too. For instance you might want to left-, or right-justify a string within a fixed length width. Or pad a number with leading zeros. Or format a number as currency (and using periods and commas as appropriate for the current culture). Or you may want to format a floating-point number so it only shows "x" number of decimal positions. The list of what can be done is pretty large.

If you're familiar with other programming languages, the "-f" operator is very much like using the printf or sprintf in "C" or "Perl".

Answer 2

CmoneyG 21

It was a really simple answer! Reddit ended up coming through for me.

First and last are calling the wrong variable it looks like for a start should be $aduser.... not $adusers

Share via

Foreach Loop only running last object

1 additional answer

Your answer