Try one of approaches:
var sand = db.Sandough.Select(x => new SandoughViewModel
{
ID = x.Id,
OnvanSandough = x.OnvanSandough,
Masoul = x.Masoul,
Phone = x.Phone,
SDate = x.SDate,
EDate = x.EDate
}
).ToList().Select( m =>
{
m.SDate = EightToTenDigitShamsi(m.SDate),
m.EDate = EightToTenDigitShamsi(m.EDate)
}.ToList( );
Also check if your original code works if you replace StrSeparator with a literal string.