GIS Converter - Console App -Final code

Question

GIS Converter - Console App -Final code

Dani_S 4,966

Hi Michel,

Thank you very much for your help !!!

I implemented all your remarks from ticket:

https://learn.microsoft.com/en-us/answers/questions/5658212/gis-cli-commands

Can you please look on all code and see if it ok ?

Files

Program code:

GitConverter ConsoleApp README.txt

Program.txt

Thanks in advance,

Answer accepted by question author

1 additional answer

Your answer

Answer 1

Michael Le (WICLOUD CORPORATION) 7,020 Microsoft External Staff Moderator

Hello @Dani_S ,

I see you've put in solid effort implementing the feedback. There are a few things that need adjustment before this is ready though.

The main method issue

Your Main method currently looks like this:

private static void Main(string[] args)
{
    // ... license check ...
    Environment.Exit(Run(args));
}

This conflicts with what your own readme says about testing. Calling Environment.Exit here will kill the test runner. Change it to:

private static int Main(string[] args)
{
    if (! AsposeLicenseManager.ApplyLicense())
    {
        Console.Error.WriteLine("⚠️ Failed to apply Aspose license.");
        return (int)ExitCode.AppError;
    }

    Console. OutputEncoding = System.Text. Encoding.UTF8;
    args = EnsureDebugArgs(args);
    return Run(args);
}

The argument repair logic

TryRepairUnquotedInputArgs tries to fix paths with spaces that weren't quoted. Most cli tools just require proper quoting and throw clear errors when paths are malformed. Consider validating early instead:

if (! File.Exists(inputPath) && !Directory.Exists(inputPath))
{
    Console.WriteLine($"❌ Input path not found: {inputPath}");
    Console.WriteLine("Note: Wrap paths containing spaces in quotes");
    return (int)ExitCode.AppError;
}

Magic numbers

You have if (args.Length < 6) and GetOptionalLogArguments(args, 5) scattered throughout. Use named constants so the code documents itself:

private const int MIN_REQUIRED_ARGS = 5;
private const int LOG_ARGS_START_INDEX = 5;

The single command switch

Your Run method has a switch statement with only one case (gis_convert). Since you only support one command, a simple equality check is clearer:

if (! args[0]. Equals("gis_convert", StringComparison.OrdinalIgnoreCase))
{
    Console.WriteLine($"❌ Unknown command: {args[0]}\n");
    ShowHelp();
    return (int)ExitCode.AppError;
}

return RunGisConverter(args);

Dani_S 4,966 Reputation points

2025-12-18T06:40:46.3633333+00:00
Hi Michel,

You said:

The argument repair logic

TryRepairUnquotedInputArgs tries to fix paths with spaces that weren't quoted. Most cli tools just require proper quoting and throw clear errors when paths are malformed. Consider validating early instead:

Where I put these code:

if (! File.Exists(inputPath) && !Directory.Exists(inputPath))

{

**Console.WriteLine($"❌ Input path not found: {inputPath}");** **Console.WriteLine("Note: Wrap paths containing spaces in quotes");** **return (int)ExitCode.AppError;**

}

I attached the modified code.

Program.txt

This the place where to put it:

// Attempt to repair args if user forgot to quote input path (may contain spaces)

var factoryProbe = new ConverterFactory(); args = TryRepairUnquotedInputArgs(args, factoryProbe); var gisInputFilePath = args[1]; var gisTargetFormatOption = args[2]; var outputFolderPath = args[3]; var tempFolderPath = args[4];

Thanks in advance,

Michael Le (WICLOUD CORPORATION) 7,020 Microsoft External Staff Moderator

Yes, that is correct. You should put that validation in RunGisConverter, right after you extract the input path from the arguments and before you try to use it for anything else.

private static int RunGisConverter(string[] args)
{
    if (args.Length < 6)
    {
        Console.WriteLine("usage: gis_convert <input> <format> <output> <temp> [Log <log_path> [level]]");
        return (int)ExitCode.AppError;
    }

    // Remove this line - no more repair logic
    // args = TryRepairUnquotedInputArgs(args, factoryProbe);

    var gisInputFilePath = args[1];
    var gisTargetFormatOption = args[2];
    var outputFolderPath = args[3];
    var tempFolderPath = args[4];
    // Add validation here, right after extracting the path

    if (! File.Exists(gisInputFilePath) && !Directory.Exists(gisInputFilePath))
    {
        Console.WriteLine($"❌ input path not found: {gisInputFilePath}");
        Console.WriteLine("note: wrap paths containing spaces in quotes");
        return (int)ExitCode.AppError;
    }

    // Continue with the rest of your logic
    var (logFilePath, logLevel) = GetOptionalLogArguments(args, 5);
    SetLogger(logFilePath, logLevel);

    var factory = new ConverterFactory();
    // ... rest of your converter logic

}

Dani_S 4,966 Reputation points

2025-12-18T07:13:18.92+00:00

I see you use in Console.WriteLine("note:

Not a capital letter is it a best practice ?
Michael Le (WICLOUD CORPORATION) 7,020 Reputation points Microsoft External Staff Moderator

2025-12-18T07:15:10.5533333+00:00

You should use capital letters. That is just a habit of mine so don't mind it.
Dani_S 4,966 Reputation points

2025-12-18T08:01:36.0166667+00:00

I fixes all the console the prints with capital letters.

One more question:

I added this print for detect problems, very fast is it OK?

var (logFilePath, logLevel) = GetOptionalLogArguments(args, LOG_ARGS_START_INDEX);

SetLogger(logFilePath, logLevel);

Console.WriteLine($"Args: input='{gisInputFilePath}', format='{gisTargetFormatOption}', output='{outputFolderPath}', temp='{tempFolderPath}', logPath='{logFilePath ?? "<null>"}', logLevel='{logLevel ?? "<null>"}'");
Michael Le (WICLOUD CORPORATION) 7,020 Reputation points Microsoft External Staff Moderator

2025-12-18T08:19:54.03+00:00
It is fine. But make sure to only show it in debug builds. Wrap the line in #if DEBUG like this:

#if DEBUG Console.WriteLine($"Args: input='{gisInputFilePath}', format='{gisTargetFormatOption}', output='{outputFolderPath}', temp='{tempFolderPath}', logPath='{logFilePath ?? "<null>"}', logLevel='{logLevel ?? "<null>"}'"); #endif
Dani_S 4,966 Reputation points

2025-12-18T09:03:05.8666667+00:00

Why in DEBUG ? and all other prints (Console.WriteLine) are not in DEBUG.

My purposes is that user who run the exe for example

D:\GisConverter\Tests\Cmd\Publish>GitConverter.ConsoleApp_1.0.0.0.exe gis_convert D:\GisConverter\Tests\Shapefile\Input\ShapeFiles.7z Shapefile D:\GisConverter\Tests\Cmd\Output D:\GisConverter\Tests\Cmd\Temp Log D:\GisConverter\Tests\Cmd\Log\log.txt All

will see in the results this line is it?

Console.WriteLine($"Args: input='{gisInputFilePath}', format='{gisTargetFormatOption}', output='{outputFolderPath}', temp='{tempFolderPath}', logPath='{logFilePath ?? "<null>"}', logLevel='{logLevel ?? "<null>"}'");

Am I wrong ?
Michael Le (WICLOUD CORPORATION) 7,020 Reputation points Microsoft External Staff Moderator

2025-12-18T09:14:59.03+00:00

This diagnostic line just echoes back what the user already typed. They already know what arguments they passed because they just typed them. It is useful for you as the developer when debugging, but for normal successful runs, it is just noise. That said, if you want to keep it, just feel free to do so.
Dani_S 4,966 Reputation points

2025-12-18T09:33:54.22+00:00

Thank you very much for your help.

You are very professional programmer.

Answer 2

Q&A Assist

AI generated content. This question contains an answer created with AI from Q&A Assist. Learn more

I'm unable to review the code or provide feedback on specific implementations as the context does not contain information on code review processes or specific programming practices. For assistance with your code, consider reaching out to a community of developers or using platforms dedicated to code reviews.

References:

Dani_S 4,966 Reputation points

2025-12-17T08:21:03.6933333+00:00

Hi Michel,

Can you please answer?

Thanks in advance,
Dani_S 4,966 Reputation points

2025-12-17T11:39:16.58+00:00

I attached the wrong Program.cs , here is the correct one.

Porgram.txt

Share via

GIS Converter - Console App -Final code

1 additional answer

Your answer