Sending email to multiple uers using asp.net mvc5

gcobani.mkontwana 1

Hi Team

I want to send email to multiple users and need some help with my logic below;

// Sending email notification to a user.

    public static class EmailNotificationToUser
    {
        public static void SendEmail(string htmlString,string emailGrp, string ToEmail)
        {
            try
            {
                MailMessage message = new MailMessage();
                SmtpClient smtp = new SmtpClient();
                message.From = new MailAddress("gcobani.mkontwana@s4.co.za");
                List<MailAddress> addresses = new List<MailAddress>();
                string[] emilGrp = ToEmail.Split(',');
                foreach(string Multiemail in emailGrp)
                {
                    message.To.Add(new MailAddress(Multiemail));
                }


                message.To.Add(emailGrp);
                message.Subject = "ShopFloor AMS Incident Report";
                message.IsBodyHtml = true;
                message.Body = htmlString;
                smtp.Port = 587;
                smtp.Host = "smtp.gmail.com";
                smtp.EnableSsl = true;
                smtp.UseDefaultCredentials = false;
                smtp.Credentials = new NetworkCredential("entsagcobza2020@gmail.com", "Telkom800@@");
                smtp.DeliveryMethod = SmtpDeliveryMethod.Network;
                smtp.Send(message);


            }catch(Exception ex)
            {

            }
        }
    }

AgaveJoe 26,141 Reputation points

2021-11-22T13:28:18.727+00:00
The foreach loop is trying to loop over a string, emailGrp. I assume the intent is to loop over the string array emilGrp.

string[] emilGrp = ToEmail.Split(','); foreach (string Multiemail in emilGrp) { message.To.Add(new MailAddress(Multiemail)); }

A string is a char array. That's why Visual Studio displays the error; CS0030 cannot convert type 'char' to 'string',
Lan Huang-MSFT 25,866 Reputation points Microsoft Vendor

2021-11-23T09:16:54.44+00:00
Hi @gcobani.mkontwana ,
First, you need to hide information that involves privacy.
Secondly, I found that your code has two problems.

There is no predefined conversion between types:CS0030 cannot convert type'char' to'string'.

In your code, you try to add each address twice: once in the loop, and the second time immediately after it.
Best regards,
Lan Huang