NcryptCreatePersistedKey C++ in VisualStudio

Question

NcryptCreatePersistedKey C++ in VisualStudio

Vivek Gupta 21

API NcryptCreatePersistedKey is not accepting a WCHAR* pointer for the parameter pszKeyName. It crashes . If I give a string literal like L"sample_key" then it works. Can someone pls suggest a workaround?

David Lowndes 4,381 Reputation points MVP

2022-01-18T14:04:03.07+00:00

Show a code example that reproduces your issue.
Vivek Gupta 21 Reputation points

2022-01-18T15:22:00.29+00:00
pcsKeyId = (WCHAR*)HeapAlloc(GetProcessHeap(), 0, count_reqd);
if (NULL == pcsKeyId)
{
wprintf(L"**** memory allocation for pcsKeyId failed\n");
goto Cleanup;
}
MultiByteToWideChar(CP_ACP, 0, pbKeyId, ccCount, pcsKeyId, count_reqd);

//********************************************************************** //open handle to KSP if (FAILED(secStatus = NCryptOpenStorageProvider( &hProv, MS_KEY_STORAGE_PROVIDER, 0))) { wprintf(L"**** Error 0x%x returned by NCryptOpenStorageProvider\n", secStatus); goto Cleanup; } //************************************************************ //************************************************************ //create a persisted key if (FAILED(secStatus = NCryptCreatePersistedKey( hProv, &hKey, NCRYPT_ECDSA_P256_ALGORITHM, pcsKeyId, 0, 0)))

I have pasted a part of the code. The code is basically reading CHAR string from a FILE into pbKeyId and converting it to WCHAR *pcsKeyId, and then passing the pointer to API NcryptCreatePersistedKey. If I replace pcsKeyId with L"samplekey" then it works.
I have printed pcsKeyId string and it looks OK.
David Lowndes 4,381 Reputation points MVP

2022-01-18T15:37:19.113+00:00

Is your wide character string null terminated? Check with the memory debug pane to be sure the pointer you're passing has 2 bytes of 0 at the end of the string.
Vivek Gupta 21 Reputation points

2022-01-18T15:38:27.927+00:00

Pls also note that I have checked that the pcsKeyId string is zero terminated.

Thanks for your time.
David Lowndes 4,381 Reputation points MVP

2022-01-18T15:47:31.043+00:00

What is the return value from NCryptCreatePersistedKey, presumably its NTE_INVALID_PARAMETER?

David Lowndes 4,381 Reputation points MVP

2022-01-18T14:04:03.07+00:00

Show a code example that reproduces your issue.
Vivek Gupta 21 Reputation points

2022-01-18T15:22:00.29+00:00

pcsKeyId = (WCHAR*)HeapAlloc(GetProcessHeap(), 0, count_reqd);
if (NULL == pcsKeyId)
{
wprintf(L"**** memory allocation for pcsKeyId failed\n");
goto Cleanup;
}
MultiByteToWideChar(CP_ACP, 0, pbKeyId, ccCount, pcsKeyId, count_reqd);

//********************************************************************** //open handle to KSP if (FAILED(secStatus = NCryptOpenStorageProvider( &hProv, MS_KEY_STORAGE_PROVIDER, 0))) { wprintf(L"**** Error 0x%x returned by NCryptOpenStorageProvider\n", secStatus); goto Cleanup; } //************************************************************ //************************************************************ //create a persisted key if (FAILED(secStatus = NCryptCreatePersistedKey( hProv, &hKey, NCRYPT_ECDSA_P256_ALGORITHM, pcsKeyId, 0, 0)))

I have pasted a part of the code. The code is basically reading CHAR string from a FILE into pbKeyId and converting it to WCHAR *pcsKeyId, and then passing the pointer to API NcryptCreatePersistedKey. If I replace pcsKeyId with L"samplekey" then it works.
I have printed pcsKeyId string and it looks OK.
David Lowndes 4,381 Reputation points MVP

2022-01-18T15:37:19.113+00:00

Is your wide character string null terminated? Check with the memory debug pane to be sure the pointer you're passing has 2 bytes of 0 at the end of the string.
Vivek Gupta 21 Reputation points

2022-01-18T15:38:27.927+00:00

Pls also note that I have checked that the pcsKeyId string is zero terminated.

Thanks for your time.
David Lowndes 4,381 Reputation points MVP

2022-01-18T15:47:31.043+00:00

What is the return value from NCryptCreatePersistedKey, presumably its NTE_INVALID_PARAMETER?

Answer 1

Viorel 88,321

Try this allocation:

pcsKeyId = (WCHAR*)HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * count_reqd);

Vivek Gupta 21 Reputation points

2022-01-19T05:33:57.883+00:00

Thank you all, it worked. It seems memory allocation was not proper , but somehow pcsKeyId was printing correctly before I passed it to Ncrypt API.

NcryptCreatePersistedKey C++ in VisualStudio

0 additional answers

Activity