This browser is no longer supported.
Upgrade to Microsoft Edge to take advantage of the latest features, security updates, and technical support.
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(185.6, 23%, 27%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3EJD%3C/text%3E%3C/svg%3E)
Appreciate the help - I am doing something wrong. Trying to look for file in folder with todays date and if it doesnt exist send an email. Every result i have is false. I know its true based on echo but still comes back false. Can someone tell me what I am doing wrong please. As you can see from echo below - I have two 20220304 dates, so it should fire the IF result.
Thanks
John
$today = (Get-Date).ToString('yyyyMMdd')
$creationdates = Get-ChildItem -Path 'D:\Folder' -Force | Select-Object -Property @{Name='LastWriteTime'; Expression={$_.LastWriteTime.ToString('yyyyMMdd')}}
echo $creationdates
echo break
echo $today
if ($creationdates -eq $today)
{
Send-MailMessage -SmtpServer mail.server.local -Subject "Backup Success" -From noreply@ublicly visible .com -To me@keyman .com
}
else
{
Send-MailMessage -SmtpServer mail.server.local -Subject "Backup Failed" -From msweb-oma_noreply@ublicly visible .com -To me@keyman .com
}
echo results
-------------
LastWriteTime
-------------
20220304
20220224
20220225
20220226
20220227
20220228
20220301
20220302
20220303
break
20220304
I can’t think of a way that a for each would work. Logically that won’t work. I started with that.
The reason I am doing this is that we run VMware backups of the vCenter. There is no failure alert for those backup. The only way I can think of checking for this - is if the folder has a date from todays date.
Since we keep 7 days of backups. If I do a for-each - and my logic is to loop through 7 days - if I am only alerting on if there is no file for today - it would always come back as false positive failure.
7 files - use case of failure would be no file from today.
7 file - use case of success would be 1 file from today and 6 from previous days.
That is why I pulled dates to an array and searching whole array for a files date that is not today.
Thanks
John
Hi @John Dole ,
I don't get your logic for success = 1 file from today and 6 from previous days .
If you run the script every day and you will get every day a success (file from today exists), after one week I wouldn't care about the files created during the last 6 days. If the script runs every day and 6 days the result is success the only failure for the last 6 days could happen if someone is deleting a file.
With the script from @Rich Matheisen it should be possible to compare the file dates with "between" -> GreaterOrEqual (get-date).AddDays(-7) and LessOrEqual $today
Also it's possible to create a $counter.
Maybe this helps:
$today = (Get-Date).Date
$beforeDate = ((Get-Date).AddDays(-7)).Date
$counter = 0
Get-ChildItem -Path .\Junk -File | ForEach-Object {
if (($_.LastWriteTime.Date -le $today) -and ($_.LastWriteTime.Date -ge $beforeDate)) {
$counter ++
Write-Output "File $($_.Name) has been modified on $($_.LastWriteTime)"
}
else {
Write-Output "$($_.Name) has been modified before $beforedate"
}
}
Write-Output "$counter files modified between $today and $beforedate found"
----------
(If the reply was helpful please don't forget to upvote and/or accept as answer, thank you)
Regards
Andreas Baumgarten
![](data:image/svg+xml, %3Csvg xmlns='http://www.w3.org/2000/svg' height='64' class='font-weight-bold' style='font: 600 30.11764705882353px "SegoeUI", Arial' width='64'%3E%3Ccircle fill='hsl(256, 74%, 34%)' cx='32' cy='32' r='32' /%3E%3Ctext x='50%25' y='55%25' dominant-baseline='middle' text-anchor='middle' fill='%23FFF' %3ERM%3C/text%3E%3C/svg%3E)
I altered the script I posted earlier to incorporate the sending of an email based on finding (or not) a file written "today".
I think your original approach to the problem was incorrect in comparing an array to a scalar (if ($creationdates -eq $today)). The correct usage would be: if ($creationdates -contains $today)
Using string representation of dates is hardly ever a good idea.
Using the example @Andreas Baumgarten posted, here's a safer way:
$today = (Get-Date).Date
$Script:Success = $false
Get-ChildItem -Path .\Junk -File |
ForEach-Object {
if ($_.LastWriteTime.Date -eq $today) {
$Script:Success = $true
}
}
if ($Script:Success){
Send-MailMessage -SmtpServer mail.server.local -Subject "Backup Success" -From noreply@noreply.com -To me@domain.com
}
else{
Send-MailMessage -SmtpServer mail.server.local -Subject "Backup Failed" -From msweb-oma_noreply@noreply.com -To me@domain.com
}
Edit: added code to send an email tailored to the success or failure to find a file written "today".
I like this! - that makes total sense. Start with setting it as false to simulate failure and as it loops through checking - if it finds one for today - then you have success! Smart.
Really I have no intention of sending out success emails - I just did this to test. I only plan on getting emails if its a failure but this is smart - reset it to failure and then as looping through if it passes one that is today - you should be good.
Better than what I had before! Thanks
That's the power of negative thinking!
Hi @John Dole ,
please try this:
$today = (Get-Date).ToString('yyyyMMdd')
Get-ChildItem -Path .\Junk -File | ForEach-Object {
if ($_.LastWriteTime.ToString('yyyyMMdd') -eq $today) {
Write-Output "File $($_.Name) has been modified on $($_.LastWriteTime)"
}
else {
Write-Output "$($_.Name) has been modified before today"
}
}
----------
(If the reply was helpful please don't forget to upvote and/or accept as answer, thank you)
Regards
Andreas Baumgarten