Update Query Assistance

Question

Should be a basic update query, but vfr is never updated. What is incorrect in my queyr?

Update Mosa
  Set pv = 0
  ,vfr = 'Invalid Input;'+vfr
  WHERE Quantity = 0 OR Quantity IS NULL
  AND processed_file IS NULL

Answer 1

In this case, it is a simple fix:

Update Mosa
  Set pv = 0
  ,vfr = 'Invalid Input;'+ISNULL(vfr,'')
  WHERE Quantity = 0 OR Quantity IS NULL
  AND processed_file IS NULL

Run it only once.

Answer 2

Just to add to Naomi's response.

CONCAT is a safer way to combine strings. It handles NULL values.

vfr = CONCAT('Invalid Input;',vfr)

Answer 3

The query looks OK. If you turn it into select statement, do you get result? Also, you can add OUTPUT Deleted., Inserted. to see what happened.