Control Not Coming Back to Parent Method Even after Using Aync and Await

Question

Control Not Coming Back to Parent Method Even after Using Aync and Await

Ali Basha 21

Hi,

I have Web API method(in .net Core), under which I am calling a long running method, but control is coming back to Parent method, only after executing the logic of Long Running method. Below is my code.

[HttpPost]  
        [Authorize(AuthenticationSchemes = Microsoft.AspNetCore.Authentication.JwtBearer.JwtBearerDefaults.AuthenticationScheme)]  
        public async Task<IActionResult> Post([FromBody] Master oMaster)  
        {  
            try  
            {  
                if (ModelState.IsValid)  
                {  
                     case MasterHelper.Tables.JobFunctionTeamLink:  
                                var oJobFunctionTeamLink = Common.GetConversionJsonObject<JobFunctionTeamLink>(oMaster.Data.ToString());  
                                var _oJobFunctionTeamLinkObject = Common.GetConvertionObjectByType<JobFunctionTeamLink>(oJobFunctionTeamLink);  
                                if (Validator.TryValidateObject(_oJobFunctionTeamLinkObject, new ValidationContext(_oJobFunctionTeamLinkObject), validationresults, true))  
                                {  
                                    var data = new JobFunctionTeamLink();  
                                    var missingattributs = Common.GetPropertiesNameOfClass(data, oJobFunctionTeamLink);  
                                    if (missingattributs != null && missingattributs.Count > 0)  
                                    {  
                                        return StatusCode(StatusCodes.Status400BadRequest, Common.ResponseFailure(oMaster.RequestId.ToString(), string.Join(",", missingattributs)));  
                                    }  
                                    var _UserJobFunctionTeamList = Common.GetPropertiesNameOfClassUserTeam(_oJobFunctionTeamLinkObject);  
                                    message = _masterDAL.SaveJobFunctionTeamLinkDetails(_UserJobFunctionTeamList, oMaster.RequestId);  
                                   string savemsg= await _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);  
                                    return string.IsNullOrEmpty(message)  
                                    ? StatusCode(StatusCodes.Status200OK, Common.ResponseSucess(oMaster.RequestId.ToString()))  
                                    : StatusCode(StatusCodes.Status400BadRequest, Common.ResponseFailure(oMaster.RequestId.ToString(), message));  
                                }  

   } }  }  

 
Long Running Task which would take more time, is shown below.  
public async Task<string> SaveProjectUserSecurity(Guid JobFunctionGuid, Guid reqId)  
        {  
            try  
            {  
                string dbmessage=string.Empty;  
                await Task.Run(() =>  
                {  
                    var sql = new SqlHelper(ConnectionString);  
                    sql.ExecuteNonQuery("sp_CRM_SaveProjectUserSecurity", "@reqId", "@JobFunctionGUID", reqId, JobFunctionGuid, out dbmessage, CommandType.StoredProcedure, "@strComments");  
  
                }).ConfigureAwait(true);  
                return dbmessage;  
            }  
            catch (Exception ex)  
            {  
                throw;  
            }  
        }

Kindly note, control is coming back to parent method only after executing the method "SaveProjectUserSecurity", I tried without ConfigureAwait, with ConfigureAwait(True) and also ConfigureAwait(false), all 3 not working as expected.

Any help or clue would be highly appreciated. Thanks,

Answer 1

Viorel 89,136

If you are not interested in the result (savemsg), then try this:

Task<string> t = _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);

Ali Basha 21

Thanks for your quick response Viorel.

I have changed the code as per your suggestion, but still control coming only after completing long running method i.;e "SaveProjectUserSecurity"

Below is my modified code.

 message = _masterDAL.SaveJobFunctionTeamLinkDetails(_UserJobFunctionTeamList, oMaster.RequestId);  
                                    await _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);  


  
 public async Task SaveProjectUserSecurity(Guid JobFunctionGuid, Guid reqId)  
        {  
            try  
            {  
                string dbmessage=string.Empty;  
                await Task.Run(() =>  
                {  
                    var sql = new SqlHelper(ConnectionString);  
                    sql.ExecuteNonQuery("sp_CRM_SaveProjectUserSecurity", "@reqId", "@JobFunctionGUID", reqId, JobFunctionGuid, out dbmessage, CommandType.StoredProcedure, "@strComments");  
  
                }).ConfigureAwait(true);  
                //return dbmessage;  
            }  
            catch (Exception ex)  
            {  
                throw;  
            }  
        }

Viorel 89,136 Reputation points

2022-08-21T15:03:49.51+00:00

Try this modification:

Task<string> t = _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);
Bruce (SqlWork.com) 31,651 Reputation points

2022-08-21T16:22:00.333+00:00

Remove the await on line two in front of calling SaveProjectUserSecurity() This also implies the message returned from SaveProjectUserSecurity() will not be available.

Ali Basha 21

Dear Viorel,
Thanks for the help. I have modified the code like below, it worked.

Task<string> savemsg = _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);  
  
 public async Task<string> SaveProjectUserSecurity(Guid JobFunctionGuid, Guid reqId)  
        {  
               //Logic removed to save space  
                return dbmessage;  
            }

But can you please tell me, why it its not working if we use await key word like below

 await _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);  
  
or   

string savemsg= await _masterDAL.SaveProjectUserSecurity(_UserJobFunctionTeamList[0].JobFunctionGUID, oMaster.RequestId);

Control Not Coming Back to Parent Method Even after Using Aync and Await

0 additional answers

Activity