Share via

C26167

  • Article

warning C26167: Possibly releasing unheld lock <lock> in function <func>.

Warning C26167 resembles warning C26117 except that the confidence level is lower. For example, the function may contain annotation errors.

Example

The following code will generate C26167, as well as C26110.

typedef struct _DATA { 
    CRITICAL_SECTION cs; 
} DATA; 

_Releases_lock_(p->cs) void Leave(DATA* p) { 
    LeaveCriticalSection(&p->cs); // OK 
} 
void ReleaseUnheldLock(DATA* p) { // Warning C26167
    int i = 0;
    Leave(p); // Warning C26110
}

The following code will correct these warnings.

typedef struct _DATA { 
    CRITICAL_SECTION cs; 
} DATA; 

_Releases_lock_(p->cs) void Leave(DATA* p) { 
    LeaveCriticalSection( &p->cs );
} 

void ReleaseUnheldLock( DATA* p ) {
    EnterCriticalSection( &p->cs );
    int i = 0;
    Leave(p);
}