Listbox add item makes logic not work

Question

I have a listbox that has 3 items at design time, my logic works, but if I add a button that adds 100 items at run time it does NOT.
I am trying to switch the color of the selection to a different colors with a case statement.

 public int caseSwitch { get; private set; }

        public MainWindow()
        {
            InitializeComponent();
            this.DataContext = new MyViewModel(caseSwitch);

        }

        private void ListBox1_SelectionChanged(object sender, SelectionChangedEventArgs e)
        {
            this.DataContext = new MyViewModel(caseSwitch);
        }

        private void label1_MouseDown(object sender, MouseButtonEventArgs e)
        {
            caseSwitch = 1;
        }






    public class MyViewModel : INotifyPropertyChanged
    {
    public event PropertyChangedEventHandler PropertyChanged;

    Random r = new Random();
    private SolidColorBrush _scb = new SolidColorBrush();
    public SolidColorBrush Scb

    {
    get { return _scb; }
    set { _scb = value; PropertyChanged?.Invoke(this, new PropertyChangedEventArgs("Scb")); }
    }



    public MyViewModel(int caseSwitch)
    {
    switch (caseSwitch)
    {
    case 1:
    Scb = new SolidColorBrush(Color.FromRgb((byte)r.Next(1, 255), (byte)r.Next(1, 255), (byte)r.Next(1, 233)));

    //Console.WriteLine("Case 1");
    break;

    case 2:
    Scb = new SolidColorBrush(Color.FromRgb(255, 160, 122));
    break;


    default:
    Scb = new SolidColorBrush(SystemColors.HighlightBrush.Color);
    break;

    }

    }

Answer

Hi, It's not necessary to set a new ViewModel instance. In this case you must refresh the whole MainWindow. The better approach is to use the same instance and change only the property in this instance.

Try this demo:

XAML:

Code:

using System;
using System.ComponentModel;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Input;
using System.Windows.Media;

namespace WpfApp1
{
  /// 
  /// Interaction logic for Window23.xaml
  /// 
  public partial class Window23 : Window
  {
    public Window23()
    {
      InitializeComponent();
      this.DataContext = vm;
    }

    MyViewModel vm = new MyViewModel();

    private void Label_MouseDown(object sender, MouseButtonEventArgs e) => vm.CaseSwitch = 1;

    private void ListBox1_SelectionChanged(object sender, SelectionChangedEventArgs e) => vm.SetScb();

    public class MyViewModel : INotifyPropertyChanged
    {
      public event PropertyChangedEventHandler PropertyChanged;
      public int CaseSwitch { get; set; }

      Random r = new Random();
      private SolidColorBrush _scb = new SolidColorBrush();
      public SolidColorBrush Scb

      {
        get { return _scb; }
        set { _scb = value; PropertyChanged?.Invoke(this, new PropertyChangedEventArgs("Scb")); }
      }

      public void SetScb()
      {
        switch (CaseSwitch)
        {
          case 1:
            Scb = new SolidColorBrush(Color.FromRgb((byte)r.Next(1, 255), (byte)r.Next(1, 255), (byte)r.Next(1, 233)));
            break;
          case 2:
            Scb = new SolidColorBrush(Color.FromRgb(255, 160, 122));
            break;
          default:
            Scb = new SolidColorBrush(SystemColors.HighlightBrush.Color);
            break;
        }
      }
    }
  }
}

Answer

Hi thanks for your answer,

But the label is bound here, the listbox item needs to be bound.

The label should be for example red, and clicking on it and selecting the listbox item should make the listbox item red.

The probelm i am having is the button that adds the items, stops it working.

  private void button_Click(object sender, RoutedEventArgs e)

            { 

                for (int i = 1; i<101; i++)
                {

                   listBox1.Items.Add("This is item number " + i);
                }}

Answer

Hi, for changing background color you can use Style like in following demo:

XAML:

Code:

using System.Collections.ObjectModel;
using System.Windows;

namespace WpfApp1
{
  public partial class Window23 : Window
  {
    public Window23()
    {
      InitializeComponent();
      this.DataContext = vm;
    }

    MyViewModel vm = new MyViewModel();

    private void Button_Click(object sender, RoutedEventArgs e) => vm.AddItem();

    public class MyViewModel
    {
      private ObservableCollection col = new ObservableCollection();
      public ObservableCollection View => col;

      private int i = 1;
      internal void AddItem() => col.Add($"This is item number {i++}");
    }
  }
}

Answer

It functions as predicted.
The button breaks it.
Why?
How to get it to work?

Answer

Hi, in your last posted code you use many instances of MyViewModel and in your Style the reference to Scb is broken. Try following demo. It works without problems:

XAML:

Code:

using System;
using System.ComponentModel;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Input;
using System.Windows.Media;
using WpfApp24;

namespace WpfApp1
{
  public partial class Window24 : Window
  {
    public Window24()
    {
      InitializeComponent();
    }
    private void Window_Loaded(object sender, RoutedEventArgs e) => vm = this.Resources["vm"] as MyViewModel;
    private MyViewModel vm;
    public int caseSwitch { get; private set; }
    private void ListBox1_SelectionChanged(object sender, SelectionChangedEventArgs e) =>
      vm.SetScb(caseSwitch);
    private void label1_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 1;
    private void label_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 7;
    private void button_Click(object sender, RoutedEventArgs e)
    {
      for (int i = 1; i < 101; i++)
      {
        listBox1.Items.Add("This is item number " + i);
      }
    }
    private void label2_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 2;
    private void label3_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 3;
    private void label4_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 4;
    private void label5_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 5;
    private void label6_MouseDown(object sender, MouseButtonEventArgs e) => caseSwitch = 6;
  }
}
namespace WpfApp24
{
  public class MyViewModel : INotifyPropertyChanged
  {
    public event PropertyChangedEventHandler PropertyChanged;
    Random r = new Random();
    private SolidColorBrush _scb = new SolidColorBrush();
    public SolidColorBrush Scb
    {
      get { return _scb; }
      set { _scb = value; PropertyChanged?.Invoke(this, new PropertyChangedEventArgs("Scb")); }
    }
    public void SetScb(int caseSwitch)
    {
      switch (caseSwitch)
      {
        case 7:
          Scb = new SolidColorBrush(Color.FromRgb((byte)r.Next(1, 255), (byte)r.Next(1, 255), (byte)r.Next(1, 233)));
          break;
        case 1:
          Scb = new SolidColorBrush(Color.FromRgb(255, 0, 0));
          break;
        case 2:
          Scb = new SolidColorBrush(Color.FromRgb(0, 204, 153));
          break;
        case 3:
          Scb = new SolidColorBrush(Color.FromRgb(255, 255, 51));
          break;
        case 4:
          Scb = new SolidColorBrush(Color.FromRgb(0, 255, 0));
          break;
        case 5:
          Scb = new SolidColorBrush(Color.FromRgb(255, 0, 255));
          break;
        case 6:
          Scb = new SolidColorBrush(Color.FromRgb(0, 255, 255));
          break;
        default:
          Scb = new SolidColorBrush(SystemColors.HighlightBrush.Color);
          break;
      }
    }
  }
}

Share via

Listbox add item makes logic not work

6 answers

Your answer