Change a module in the System Application
This article provides an overview of how to change an existing module.
Requirements
- Familiarity with development in AL. For more information, see AL Development.
- Your local repository and development environment are ready. For more information, see Set Up an Environment for Developing a Module.
Note
Your environment must have the correct symbols. Go get those, in Visual Studio Code, select F1, and then choose AL: Download Symbols. Also, make a note of the server and serverInstance settings. You will add that information to the launch.json file.
Your changes must follow the guidelines for module architecture. For more information, see Module Architecture. When changing an existing module, don't introduce breaking changes, that is, make sure that you don't break existing functionality. Existing tests must still pass, and you should add new tests for the functionality that you change or add. Your changes must follow the guidelines for module architecture. For more information, see Module Architecture. When changing an existing module, don't introduce breaking changes, that is, make sure that you don't break existing functionality. Existing tests must still pass, and you should add new tests for the functionality that you change or add.
Set up Visual Studio Code for module development
Open the launch.json, file and update the server, serverInstance, and authentication settings, as described in Set Up Your Development Environment.
"server": "http://YourDockerContainerName",
"serverInstance": "BC",
"authentication": "UserPassword",
Open the settings.json file, and update the al.assemblyProbingPaths, as described in Set Up Your Development Environment.
Create a branch
To create a branch, run the git checkout -b "YourFeatureBranchName" command. Afterward, you can start creating a new module.
Change an existing module
The following sections provide an example of how to contribute to an existing module. The example is based on a previous contribution to the Base64 Convert module, which has been published in the legacy ALAppExtensions repository. The contribution added support for text encodings other than UTF8. If you're interested, you can view the original pull request at Pull Request 7676.
For new contributions, please refer to BCApps repository.
Make changes to a module
Before making changes, make sure you're familiar with the general architecture of system modules. For more information, see Module Architecture. You can also check out the article titled How to add a system module for an example of creating a full system module.
We'll start by adding the functions that we need to support different text encodings to the internal implementation codeunit. We'll add the following functions to the System/Base64 Convert/src/Base64ConvertImpl.Codeunit.al implementation codeunit:
procedure ToBase64(String: Text; TextEncoding: TextEncoding): Text
begin
exit(ToBase64(String, false, TextEncoding, 0));
end;
procedure ToBase64(String: Text; TextEncoding: TextEncoding; Codepage: Integer): Text
begin
exit(ToBase64(String, false, TextEncoding, Codepage));
end;
procedure ToBase64(String: Text; InsertLineBreaks: Boolean; TextEncoding: TextEncoding): Text
begin
exit(ToBase64(String, InsertLineBreaks, TextEncoding, 0));
end;
procedure ToBase64(String: Text; InsertLineBreaks: Boolean; TextEncoding: TextEncoding; Codepage: Integer): Text
var
Convert: DotNet Convert;
Encoding: DotNet Encoding;
Base64FormattingOptions: DotNet Base64FormattingOptions;
Base64String: Text;
begin
if String = '' then
exit('');
if InsertLineBreaks then
Base64FormattingOptions := Base64FormattingOptions.InsertLineBreaks
else
Base64FormattingOptions := Base64FormattingOptions.None;
case TextEncoding of
TextEncoding::UTF16:
Base64String := Convert.ToBase64String(Encoding.Unicode().GetBytes(String), Base64FormattingOptions);
TextEncoding::MSDos,
TextEncoding::Windows:
Base64String := Convert.ToBase64String(Encoding.GetEncoding(CodePage).GetBytes(String), Base64FormattingOptions);
else
Base64String := Convert.ToBase64String(Encoding.UTF8().GetBytes(String), Base64FormattingOptions);
end;
exit(Base64String);
end;
procedure FromBase64(Base64String: Text; TextEncoding: TextEncoding): Text
begin
exit(FromBase64(Base64String, TextEncoding, 1252));
end;
procedure FromBase64(Base64String: Text; TextEncoding: TextEncoding; CodePage: Integer): Text
var
Convert: DotNet Convert;
Encoding: DotNet Encoding;
OutputString: Text;
begin
if Base64String = '' then
exit('');
case TextEncoding of
TextEncoding::UTF16:
OutputString := Encoding.Unicode().GetString(Convert.FromBase64String(Base64String));
TextEncoding::MSDos,
TextEncoding::Windows:
OutputString := Encoding.GetEncoding(CodePage).GetString(Convert.FromBase64String(Base64String));
else
OutputString := Encoding.UTF8().GetString(Convert.FromBase64String(Base64String));
end;
exit(OutputString);
end;
We also need to update some of the existing functions in System/Base64 Convert/src/Base64ConvertImpl.Codeunit.al, while making sure that they keep the same functionality:
procedure ToBase64(String: Text): Text
begin
exit(ToBase64(String, false));
end;
procedure ToBase64(String: Text; InsertLineBreaks: Boolean): Text
begin
exit(ToBase64(String, InsertLineBreaks, TextEncoding::UTF8, 0));
end;
procedure FromBase64(Base64String: Text): Text
begin
exit(FromBase64(Base64String, TextEncoding::UTF8, 0));
end;
We have changed the implementation codeunit, and avoided breaking existing functionality by keeping the same behavior for existing functions.
Now we'll add public functions in the facade codeunit with the functionality that we want to expose. Because the functions are public, we need to ensure that they're documented and tested. The functions call the corresponding functions in the implementation codeunit. We add the following functions to System/Base64 Convert/src/Base64Convert.Codeunit.al:
/// <summary>
/// Converts the value of the input string to its equivalent string representation that is encoded with base-64 digits.
/// </summary>
/// <param name="String">The string to convert.</param>
/// <param name="TextEncoding">The TextEncoding for the input string.</param>
/// <returns>The string representation, in base-64, of the input string.</returns>
procedure ToBase64(String: Text; TextEncoding: TextEncoding): Text
begin
exit(Base64ConvertImpl.ToBase64(String, TextEncoding));
end;
/// <summary>
/// Converts the value of the input string to its equivalent string representation that is encoded with base-64 digits.
/// </summary>
/// <param name="String">The string to convert.</param>
/// <param name="TextEncoding">The TextEncoding for the input string.</param>
/// <param name="Codepage">The Codepage if TextEncoding is MsDos or Windows.</param>
/// <returns>The string representation, in base-64, of the input string.</returns>
procedure ToBase64(String: Text; TextEncoding: TextEncoding; Codepage: Integer): Text
begin
exit(Base64ConvertImpl.ToBase64(String, TextEncoding, Codepage));
end;
/// <summary>
/// Converts the specified string, which encodes binary data as base-64 digits, to an equivalent regular string.
/// </summary>
/// <param name="Base64String">The string to convert.</param>
/// <param name="TextEncoding">The TextEncoding for the input string.</param>
/// <returns>Regular string that is equivalent to the input base-64 string.</returns>
/// <error>The length of Base64String, ignoring white-space characters, is not zero or a multiple of 4.</error>
/// <error>The format of Base64String is invalid. Base64String contains a non-base-64 character, more than two padding characters,
/// or a non-white space-character among the padding characters.</error>
procedure FromBase64(Base64String: Text; TextEncoding: TextEncoding): Text
begin
exit(Base64ConvertImpl.FromBase64(Base64String, TextEncoding));
end;
/// <summary>
/// Converts the specified string, which encodes binary data as base-64 digits, to an equivalent regular string.
/// </summary>
/// <param name="Base64String">The string to convert.</param>
/// <param name="TextEncoding">The TextEncoding for the inout string.</param>
/// <param name="Codepage">The Codepage if TextEncoding is MsDos or Windows.</param>
/// <returns>Regular string that is equivalent to the input base-64 string.</returns>
/// <error>The length of Base64String, ignoring white-space characters, is not zero or a multiple of 4.</error>
/// <error>The format of Base64String is invalid. Base64String contains a non-base-64 character, more than two padding characters,
/// or a non-white space-character among the padding characters.</error>
procedure FromBase64(Base64String: Text; TextEncoding: TextEncoding; Codepage: Integer): Text
begin
exit(Base64ConvertImpl.FromBase64(Base64String, TextEncoding, Codepage));
end;
We have now exposed the functions. The next steps are to ensure that existing tests pass, and then add new tests for the functionality that we added.
After verifying that the tests pass, we'll add the following tests to the System Tests/Base64 Convert/src/Base64ConvertTest.Codeunit.al file.
[Test]
procedure StringToBase64UTF16Test()
var
ConvertedText: Text;
begin
// [SCENARIO] A string variable is converted to base-64 string, binary representation is kept in UTF16
// [WHEN] The string is converted
ConvertedText := Base64Convert.ToBase64(SampleUTF16Txt, TextEncoding::UTF16);
// [THEN] The converted value is correct
Assert.AreEqual(Base64SampleUTF16Txt, ConvertedText, ConvertionToBase64UTF16Err);
end;
[Test]
procedure FromBase64UTF16StringTest()
var
ConvertedText: Text;
begin
// [SCENARIO] A base-64 string with UTF16 encoding is converted to a regular string
// [WHEN] The base-64 string is converted
ConvertedText := Base64Convert.FromBase64(Base64SampleUTF16Txt, TextEncoding::UTF16);
// [THEN] The converted value is correct
Assert.AreEqual(SampleUTF16Txt, ConvertedText, ConvertionFromBase64UTF16Err);
end;
Commit and push changes, and open a pull request
To submit your changes, follow these steps:
- To commit your changes, run the git commit -m "Your message" command.
- To push your changes, run the git push command.
You can now go to your GitHub fork and open a pull request in the BCApps repository.
See also
Become a contributor
"Git" going with extensions (requires sign in)
Walkthrough: Contributing to an extension on GitHub (requires sign in)
Create a new module