Members should not expose certain concrete types
TypeName |
MembersShouldNotExposeCertainConcreteTypes |
CheckId |
CA1059 |
Category |
Microsoft.Design |
Breaking Change |
Breaking |
Cause
An externally visible member is a certain concrete type or exposes certain concrete types through one of its parameters or return value. Currently, this rule reports exposure of the following concrete types:
- A type derived from System.Xml.XmlNode.
Rule Description
A concrete type is a type that has a complete implementation and therefore can be instantiated. To allow widespread use of the member, replace the concrete type with the suggested interface. This allows the member to accept any type that implements the interface or be used where a type that implements the interface is expected.
The following table lists the targeted concrete types and their suggested replacements.
| Concrete type | Replacement |
|---|---|
XmlNode |
System.Xml.Xpath.IXPathNavigable. Using the interface decouples the member from a specific implementation of an XML data source. |
How to Fix Violations
To fix a violation of this rule, change the concrete type to the suggested interface.
When to Exclude Warnings
It is safe to exclude a message from this rule if the specific functionality provided by the concrete type is required.