Review visible event handlers

TypeName	ReviewVisibleEventHandlers
CheckId	CA2109
Category	Microsoft.Security
Breaking Change	Breaking

Cause

A public or protected event-handling method was detected.

Rule Description

An externally visible event-handling method presents a security issue that requires review.

Event-handling methods should not be exposed unless absolutely necessary. An event handler, a delegate type, that invokes the exposed method can be added to any event as long as the handler and event signatures match. Events can potentially be raised by any code, and are frequently raised by highly trusted system code in response to user actions such as clicking a button. Adding a security check to an event-handling method does not prevent code from registering an event handler that invokes the method.

A demand cannot reliably protect a method invoked by an event handler. Security demands help protect code from untrusted callers by examining the callers on the call stack. Code that adds an event handler to an event is not necessarily present on the call stack when the event handler's methods run. Because of this, the call stack might have only highly trusted callers when the event handler method is invoked, causing demands made by the event handler method to succeed. Also, the demanded permission might be asserted when the method is invoked. For these reasons, the risk of not fixing a violation of this rule can only be assessed after reviewing the event-handling method. When you review your code, consider the following issues:

• Does your event handler perform any operations that are dangerous or exploitable, such as asserting permissions or suppressing unmanaged code permission?

• What are the security threats to and from your code given that it can run at any time with only highly trusted callers on the stack?

How to Fix Violations

To fix a violation of this rule, review the method and evaluate the following:

• Can you make the event-handling method non-public?

• Can you move all dangerous functionality out of the event handler?

• If a security demand is imposed, can this be accomplished in some other manner?

When to Exclude Warnings

Exclude a warning from this rule only after a careful security review to ensure that your code does not pose a security threat.

Example

The following code shows an event-handling method that can be misused by malicious code.

using System;
using System.Security;
using System.Security.Permissions;

namespace EventSecLibrary
{
   public class HandleEvents
   {
      // Due to the access level and signature, a malicious caller could 
      // add this method to system-triggered events where all code in the call
      // stack has the demanded permission.

      // Also, the demand might be canceled by an asserted permission.

      [SecurityPermissionAttribute(SecurityAction.Demand, UnmanagedCode=true)]

      // Violates rule: ReviewVisibleEventHandlers.
      public static void SomeActionHappened(Object sender, EventArgs e)
      {
         Console.WriteLine ("Do something dangerous from unmanaged code.");
      }

   }
}

See Also

Reference

System.Security.CodeAccessPermission.Demand
System.EventArgs

Concepts

Security Demands